Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorder and fix tags #12303

Merged
merged 2 commits into from
Jan 11, 2021
Merged

reorder and fix tags #12303

merged 2 commits into from
Jan 11, 2021

Conversation

dagoroz
Copy link
Contributor

@dagoroz dagoroz commented Jan 6, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@dagoroz dagoroz requested a review from lirenhe as a code owner January 6, 2021 18:53
@openapi-workflow-bot
Copy link

Hi, @dagoroz Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 6, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 6, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from fee34e8. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-11 13:54:19 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-authorization-generated"
cmderr	[generate.py] 2021-01-11 13:54:19 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-11 13:54:19 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.8 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/authorization/azure-resourcemanager-authorization-generated --java.namespace=com.azure.resourcemanager.authorization.generated  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
cmderr	[generate.py] 2021-01-11 13:54:57 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-11 13:54:57 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-11 13:54:57 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-11 13:54:57 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-11 13:54:57 INFO [POM][Skip] pom already has module sdk/authorization
cmderr	[generate.py] 2021-01-11 13:54:57 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-authorization-generated [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-01-11 13:57:21 DEBUG Got artifact_id: azure-resourcemanager-authorization-generated
cmderr	[Inst] 2021-01-11 13:57:21 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-11 13:57:21 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-01-11 13:57:21 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-11 13:57:21 DEBUG Match jar package: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-11 13:57:21 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12303/azure-sdk-for-java/azure-resourcemanager-authorization-generated/azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-authorization-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from fee34e8. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/authorization/mgmt/2018-09-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/authorization/mgmt/2018-07-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/authorization/mgmt/2018-01-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/authorization/mgmt/2017-10-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️authorization/mgmt/2015-07-01/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    ️🔄 azure-sdk-for-net inProgress [Detail]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from fee34e8. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
    • ️✔️@azure/arm-authorization [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/authorizationManagementClient.js → ./dist/arm-authorization.js...
cmderr	[npmPack] created ./dist/arm-authorization.js in 197ms
    ️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from fee34e8. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
    • ️✔️azure-mgmt-authorization [View full logs]  [Release SDK Changes] 
      cmderr	[multiapi_init_gen.py azure-mgmt-authorization --default-api-version=2018-09-01-preview] INFO:__main__:Default API version will be: v2018_09_01_preview
cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-authorization
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-authorization
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization.v2015_06_01
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.authorization.v2015_06_01
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization.v2015_07_01
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.authorization.v2015_07_01
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization.v2018_01_01_preview
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.authorization.v2018_01_01_preview
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization.v2018_05_01_preview
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.authorization.v2018_05_01_preview
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization.v2018_07_01_preview
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.authorization.v2018_07_01_preview
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization.v2018_09_01_preview
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.authorization.v2018_09_01_preview
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization.v2020_04_01_preview
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.authorization.v2020_04_01_preview
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.authorization.v2015_06_01
cmderr	[changelogReport] INFO:__main__:Report written to sdk/authorization/azure-mgmt-authorization/code_reports/latest/v2015_06_01.json
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.authorization.v2015_07_01
cmderr	[changelogReport] INFO:__main__:Report written to sdk/authorization/azure-mgmt-authorization/code_reports/latest/v2015_07_01.json
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.authorization.v2018_01_01_preview
cmderr	[changelogReport] INFO:__main__:Report written to sdk/authorization/azure-mgmt-authorization/code_reports/latest/v2018_01_01_preview.json
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.authorization.v2018_05_01_preview
cmderr	[changelogReport] INFO:__main__:Report written to sdk/authorization/azure-mgmt-authorization/code_reports/latest/v2018_05_01_preview.json
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.authorization.v2018_07_01_preview
cmderr	[changelogReport] INFO:__main__:Report written to sdk/authorization/azure-mgmt-authorization/code_reports/latest/v2018_07_01_preview.json
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.authorization.v2018_09_01_preview
cmderr	[changelogReport] INFO:__main__:Report written to sdk/authorization/azure-mgmt-authorization/code_reports/latest/v2018_09_01_preview.json
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.authorization.v2020_04_01_preview
cmderr	[changelogReport] INFO:__main__:Report written to sdk/authorization/azure-mgmt-authorization/code_reports/latest/v2020_04_01_preview.json
cmderr	[changelogReport] INFO:__main__:Merged report written to sdk/authorization/azure-mgmt-authorization/code_reports/latest/merged_report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-authorization on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.30.0a1', '0.30.0rc1', '0.30.0rc2', '0.30.0rc3', '0.30.0rc4', '0.30.0rc5', '0.30.0rc6', '0.30.0', '0.40.0', '0.50.0', '0.51.0', '0.51.1', '0.52.0', '0.60.0', '0.61.0', '1.0.0b1', '1.0.0']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.61.0 of azure-mgmt-authorization in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization.v2015_06_01
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.authorization.v2015_06_01
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization.v2015_07_01
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.authorization.v2015_07_01
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization.v2018_01_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.authorization.v2018_01_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization.v2018_07_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.authorization.v2018_07_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization.v2018_09_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.authorization.v2018_09_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.authorization.v2020_04_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.authorization.v2020_04_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.authorization.v2015_06_01
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/authorization/azure-mgmt-authorization/code_reports/0.61.0/v2015_06_01.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.authorization.v2015_07_01
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/authorization/azure-mgmt-authorization/code_reports/0.61.0/v2015_07_01.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.authorization.v2018_01_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/authorization/azure-mgmt-authorization/code_reports/0.61.0/v2018_01_01_preview.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.authorization.v2018_07_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/authorization/azure-mgmt-authorization/code_reports/0.61.0/v2018_07_01_preview.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.authorization.v2018_09_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/authorization/azure-mgmt-authorization/code_reports/0.61.0/v2018_09_01_preview.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.authorization.v2020_04_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/authorization/azure-mgmt-authorization/code_reports/0.61.0/v2020_04_01_preview.json
cmderr	[changelogReportLatest] INFO:__main__:Merged report written to sdk/authorization/azure-mgmt-authorization/code_reports/0.61.0/merged_report.json
cmdout	[Changelog] Size of delta 64.028% size of original (original: 44790 chars, delta: 28678 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model RoleAssignment has a new parameter created_on
cmdout	[Changelog]   - Model RoleAssignment has a new parameter created_by
cmdout	[Changelog]   - Model RoleAssignment has a new parameter updated_on
cmdout	[Changelog]   - Model RoleAssignment has a new parameter delegated_managed_identity_resource_id
cmdout	[Changelog]   - Model RoleAssignment has a new parameter updated_by
cmdout	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsAssignedForMyApprovalOperations
cmdout	[Changelog]   - Added operation group AccessReviewInstancesOperations
cmdout	[Changelog]   - Added operation group AccessReviewDefaultSettingsOperations
cmdout	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsOperations
cmdout	[Changelog]   - Added operation group AccessReviewInstanceOperations
cmdout	[Changelog]   - Added operation group AccessReviewInstancesAssignedForMyApprovalOperations
cmdout	[Changelog]   - Added operation group AccessReviewInstanceDecisionsOperations
cmdout	[Changelog]   - Added operation group AccessReviewInstanceMyDecisionsOperations
cmdout	[Changelog]   - Added operation group Operations
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from fee34e8. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleAssignmentId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleAssignmentId}': Unable to locate '/providers/' segment
    • ️✔️authorization [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Jan 7, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    @dagoroz
    Copy link
    Contributor Author

    dagoroz commented Jan 8, 2021

    @ArcturusZhang ping

    ArcturusZhang
    ArcturusZhang approved these changes Jan 11, 2021
    View reviewed changes
    Copy link
    Member

    @ArcturusZhang ArcturusZhang left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @ArcturusZhang ArcturusZhang merged commit fee34e8 into Azure:master Jan 11, 2021
    This was referenced Jan 11, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

    @lirenhe lirenhe Awaiting requested review from lirenhe

    Assignees

    @qianwens qianwens

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @dagoroz @ArcturusZhang @qianwens