AAS - Fix Swagger Correctness Issue #12306

david-msft · 2021-01-06T23:06:41Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Merge Master

openapi-workflow-bot · 2021-01-06T23:06:43Z

Hi, @david-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-06T23:06:44Z

Swagger Validation Report

️❌BreakingChange: 16 Errors, 0 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.5)
- original: preview/2017-08-01-beta/analysisservices.json <---> new: preview/2017-08-01-beta/analysisservices.json
- original: stable/2016-05-16/analysisservices.json <---> new: stable/2016-05-16/analysisservices.json
- original: stable/2017-07-14/analysisservices.json <---> new: stable/2017-07-14/analysisservices.json
- original: stable/2017-08-01/analysisservices.json <---> new: stable/2017-08-01/analysisservices.json

Rule	Message
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) '0' from the old version. New: Microsoft.AnalysisServices/preview/2017-08-01-beta/analysisservices.json#L1210:9 Old: Microsoft.AnalysisServices/preview/2017-08-01-beta/analysisservices.json#L1205:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) '0' from the old version. New: Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json#L1095:9 Old: Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json#L1095:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) '0' from the old version. New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1210:9 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1191:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AnalysisServices/preview/2017-08-01-beta/analysisservices.json#L1210:9 Old: Microsoft.AnalysisServices/preview/2017-08-01-beta/analysisservices.json#L1205:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json#L1095:9 Old: Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json#L1095:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1210:9 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1191:9
`❌` 1026 - TypeChanged	The new version has a different type 'integer' than the previous one 'string'. New: Microsoft.AnalysisServices/preview/2017-08-01-beta/analysisservices.json#L1210:9 Old: Microsoft.AnalysisServices/preview/2017-08-01-beta/analysisservices.json#L1205:9
`❌` 1026 - TypeChanged	The new version has a different type 'integer' than the previous one 'string'. New: Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json#L1095:9 Old: Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json#L1095:9
`❌` 1026 - TypeChanged	The new version has a different type 'integer' than the previous one 'string'. New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1210:9 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1191:9
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'subCode' in response that was not found in the old version. New: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1108:11 Old: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1108:11

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-06T23:06:45Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 83994cf. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/analysisservices/resource-manager/readme.md

️✔️analysisservices [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 83994cf. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️analysisservices/mgmt/2017-08-01/analysisservices [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ## Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `GatewayListStatusLive.Status` has been changed from `Status` to `*int32`
info	[Changelog] - Const `Live` has been removed
info	[Changelog] - Function `PossibleStatusValues` has been removed
info	[Changelog] - Field `Message` of struct `ErrorResponse` has been removed
info	[Changelog] - Field `Code` of struct `ErrorResponse` has been removed
info	[Changelog]
info	[Changelog] ## New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorResponseError`
info	[Changelog] - New field `ManagedMode` in struct `ServerMutableProperties`
info	[Changelog] - New field `ServerMonitorMode` in struct `ServerMutableProperties`
info	[Changelog] - New field `Origin` in struct `Operation`
info	[Changelog] - New field `Error` in struct `ErrorResponse`
info	[Changelog] - New field `Description` in struct `OperationDisplay`
info	[Changelog] - New field `SubCode` in struct `GatewayError`
info	[Changelog] - New field `HTTPStatusCode` in struct `GatewayError`
info	[Changelog] - New field `Sku` in struct `ServerProperties`
info	[Changelog] - New field `ManagedMode` in struct `ServerProperties`
info	[Changelog] - New field `ServerMonitorMode` in struct `ServerProperties`
info	[Changelog] - New field `ResourceType` in struct `SkuDetailsForExistingResource`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 9 additive change(s).
info	[Changelog]

️✔️analysisservices/mgmt/2017-07-14/analysisservices [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 40 items here, please refer to log for details.

info	[Changelog]
info	[Changelog] - New function `NewOperationListResultPage(OperationListResult, func(context.Context, OperationListResult) (OperationListResult, error)) OperationListResultPage`
info	[Changelog] - New function `OperationsClient.ListResponder(*http.Response) (OperationListResult, error)`
info	[Changelog] - New function `*OperationListResultIterator.NextWithContext(context.Context) error`
info	[Changelog] - New function `*OperationListResultIterator.Next() error`
info	[Changelog] - New function `*OperationListResultPage.Next() error`
info	[Changelog] - New function `OperationListResultIterator.Response() OperationListResult`
info	[Changelog] - New function `OperationDetail.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `OperationListResultPage.NotDone() bool`
info	[Changelog] - New function `OperationsClient.ListComplete(context.Context) (OperationListResultIterator, error)`
info	[Changelog] - New function `OperationDisplay.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `OperationListResultPage.Values() []OperationDetail`
info	[Changelog] - New function `NewOperationsClientWithBaseURI(string, string) OperationsClient`
info	[Changelog] - New function `OperationListResultPage.Response() OperationListResult`
info	[Changelog] - New function `OperationsClient.ListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `OperationsClient.List(context.Context) (OperationListResultPage, error)`
info	[Changelog] - New function `OperationListResultIterator.NotDone() bool`
info	[Changelog] - New function `NewOperationsClient(string) OperationsClient`
info	[Changelog] - New function `OperationsClient.ListPreparer(context.Context) (*http.Request, error)`
info	[Changelog] - New function `NewOperationListResultIterator(OperationListResultPage) OperationListResultIterator`
info	[Changelog] - New function `OperationListResult.IsEmpty() bool`
info	[Changelog] - New function `OperationListResultIterator.Value() OperationDetail`
info	[Changelog] - New function `*OperationListResultPage.NextWithContext(context.Context) error`
info	[Changelog] - New struct `ErrorResponseError`
info	[Changelog] - New struct `OperationDetail`
info	[Changelog] - New struct `OperationDisplay`
info	[Changelog] - New struct `OperationListResult`
info	[Changelog] - New struct `OperationListResultIterator`
info	[Changelog] - New struct `OperationListResultPage`
info	[Changelog] - New struct `OperationsClient`
info	[Changelog] - New struct `OperationsErrorResponse`
info	[Changelog] - New field `ManagedMode` in struct `ServerMutableProperties`
info	[Changelog] - New field `ServerMonitorMode` in struct `ServerMutableProperties`
info	[Changelog] - New field `ManagedMode` in struct `ServerProperties`
info	[Changelog] - New field `ServerMonitorMode` in struct `ServerProperties`
info	[Changelog] - New field `Error` in struct `ErrorResponse`
info	[Changelog] - New field `ResourceType` in struct `SkuDetailsForExistingResource`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 42 additive change(s).
info	[Changelog]

️✔️analysisservices/mgmt/2016-05-16/analysisservices [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 40 items here, please refer to log for details.

info	[Changelog] - New function `NewOperationsClientWithBaseURI(string, string) OperationsClient`
info	[Changelog] - New function `OperationListResultPage.NotDone() bool`
info	[Changelog] - New function `*OperationListResultIterator.NextWithContext(context.Context) error`
info	[Changelog] - New function `OperationsClient.ListResponder(*http.Response) (OperationListResult, error)`
info	[Changelog] - New function `OperationsClient.ListComplete(context.Context) (OperationListResultIterator, error)`
info	[Changelog] - New function `OperationListResultPage.Response() OperationListResult`
info	[Changelog] - New function `OperationListResultPage.Values() []OperationDetail`
info	[Changelog] - New function `*OperationListResultPage.Next() error`
info	[Changelog] - New function `NewOperationListResultIterator(OperationListResultPage) OperationListResultIterator`
info	[Changelog] - New function `*OperationListResultPage.NextWithContext(context.Context) error`
info	[Changelog] - New function `OperationsClient.ListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `NewOperationsClient(string) OperationsClient`
info	[Changelog] - New function `*OperationListResultIterator.Next() error`
info	[Changelog] - New function `OperationListResultIterator.Response() OperationListResult`
info	[Changelog] - New function `OperationListResult.IsEmpty() bool`
info	[Changelog] - New function `OperationDisplay.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `OperationDetail.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `OperationListResultIterator.NotDone() bool`
info	[Changelog] - New function `OperationsClient.List(context.Context) (OperationListResultPage, error)`
info	[Changelog] - New function `NewOperationListResultPage(OperationListResult, func(context.Context, OperationListResult) (OperationListResult, error)) OperationListResultPage`
info	[Changelog] - New function `OperationListResultIterator.Value() OperationDetail`
info	[Changelog] - New function `OperationsClient.ListPreparer(context.Context) (*http.Request, error)`
info	[Changelog] - New struct `ErrorResponseError`
info	[Changelog] - New struct `OperationDetail`
info	[Changelog] - New struct `OperationDisplay`
info	[Changelog] - New struct `OperationListResult`
info	[Changelog] - New struct `OperationListResultIterator`
info	[Changelog] - New struct `OperationListResultPage`
info	[Changelog] - New struct `OperationsClient`
info	[Changelog] - New struct `OperationsErrorResponse`
info	[Changelog] - New field `ManagedMode` in struct `ServerMutableProperties`
info	[Changelog] - New field `ServerMonitorMode` in struct `ServerMutableProperties`
info	[Changelog] - New field `ResourceType` in struct `SkuDetailsForExistingResource`
info	[Changelog] - New field `Error` in struct `ErrorResponse`
info	[Changelog] - New field `Capacity` in struct `ResourceSku`
info	[Changelog] - New field `ManagedMode` in struct `ServerProperties`
info	[Changelog] - New field `ServerMonitorMode` in struct `ServerProperties`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 43 additive change(s).
info	[Changelog]

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 83994cf. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/analysisservices/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.AnalysisServices [View full logs] [Release SDK Changes]

cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(386,40): error CS0029: Cannot implicitly convert type 'string' to 'bool?' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(456,66): error CS0029: Cannot implicitly convert type 'string' to 'bool?' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(555,30): error CS0103: The name 'Status' does not exist in the current context [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/InMemoryTests/ServersTests.InMemory.cs(568,42): error CS1061: 'ErrorResponse' does not contain a definition for 'Code' and no accessible extension method 'Code' accepting a first argument of type 'ErrorResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/InMemoryTests/ServersTests.InMemory.cs(569,42): error CS1061: 'ErrorResponse' does not contain a definition for 'Message' and no accessible extension method 'Message' accepting a first argument of type 'ErrorResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(386,40): error CS0029: Cannot implicitly convert type 'string' to 'bool?' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(456,66): error CS0029: Cannot implicitly convert type 'string' to 'bool?' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(555,30): error CS0103: The name 'Status' does not exist in the current context [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/InMemoryTests/ServersTests.InMemory.cs(568,42): error CS1061: 'ErrorResponse' does not contain a definition for 'Code' and no accessible extension method 'Code' accepting a first argument of type 'ErrorResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/InMemoryTests/ServersTests.InMemory.cs(569,42): error CS1061: 'ErrorResponse' does not contain a definition for 'Message' and no accessible extension method 'Message' accepting a first argument of type 'ErrorResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 83994cf. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/analysisservices/resource-manager/readme.md

️✔️@azure/arm-analysisservices [View full logs] [Release SDK Changes]

azure-arm-analysisservices-2.3.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/analysisServicesManagementClient.js → ./dist/arm-analysisservices.js...
cmderr	[npmPack] created ./dist/arm-analysisservices.js in 277ms

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-06T23:32:49Z

Hi @david-msft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

mikhailshilkov · 2021-01-11T09:10:58Z

Could you share the reason for these breaking changes?

david-msft · 2021-01-11T17:05:00Z

Could you share the reason for these breaking changes?

Hi Mikhail,
The spec has some mismatch and missing property as compared to our live traffic response validation. As reviewed and discussed from our side, we added the missing properties back and fix the mismatch in the spec as the fix so that it can pass our live traffic validation. It wasn't really a "breaking change" since it is required to fix the issue. Thanks

Create to sync Azure/azure-rest-api-specs#12306 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/analysisservices?expand=1)

david-msft and others added 4 commits December 28, 2020 11:15

Merge pull request #1 from Azure/master

a5c1e62

Merge Master

Merge pull request #2 from Azure/master

4871a17

Merge Master

add missing property and fix status type

5486a87

fxi nit

ce2374d

david-msft changed the title ~~[Hub Generated] Review request for Microsoft.AnalysisServices to add version preview/2017-08-01-beta, stable/2017-07-14 and stable/2017-08-01~~ AAS - Fix Swagger Correctness Issue Jan 6, 2021

add missing property

c78a0ce

This was referenced Jan 6, 2021

[AutoPR @azure/arm-analysisservices] AAS - Fix Swagger Correctness Issue AzureSDKAutomation/azure-sdk-for-js#3144

Closed

[AutoPR analysisservices] AAS - Fix Swagger Correctness Issue AzureSDKAutomation/azure-resource-manager-schemas#1283

Closed

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jan 6, 2021

fix prettier

8766d97

openapi-sdkautomation bot mentioned this pull request Jan 6, 2021

[AutoPR Microsoft.Azure.Management.AnalysisServices] AAS - Fix Swagger Correctness Issue AzureSDKAutomation/azure-sdk-for-net#2801

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jan 6, 2021

david-msft added 2 commits January 6, 2021 15:43

no message

9cbb1de

fix nit

6882941

david-msft marked this pull request as ready for review January 7, 2021 18:51

openapi-assignment-bot bot assigned njuCZ Jan 7, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 7, 2021

JeffreyRichter approved these changes Jan 7, 2021

View reviewed changes

njuCZ approved these changes Jan 8, 2021

View reviewed changes

njuCZ merged commit 83994cf into Azure:master Jan 8, 2021

mikhailshilkov mentioned this pull request Jan 11, 2021

Breaking changes in API pulumi/pulumi-azure-native#127

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AAS - Fix Swagger Correctness Issue #12306

AAS - Fix Swagger Correctness Issue #12306

david-msft commented Jan 6, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 6, 2021

openapi-pipeline-app bot commented Jan 6, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 6, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 6, 2021

mikhailshilkov commented Jan 11, 2021

david-msft commented Jan 11, 2021 •

edited

Loading

AAS - Fix Swagger Correctness Issue #12306

AAS - Fix Swagger Correctness Issue #12306

Conversation

david-msft commented Jan 6, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 6, 2021

openapi-pipeline-app bot commented Jan 6, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 6, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 6, 2021

mikhailshilkov commented Jan 11, 2021

david-msft commented Jan 11, 2021 • edited Loading

david-msft commented Jan 6, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 6, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 6, 2021 •

edited

Loading

david-msft commented Jan 11, 2021 •

edited

Loading