Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Swagger KPIs and RP request response payloads #12391

Merged
merged 20 commits into from
Jan 31, 2021
Merged

Fixing Swagger KPIs and RP request response payloads #12391

merged 20 commits into from
Jan 31, 2021

Conversation

harshitha-akkaraju
Copy link
Contributor

@harshitha-akkaraju harshitha-akkaraju commented Jan 12, 2021 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify: addressing feedback from Tooling teams for better customer experience.
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @harshitha-akkaraju Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 12, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @harshitha-akkaraju your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 12, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 49 Errors, 0 Warnings failed [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Sku' removed or renamed?
    New: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L701:3
    Old: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L622:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'DiskPool' removed or renamed?
    New: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L597:3
    Old: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L538:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'IscsiTarget' removed or renamed?
    New: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L597:3
    Old: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L538:3
    ❌ 1009 - RemovedRequiredParameter The required parameter 'diskPoolPayload' was removed in the new version.
    Old: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L174:9
    ❌ 1009 - RemovedRequiredParameter The required parameter 'diskPoolPayload' was removed in the new version.
    Old: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L224:9
    ❌ 1009 - RemovedRequiredParameter The required parameter 'iscsiTargetPayload' was removed in the new version.
    Old: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L399:9
    ❌ 1010 - AddingRequiredParameter The required parameter 'diskPoolCreatePayload' was added in the new version.
    New: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L174:9
    ❌ 1010 - AddingRequiredParameter The required parameter 'diskPoolUpdatePayload' was added in the new version.
    New: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L224:9
    ❌ 1010 - AddingRequiredParameter The required parameter 'iscsiTargetCreatePayload' was added in the new version.
    New: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L405:9
    ❌ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L248:11
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 12, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c7358a0. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-storage [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group DiskPoolsOperations
info	[Changelog]   - Added operation group IscsiTargetsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model ErrorResponse has a new signature
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c7358a0. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-31 04:32:16 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-storagepool"
cmderr	[generate.py] 2021-01-31 04:32:16 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-31 04:32:16 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/storagepool/azure-resourcemanager-storagepool --java.namespace=com.azure.resourcemanager.storagepool   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/storagepool/resource-manager/readme.md
cmderr	[generate.py] 2021-01-31 04:33:01 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-31 04:33:01 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-31 04:33:01 INFO [POM][Skip] pom already has module azure-resourcemanager-storagepool
cmderr	[generate.py] 2021-01-31 04:33:01 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-31 04:33:01 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-31 04:33:01 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-storagepool [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-01-31 04:36:29 DEBUG Got artifact_id: azure-resourcemanager-storagepool
cmderr	[Inst] 2021-01-31 04:36:29 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-31 04:36:29 DEBUG Got artifact: azure-resourcemanager-storagepool-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-01-31 04:36:29 DEBUG Got artifact: azure-resourcemanager-storagepool-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-01-31 04:36:29 DEBUG Got artifact: azure-resourcemanager-storagepool-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-31 04:36:29 DEBUG Match jar package: azure-resourcemanager-storagepool-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-31 04:36:29 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12391/azure-sdk-for-java/azure-resourcemanager-storagepool/azure-resourcemanager-storagepool-1.0.0-beta.1.jar\" -o azure-resourcemanager-storagepool-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-storagepool -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-storagepool-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c7358a0. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/storagepool/mgmt/2020-03-15-preview/storagepool [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Const `Standard` type has been changed from `SkuTier` to `DiskPoolTier`
info	[Changelog] - Const `Premium` type has been changed from `SkuTier` to `DiskPoolTier`
info	[Changelog] - Const `Basic` type has been changed from `SkuTier` to `DiskPoolTier`
info	[Changelog] - Function `IscsiTargetsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, IscsiTarget)` to `(context.Context, string, string, string, IscsiTargetCreate)`
info	[Changelog] - Function `IscsiTargetsClient.CreateOrUpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, string, IscsiTarget)` to `(context.Context, string, string, string, IscsiTargetCreate)`
info	[Changelog] - Function `DiskPoolsClient.Update` parameter(s) have been changed from `(context.Context, string, string, DiskPool)` to `(context.Context, string, string, DiskPoolUpdate)`
info	[Changelog] - Function `DiskPoolsClient.Update` return value(s) have been changed from `(DiskPool, error)` to `(DiskPoolsUpdateFuture, error)`
info	[Changelog] - Function `DiskPoolsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, DiskPool)` to `(context.Context, string, string, DiskPoolCreate)`
info	[Changelog] - Function `DiskPoolsClient.UpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, DiskPool)` to `(context.Context, string, string, DiskPoolUpdate)`
info	[Changelog] - Function `DiskPoolsClient.UpdateSender` return value(s) have been changed from `(*http.Response, error)` to `(DiskPoolsUpdateFuture, error)`
info	[Changelog] - Function `DiskPoolsClient.CreateOrUpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, DiskPool)` to `(context.Context, string, string, DiskPoolCreate)`
info	[Changelog] - Const `Free` has been removed
info	[Changelog] - Function `IscsiTargetProperties.MarshalJSON` has been removed
info	[Changelog] - Function `TargetPortalGroup.MarshalJSON` has been removed
info	[Changelog] - Function `DiskPoolProperties.MarshalJSON` has been removed
info	[Changelog] - Function `PossibleSkuTierValues` has been removed
info	[Changelog] - Struct `Sku` has been removed
info	[Changelog] - Field `Sku` of struct `DiskPool` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Running`
info	[Changelog] - New const `Updating`
info	[Changelog] - New const `Stopped`
info	[Changelog] - New const `Stoppeddeallocated`
info	[Changelog] - New function `*DiskPoolCreate.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `IscsiTargetsClient.Update(context.Context, string, string, string, IscsiTargetUpdate) (IscsiTargetsUpdateFuture, error)`
info	[Changelog] - New function `IscsiTargetsClient.UpdateResponder(*http.Response) (IscsiTarget, error)`
info	[Changelog] - New function `IscsiTargetsClient.UpdateSender(*http.Request) (IscsiTargetsUpdateFuture, error)`
info	[Changelog] - New function `*IscsiTargetCreate.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `IscsiTargetCreate.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `IscsiTargetUpdate.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*IscsiTargetUpdate.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `DiskPoolUpdate.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `IscsiTargetsClient.UpdatePreparer(context.Context, string, string, string, IscsiTargetUpdate) (*http.Request, error)`
info	[Changelog] - New function `DiskPoolCreate.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*DiskPoolUpdate.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `PossibleDiskPoolTierValues() []DiskPoolTier`
info	[Changelog] - New struct `DiskPoolCreate`
info	[Changelog] - New struct `DiskPoolCreateProperties`
info	[Changelog] - New struct `DiskPoolUpdate`
info	[Changelog] - New struct `DiskPoolUpdateProperties`
info	[Changelog] - New struct `DiskPoolsUpdateFuture`
info	[Changelog] - New struct `IscsiTargetCreate`
info	[Changelog] - New struct `IscsiTargetCreateProperties`
info	[Changelog] - New struct `IscsiTargetUpdate`
info	[Changelog] - New struct `IscsiTargetUpdateProperties`
info	[Changelog] - New struct `IscsiTargetsUpdateFuture`
info	[Changelog] - New struct `TargetPortalGroupCreate`
info	[Changelog] - New struct `TargetPortalGroupUpdate`
info	[Changelog] - New field `AdditionalCapabilities` in struct `DiskPoolProperties`
info	[Changelog] - New field `Tier` in struct `DiskPoolProperties`
info	[Changelog]
info	[Changelog] Total 18 breaking change(s), 42 additive change(s).
info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c7358a0. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/storagepool/resource-manager/readme.md
    • ️✔️@azure/arm-storagepool [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/storagePoolManagement.js → ./dist/arm-storagepool.js...
cmderr	[npmPack] created ./dist/arm-storagepool.js in 279ms
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @harshitha-akkaraju, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    @openapi-workflow-bot
    Copy link

    Hi @harshitha-akkaraju, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 12, 2021
    Closed
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 12, 2021
    Closed
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 12, 2021
    Closed
    This was referenced Jan 12, 2021
    Draft
    Draft
    Draft
    Draft
    Harshitha Akkaraju added 2 commits January 26, 2021 14:57
    @pilor pilor self-requested a review January 28, 2021 22:21
    @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 29, 2021
    pilor
    pilor approved these changes Jan 29, 2021
    View reviewed changes
    Copy link
    Contributor

    @pilor pilor left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Approving with breaking changes due to the s360 flag on the PR

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 29, 2021
    @chunyu3 chunyu3 merged commit c7358a0 into master Jan 31, 2021
    This was referenced Jan 31, 2021
    Closed
    Closed
    Closed
    Closed
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @harshitha-akkaraju @mkarmark
    Fixing Swagger KPIs and RP request response payloads (Azure#12391)
    5fa8568 
    * Swagger changes

* Updates

* Feedback

* Fixed validation errors

* Fixes

* Refactoring + fixes

* Make acls and luns optional for TargetPortalGroupUpdate

* Fixes

* Fixed cred scan

* Prettier check

* Model + linter validation

* Fixes'

* Prettier fix

* updates

* preview changeds

* Contract updates

* Addressing feedback

* Fixes

* FMting

* fixing model validation errors

Co-authored-by: Harshitha Akkaraju <hakkaraj@microsoft.com>
    @JackTn JackTn deleted the hakkaraj/storagepool branch August 9, 2021 10:12
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jorgecotillo jorgecotillo jorgecotillo left review comments

    @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

    @heaths heaths heaths approved these changes

    @pilor pilor pilor approved these changes

    @jlichwa jlichwa Awaiting requested review from jlichwa

    @RandalliLama RandalliLama Awaiting requested review from RandalliLama

    @j5lim j5lim Awaiting requested review from j5lim

    Assignees

    @jorgecotillo jorgecotillo

    @chunyu3 chunyu3

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Python FixS360
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @harshitha-akkaraju @j5lim @heaths @pilor @JeffreyRichter @jorgecotillo @chunyu3