-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Public private branch 'task/add_confidential-ledger_api_specs' #12417
[Hub Generated] Public private branch 'task/add_confidential-ledger_api_specs' #12417
Conversation
Swagger Generation Artifacts
|
according to discussion offline, this version will be changed to date-preview format as public preview. @ArcturusZhang |
Hi, @syhamza your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ArcturusZhang |
Hi @syhamza, Your PR has some issues. Please fix the CI sequentially by following the order of
|
...rosoft.ConfidentialLedger/preview/2020-12-01-preview/examples/ConfidentialLedger_Delete.json
Outdated
Show resolved
Hide resolved
…pi_specs' (Azure#12417) * Add Confidential Ledger API specs * fixing swagger validations * fixing model validation * fixing swagger model validation * fixing model validation * fixing model validation * adding examples * fixing readme.md * fixing readme references * fixing reference issue in readme * fixing file issue * file rename * fixing linter issues * minor changes * adding SystemData * adding systemData * minor changes * trying to fix model validation issue * Fixing Model Validation * fixing readme.md * fixing sdk generation * fixing readme.md and go files * minor changes * trying to fix go sdk * fixing url escaping * fixing go sdk generation * addressing comments to use common type definition * minor example fixes * updating python sdk output folder path * fixing output folder for python * fix python sdk output folder * updating the release name * minor changes * Revert "minor changes" This reverts commit 8ec2a9a. * Revert "updating the release name" This reverts commit 3fbbec1. * updating python package version * updating api version * naming directory * fixing minor issue * add go multi-api support
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.