Dev kubernetesconfiguration microsoft.kubernetes configuration stable 2021 03 01 #12500

NarayanThiru · 2021-01-19T20:01:43Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
During Ignite conference - around 02 March, 2021.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
As soon as the Swagger is merged, this week, if possible.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
Since this is a new api-version, we need SDKs generated
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
  - Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

… preview/2020-10-01-preview to version 2021-03-01

openapi-workflow-bot · 2021-01-19T20:01:45Z

Hi, @NarayanThiru Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-19T20:01:47Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- kubernetesconfiguration/resource-manager/readme.md tag:package-2021-03
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- kubernetesconfiguration/resource-manager/readme.md tag:default

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 5 Warnings warning [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2020-10-01-preview/kubernetesconfiguration.json <---> new: stable/2021-03-01/kubernetesconfiguration.json

Rule	Message
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'SystemData' removed or renamed? New: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L290:3 Old: Microsoft.KubernetesConfiguration/preview/2020-10-01-preview/kubernetesconfiguration.json#L290:3
⚠️ 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: common-types/resource-management/v2/types.json#L9:5 Old: Microsoft.KubernetesConfiguration/preview/2020-10-01-preview/kubernetesconfiguration.json#L329:5
⚠️ 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: common-types/resource-management/v2/types.json#L82:5 Old: Microsoft.KubernetesConfiguration/preview/2020-10-01-preview/kubernetesconfiguration.json#L355:5
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'systemData' renamed or removed? New: common-types/resource-management/v2/types.json#L12:7 Old: Microsoft.KubernetesConfiguration/preview/2020-10-01-preview/kubernetesconfiguration.json#L332:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'systemData' renamed or removed? Old: Microsoft.KubernetesConfiguration/preview/2020-10-01-preview/kubernetesconfiguration.json#L363:7

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-19T20:01:47Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from cb4659b. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md

️✔️@azure/arm-kubernetesconfiguration [View full logs] [Release SDK Changes]

azure-arm-kubernetesconfiguration-2.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/sourceControlConfigurationClient.js → ./dist/arm-kubernetesconfiguration.js...
cmderr	[npmPack] created ./dist/arm-kubernetesconfiguration.js in 207ms

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from cb4659b. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md

️✔️kubernetesconfiguration [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from cb4659b. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-27 05:32:18 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-kubernetesconfiguration"
cmderr	[generate.py] 2021-01-27 05:32:18 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-27 05:32:18 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/kubernetesconfiguration/azure-resourcemanager-kubernetesconfiguration --java.namespace=com.azure.resourcemanager.kubernetesconfiguration   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md
cmderr	[generate.py] 2021-01-27 05:32:53 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-27 05:32:53 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-27 05:32:53 INFO [POM][Skip] pom already has module azure-resourcemanager-kubernetesconfiguration
cmderr	[generate.py] 2021-01-27 05:32:53 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-27 05:32:53 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-27 05:32:53 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2021-01-27 05:34:00 ERROR [COMPILE] Maven build fail

️✔️azure-resourcemanager-kubernetesconfiguration [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-27 05:34:51 DEBUG Got artifact_id: azure-resourcemanager-kubernetesconfiguration
cmderr	[Inst] 2021-01-27 05:34:51 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-27 05:34:51 DEBUG Got artifact: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-01-27 05:34:51 DEBUG Got artifact: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-01-27 05:34:51 DEBUG Got artifact: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-27 05:34:51 DEBUG Match jar package: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-27 05:34:51 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12500/azure-sdk-for-java/azure-resourcemanager-kubernetesconfiguration/azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar\" -o azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-kubernetesconfiguration -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from cb4659b. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/kubernetesconfiguration/mgmt/2019-11-01-preview/kubernetesconfiguration [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from cb4659b. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-kubernetesconfiguration [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model SourceControlConfiguration has a new parameter configuration_protected_settings
info	[Changelog]   - Model SourceControlConfiguration has a new parameter ssh_known_hosts_contents
info	[Changelog]   - Model SourceControlConfiguration has a new parameter system_data
info	[Changelog]   - Model ResourceProviderOperation has a new parameter is_data_action
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model ErrorDefinition has a new signature

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-19T20:01:48Z

Hi, @NarayanThiru your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @

NarayanThiru · 2021-01-20T01:23:32Z

@jianyexi, this PR is to create a new api-version for our upcoming GA release. Compared to our most recent Public Preview api-version 2020-10-01-preview, there are no changes - except a Swagger Linting fix. Please help us get this merged at the earliest possible.

jianyexi · 2021-01-20T01:47:59Z

@jianyexi Jianye Xi FTE, this PR is to create a new api-version for our upcoming GA release. Compared to our most recent Public Preview api-version 2020-10-01-preview, there are no changes - except a Swagger Linting fix. Please help us get this merged at the earliest possible.

Ok, needs ARM review first.

NarayanThiru · 2021-01-21T01:56:30Z

@jianyexi, ARM team has signed off. Can you please help get this merged?

...rce-manager/Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json

openapi-workflow-bot · 2021-01-27T03:45:21Z

Hi @NarayanThiru, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

… 2021 03 01 (Azure#12500) * Adds base for updating Microsoft.KubernetesConfiguration from version preview/2020-10-01-preview to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Fixed review comment * Fixed reference path error * Fixed casing error in enum

NarayanThiru added 3 commits January 19, 2021 11:04

Adds base for updating Microsoft.KubernetesConfiguration from version…

743541c

… preview/2020-10-01-preview to version 2021-03-01

Updates readme

bea049e

Updates API version in new specs and examples

075193c

NarayanThiru requested a review from lirenhe as a code owner January 19, 2021 20:01

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 19, 2021

openapi-assignment-bot bot assigned jianyexi Jan 19, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python label Jan 19, 2021

openapi-sdkautomation bot mentioned this pull request Jan 19, 2021

[AutoPR azure-resourcemanager-kubernetesconfiguration] Dev kubernetesconfiguration microsoft.kubernetes configuration stable 2021 03 01 AzureSDKAutomation/azure-sdk-for-java#7213

Closed

RamyasreeChakka added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 21, 2021

jianyexi approved these changes Jan 27, 2021

View reviewed changes

jianyexi reviewed Jan 27, 2021

View reviewed changes

...rce-manager/Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json Outdated Show resolved Hide resolved

Fixed review comment

33bab4c

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 27, 2021

openapi-pipeline-app bot removed the CI-BreakingChange-Python label Jan 27, 2021

Fixed reference path error

41bc913

openapi-pipeline-app bot added CI-BreakingChange-Python and removed CI-FixRequiredOnFailure labels Jan 27, 2021

Fixed casing error in enum

dc50ec6

jianyexi merged commit cb4659b into Azure:master Jan 27, 2021

jonathan-innis mentioned this pull request Feb 11, 2021

Update KubernetesConfiguration for api version 2021-03-01 Azure/azure-sdk-for-net#18707

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev kubernetesconfiguration microsoft.kubernetes configuration stable 2021 03 01 #12500

Dev kubernetesconfiguration microsoft.kubernetes configuration stable 2021 03 01 #12500

NarayanThiru commented Jan 19, 2021

openapi-workflow-bot bot commented Jan 19, 2021

openapi-pipeline-app bot commented Jan 19, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 19, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 19, 2021

NarayanThiru commented Jan 20, 2021

jianyexi commented Jan 20, 2021

NarayanThiru commented Jan 21, 2021

openapi-workflow-bot bot commented Jan 27, 2021

Dev kubernetesconfiguration microsoft.kubernetes configuration stable 2021 03 01 #12500

Dev kubernetesconfiguration microsoft.kubernetes configuration stable 2021 03 01 #12500

Conversation

NarayanThiru commented Jan 19, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 19, 2021

openapi-pipeline-app bot commented Jan 19, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 19, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 19, 2021

NarayanThiru commented Jan 20, 2021

jianyexi commented Jan 20, 2021

NarayanThiru commented Jan 21, 2021

openapi-workflow-bot bot commented Jan 27, 2021

openapi-pipeline-app bot commented Jan 19, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 19, 2021 •

edited

Loading