Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Cdn to add version stable/2020-09-01 #12533

Merged
merged 1 commit into from
Jan 22, 2021
Merged

[Hub Generated] Review request for Microsoft.Cdn to add version stable/2020-09-01 #12533

merged 1 commit into from
Jan 22, 2021

Conversation

ChenglongLiu
Copy link
Member

@ChenglongLiu ChenglongLiu commented Jan 21, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ChenglongLiu Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 21, 2021

    Swagger Validation Report

    ️❌BreakingChange: 5 Errors, 0 Warnings failed [Detail]

    Rule Message
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L463:9
    Old: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L463:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L573:9
    Old: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L571:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L580:9
    Old: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L577:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L531:9
    Old: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L530:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L531:9
    Old: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L530:9
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 21, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 12b41f4. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️cdn/mgmt/2020-09-01/cdn [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 14 items here, please refer to log for details.
      info	[Changelog] - Function `NewSecurityPoliciesClient` parameter(s) have been changed from `(string, string)` to `(string)`
      info	[Changelog] - Function `NewRuleSetsClientWithBaseURI` parameter(s) have been changed from `(string, string, string)` to `(string, string)`
      info	[Changelog] - Function `NewResourceUsageClient` parameter(s) have been changed from `(string, string)` to `(string)`
      info	[Changelog] - Function `NewEndpointsClientWithBaseURI` parameter(s) have been changed from `(string, string, string)` to `(string, string)`
      info	[Changelog] - Function `NewOperationsClientWithBaseURI` parameter(s) have been changed from `(string, string, string)` to `(string, string)`
      info	[Changelog] - Function `NewOriginsClient` parameter(s) have been changed from `(string, string)` to `(string)`
      info	[Changelog] - Function `NewValidateClientWithBaseURI` parameter(s) have been changed from `(string, string, string)` to `(string, string)`
      info	[Changelog] - Function `NewProfilesClientWithBaseURI` parameter(s) have been changed from `(string, string, string)` to `(string, string)`
      info	[Changelog] - Function `NewRoutesClientWithBaseURI` parameter(s) have been changed from `(string, string, string)` to `(string, string)`
      info	[Changelog] - Function `NewAFDCustomDomainsClientWithBaseURI` parameter(s) have been changed from `(string, string, string)` to `(string, string)`
      info	[Changelog] - Field `SubscriptionID1` of struct `BaseClient` has been removed
      info	[Changelog]
      info	[Changelog] Total 47 breaking change(s), 0 additive change(s).
      info	[Changelog]
    • ️✔️cdn/mgmt/2020-04-15/cdn [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️cdn/mgmt/2019-06-15/cdn [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️cdn/mgmt/2019-04-15/cdn [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️cdn/mgmt/2017-10-12/cdn [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️cdn/mgmt/2017-04-02/cdn [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️cdn/mgmt/2016-10-02/cdn [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️cdn/mgmt/2016-04-02/cdn [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️cdn/mgmt/2015-06-01/cdn [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 12b41f4. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-01-22 06:18:08 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-cdn-generated"
      cmderr	[generate.py] 2021-01-22 06:18:08 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-01-22 06:18:08 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/cdn/azure-resourcemanager-cdn-generated --java.namespace=com.azure.resourcemanager.cdn.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/cdn/resource-manager/readme.md
      cmderr	[generate.py] 2021-01-22 06:19:14 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-01-22 06:19:14 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-01-22 06:19:14 INFO [POM][Skip] pom already has module azure-resourcemanager-cdn-generated
      cmderr	[generate.py] 2021-01-22 06:19:14 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-01-22 06:19:14 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-01-22 06:19:14 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
      cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
      cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
      cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
      cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-cdn-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-01-22 06:23:09 DEBUG Got artifact_id: azure-resourcemanager-cdn-generated
      cmderr	[Inst] 2021-01-22 06:23:09 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-01-22 06:23:09 DEBUG Got artifact: azure-resourcemanager-cdn-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-01-22 06:23:09 DEBUG Got artifact: azure-resourcemanager-cdn-generated-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-01-22 06:23:09 DEBUG Got artifact: azure-resourcemanager-cdn-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-01-22 06:23:09 DEBUG Match jar package: azure-resourcemanager-cdn-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-01-22 06:23:09 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12533/azure-sdk-for-java/azure-resourcemanager-cdn-generated/azure-resourcemanager-cdn-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-cdn-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-cdn-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-cdn-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 12b41f4. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/cdn/resource-manager/readme.md
    • ️✔️azure-mgmt-cdn [View full logs]  [Release SDK Changes]
      cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-cdn
      cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-cdn
      cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
      cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
      cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
      cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.cdn
      cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.cdn
      cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.cdn
      cmderr	[changelogReport] INFO:__main__:Report written to sdk/cdn/azure-mgmt-cdn/code_reports/latest/report.json
      cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-cdn on PyPI
      cmderr	[changelogReportLatest] INFO:__main__:Got ['0.30.0a1', '0.30.0rc1', '0.30.0rc2', '0.30.0rc3', '0.30.0rc4', '0.30.0rc5', '0.30.0rc6', '0.30.0', '0.30.1', '0.30.2', '0.30.3', '1.0.0', '2.0.0', '3.0.0', '3.1.0', '4.0.0', '4.1.0rc1', '5.0.0', '5.1.0', '5.2.0', '6.0.0', '10.0.0b1']
      cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
      cmderr	[changelogReportLatest] INFO:__main__:Installing version 6.0.0 of azure-mgmt-cdn in a venv
      cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
      cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.cdn
      cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.cdn
      cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.cdn
      cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/cdn/azure-mgmt-cdn/code_reports/6.0.0/report.json
      cmdout	[Changelog] Size of delta 0.001% size of original (original: 139117 chars, delta: 2 chars)
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 12b41f4. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/cdn/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Cdn [View full logs]  [Release SDK Changes]
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 12b41f4. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/cdn/resource-manager/readme.md
    • cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager] npm WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 12b41f4. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/cdn/resource-manager/readme.md
    • ️✔️@azure/arm-cdn [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/cdnManagementClient.js → ./dist/arm-cdn.js...
      cmderr	[npmPack] created ./dist/arm-cdn.js in 991ms
    ️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=189334&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
    "detail":"Run.ps1 failed with exit code 1 "
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @ChenglongLiu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @ChenglongLiu
    Copy link
    Member Author

    @jianyexi Why add missed format for integer consider as breaking change?

    @jianyexi
    Copy link
    Contributor

    @jianyexi Jianye Xi FTE Why add missed format for integer consider as breaking change?

    This is API breaking change behavior , if the SDK did not report breaking change ,I think it can be approved by us

    @ChenglongLiu
    Copy link
    Member Author

    @jianyexi There are 9 checks queued for more than 4 hours, could you look at them?

    @ChenglongLiu
    Copy link
    Member Author

    Close and reopen to trigger the blocked checks

    @ChenglongLiu
    Copy link
    Member Author

    @jianyexi jianyexi added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 22, 2021
    @jianyexi
    Copy link
    Contributor

    Currently the default integer format is int32, so this breaking change has no impact

    This was referenced Jan 22, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    Co-authored-by: Chenglong Liu <chengll@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants