[Hub Generated] Review request for Microsoft.ImportExport to add version stable/2020-08-01 #12538

nivats · 2021-01-21T07:47:32Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-01-21T07:47:35Z

Hi, @nivats Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-21T07:47:36Z

Swagger Validation Report

️❌BreakingChange: 5 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-08-01/storageimportexport.json <---> new: stable/2020-08-01/storageimportexport.json

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.ImportExport/stable/2020-08-01/storageimportexport.json#L141:11 Old: Microsoft.ImportExport/stable/2020-08-01/storageimportexport.json#L141:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.ImportExport/stable/2020-08-01/storageimportexport.json#L697:9 Old: Microsoft.ImportExport/stable/2020-08-01/storageimportexport.json#L695:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.ImportExport/stable/2020-08-01/storageimportexport.json#L1205:9 Old: Microsoft.ImportExport/stable/2020-08-01/storageimportexport.json#L1193:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.ImportExport/stable/2020-08-01/storageimportexport.json#L201:11 Old: Microsoft.ImportExport/stable/2020-08-01/storageimportexport.json#L200:11
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'additionalShippingInformation' in response that was not found in the old version. New: Microsoft.ImportExport/stable/2020-08-01/storageimportexport.json#L943:11 Old: Microsoft.ImportExport/stable/2020-08-01/storageimportexport.json#L927:11

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- storageimportexport/resource-manager/readme.md tag:package-2020-08
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- storageimportexport/resource-manager/readme.md tag:package-2020-08

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-21T07:47:37Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2ad70cb. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/storageimportexport/resource-manager/readme.md

️✔️storageimportexport [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2ad70cb. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/storageimportexport/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse-error' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse-error-detailsItem' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PutJobParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'JobDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'UpdateJobParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'UpdateJobParameters-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ListJobsResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'JobResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Location' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Location-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ReturnAddress' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ReturnShipping' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ShippingInformation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PackageInfomation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DriveStatus' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Export' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Export-blobList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'LocationsResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'GetBitLockerKeysResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DriveBitLockerKey' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ListOperationsResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Jobs/put/Create job
cmderr	[Autorest]     - name: /Jobs/get/Get job
cmderr	[Autorest]     - name: /Jobs/get/List jobs in a resource group
cmderr	[Autorest]     - name: /Jobs/get/List jobs in a subscription
cmderr	[Autorest]     - name: /Jobs/patch/Update job
cmderr	[Autorest]     - name: /BitLockerKeys/post/List BitLocker Keys for drives in a job
cmderr	[Autorest]     - name: /Jobs/delete/Delete job
cmderr	[Autorest]     - name: /Locations/get/Get locations
cmderr	[Autorest]     - name: /Locations/get/List locations
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
cmderr	[Autorest] /bin/sh: 1: cd: can't cd to home/vsts/work/1/s/azure-rest-api-specs

️✔️storageimportexport [View full logs] [Release Azure CLI Changes]
- storageimportexport-0.1.0-py3-none-any.whl
- storageimportexport-0.1.0.zip

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2ad70cb. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/storageimportexport/resource-manager/readme.md

️✔️@azure/arm-storageimportexport [View full logs] [Release SDK Changes]

azure-arm-storageimportexport-1.2.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/storageImportExportManagementClient.js → ./dist/arm-storageimportexport.js...
cmderr	[npmPack] created ./dist/arm-storageimportexport.js in 259ms

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2ad70cb. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️storageimportexport/mgmt/2020-08-01/storageimportexport [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Const `CustomerManaged` type has been changed from `KekType` to `EncryptionKekType`
info	[Changelog] - Const `MicrosoftManaged` type has been changed from `KekType` to `EncryptionKekType`
info	[Changelog] - Const `SystemAssigned` type has been changed from `Type` to `IdentityType`
info	[Changelog] - Const `UserAssigned` type has been changed from `Type` to `IdentityType`
info	[Changelog] - Const `None` type has been changed from `Type` to `IdentityType`
info	[Changelog] - Type of `EncryptionKeyDetails.KekType` has been changed from `KekType` to `EncryptionKekType`
info	[Changelog] - Type of `IdentityDetails.Type` has been changed from `Type` to `IdentityType`
info	[Changelog] - Function `PossibleTypeValues` has been removed
info	[Changelog] - Function `PossibleKekTypeValues` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Application`
info	[Changelog] - New const `Key`
info	[Changelog] - New const `ManagedIdentity`
info	[Changelog] - New const `User`
info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
info	[Changelog] - New function `PossibleEncryptionKekTypeValues() []EncryptionKekType`
info	[Changelog] - New function `PossibleIdentityTypeValues() []IdentityType`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New field `AdditionalShippingInformation` in struct `LocationProperties`
info	[Changelog] - New field `SystemData` in struct `JobResponse`
info	[Changelog]
info	[Changelog] Total 9 breaking change(s), 11 additive change(s).
info	[Changelog]

️✔️storageimportexport/mgmt/2016-11-01/storageimportexport [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-21T07:50:43Z

Hi @nivats, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

akning-ms · 2021-01-26T08:24:05Z

@ArcturusZhang to confirm any impact to GO SDK breaking change

ArcturusZhang

Breaking changes in go SDK are expected since we are fixing some issues here

…ion stable/2020-08-01 (Azure#12538) * fix swagger * keeping integer type same as that of default

fix swagger

3dd2cb0

openapi-assignment-bot bot assigned ArcturusZhang Jan 21, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jan 21, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jan 21, 2021

keeping integer type same as that of default

4300bc2

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 25, 2021

JeffreyRichter approved these changes Jan 25, 2021

View reviewed changes

ArcturusZhang approved these changes Jan 26, 2021

View reviewed changes

ArcturusZhang merged commit 2ad70cb into Azure:master Jan 26, 2021

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

[Hub Generated] Review request for Microsoft.ImportExport to add vers…

a516306

…ion stable/2020-08-01 (Azure#12538) * fix swagger * keeping integer type same as that of default

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.ImportExport to add version stable/2020-08-01 #12538

[Hub Generated] Review request for Microsoft.ImportExport to add version stable/2020-08-01 #12538

nivats commented Jan 21, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 21, 2021

openapi-pipeline-app bot commented Jan 21, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 21, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 21, 2021

akning-ms commented Jan 26, 2021

ArcturusZhang left a comment

[Hub Generated] Review request for Microsoft.ImportExport to add version stable/2020-08-01 #12538

[Hub Generated] Review request for Microsoft.ImportExport to add version stable/2020-08-01 #12538

Conversation

nivats commented Jan 21, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 21, 2021

openapi-pipeline-app bot commented Jan 21, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 21, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 21, 2021

akning-ms commented Jan 26, 2021

ArcturusZhang left a comment

Choose a reason for hiding this comment

nivats commented Jan 21, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 21, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 21, 2021 •

edited

Loading