Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix readme Configuration Tags for ApplicationInsights #12589

Merged
merged 1 commit into from
Jan 25, 2021
Merged

fix readme Configuration Tags for ApplicationInsights #12589

merged 1 commit into from
Jan 25, 2021

Conversation

ctaggart
Copy link
Contributor

This just fixes parsing of the readme. A Tag must be directly below a Configuration, not Suppression.

@ctaggart ctaggart requested a review from lirenhe as a code owner January 25, 2021 01:04
@openapi-workflow-bot
Copy link

Hi, @ctaggart Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ce03e2f. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.ApplicationInsights [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ce03e2f. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
    • ️✔️azure-mgmt-applicationinsights [View full logs]  [Release SDK Changes] 
      cmderr	[multiapi_init_gen.py --default-api-version=2020-03-01-preview azure-mgmt-applicationinsights] INFO:__main__:Default API version will be: v2020_03_01_preview
cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-applicationinsights
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-applicationinsights
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2015_05_01
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.applicationinsights.v2015_05_01
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2017_10_01
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.applicationinsights.v2017_10_01
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2018_05_01_preview
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.applicationinsights.v2018_05_01_preview
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2018_06_17_preview
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.applicationinsights.v2018_06_17_preview
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2019_09_01_preview
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.applicationinsights.v2019_09_01_preview
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2019_10_17_preview
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.applicationinsights.v2019_10_17_preview
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2020_02_02_preview
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.applicationinsights.v2020_02_02_preview
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2020_03_01_preview
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.applicationinsights.v2020_03_01_preview
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.applicationinsights.v2015_05_01
cmderr	[changelogReport] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/latest/v2015_05_01.json
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.applicationinsights.v2017_10_01
cmderr	[changelogReport] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/latest/v2017_10_01.json
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.applicationinsights.v2018_05_01_preview
cmderr	[changelogReport] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/latest/v2018_05_01_preview.json
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.applicationinsights.v2018_06_17_preview
cmderr	[changelogReport] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/latest/v2018_06_17_preview.json
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.applicationinsights.v2019_09_01_preview
cmderr	[changelogReport] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/latest/v2019_09_01_preview.json
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.applicationinsights.v2019_10_17_preview
cmderr	[changelogReport] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/latest/v2019_10_17_preview.json
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.applicationinsights.v2020_02_02_preview
cmderr	[changelogReport] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/latest/v2020_02_02_preview.json
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.applicationinsights.v2020_03_01_preview
cmderr	[changelogReport] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/latest/v2020_03_01_preview.json
cmderr	[changelogReport] INFO:__main__:Merged report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/latest/merged_report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-applicationinsights on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.1.1', '0.2.0', '0.3.0', '1.0.0b1']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.3.0 of azure-mgmt-applicationinsights in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2015_05_01
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.applicationinsights.v2015_05_01
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2017_10_01
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.applicationinsights.v2017_10_01
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2018_05_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.applicationinsights.v2018_05_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2018_06_17_preview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.applicationinsights.v2018_06_17_preview
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2019_09_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.applicationinsights.v2019_09_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2019_10_17_preview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.applicationinsights.v2019_10_17_preview
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2020_02_02_preview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.applicationinsights.v2020_02_02_preview
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.applicationinsights.v2020_03_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.applicationinsights.v2020_03_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.applicationinsights.v2015_05_01
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/0.3.0/v2015_05_01.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.applicationinsights.v2017_10_01
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/0.3.0/v2017_10_01.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.applicationinsights.v2018_05_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/0.3.0/v2018_05_01_preview.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.applicationinsights.v2018_06_17_preview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/0.3.0/v2018_06_17_preview.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.applicationinsights.v2019_09_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/0.3.0/v2019_09_01_preview.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.applicationinsights.v2019_10_17_preview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/0.3.0/v2019_10_17_preview.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.applicationinsights.v2020_02_02_preview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/0.3.0/v2020_02_02_preview.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.applicationinsights.v2020_03_01_preview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/0.3.0/v2020_03_01_preview.json
cmderr	[changelogReportLatest] INFO:__main__:Merged report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/0.3.0/merged_report.json
cmdout	[Changelog] Size of delta 9.516% size of original (original: 76247 chars, delta: 7256 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model ApplicationInsightsComponent has a new parameter la_migration_date
cmdout	[Changelog]   - Model ApplicationInsightsComponent has a new parameter ingestion_mode
cmdout	[Changelog]   - Model Workbook has a new parameter source_id
cmdout	[Changelog]   - Added operation group MyWorkbooksOperations
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ce03e2f. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-25 01:44:57 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-applicationinsights"
cmderr	[generate.py] 2021-01-25 01:44:57 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-25 01:44:57 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/applicationinsights/azure-resourcemanager-applicationinsights --java.namespace=com.azure.resourcemanager.applicationinsights   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
cmderr	[generate.py] 2021-01-25 01:45:38 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-25 01:45:38 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-25 01:45:38 INFO [POM][Skip] pom already has module azure-resourcemanager-applicationinsights
cmderr	[generate.py] 2021-01-25 01:45:38 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-25 01:45:38 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-25 01:45:38 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-applicationinsights [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-01-25 01:48:23 DEBUG Got artifact_id: azure-resourcemanager-applicationinsights
cmderr	[Inst] 2021-01-25 01:48:23 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-25 01:48:23 DEBUG Got artifact: azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-25 01:48:23 DEBUG Match jar package: azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-25 01:48:23 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12589/azure-sdk-for-java/azure-resourcemanager-applicationinsights/azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar\" -o azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-applicationinsights -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ce03e2f. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️appinsights/mgmt/2015-05-01/insights [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ce03e2f. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
    • ️✔️@azure/arm-appinsights [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/applicationInsightsManagementClient.js → ./dist/arm-appinsights.js...
cmderr	[npmPack] created ./dist/arm-appinsights.js in 226ms
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ce03e2f. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
    • ️✔️applicationinsights [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Jan 25, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    @kairu-ms kairu-ms merged commit ce03e2f into Azure:master Jan 25, 2021
    This was referenced Jan 25, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @cataggar @mkarmark
    fix readme Configuration Tags for ApplicationInsights (Azure#12589)
    dd58451
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @kairu-ms kairu-ms kairu-ms approved these changes

    @lirenhe lirenhe Awaiting requested review from lirenhe

    Assignees

    @kairu-ms kairu-ms

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @ctaggart @kairu-ms @cataggar