[Fix S360 Broken Issues][HDInsight]Fix s360 issues batch3 #12612

aim-for-better · 2021-01-25T11:51:49Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

The changes are as bellow:

For cluster.json
- Add a new api: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HDInsight/clusters/{clusterName}/azureasyncoperations/{operationId}
- Add property VMGroupName in Role class,
- Add property saskey and fileshare in StorageAccount class
- Change the class OperationResource to AsyncOperationResult
For application.json
- Add a property privateIPAddress
For extension.json
- Change the response of get extension api
- change the description of ClusterMonitoringResponse
For locations.json
- Add a new api /subscriptions/{subscriptionId}/providers/Microsoft.HDInsight/locations/{location}/azureasyncoperations/{operationId}
- change the type of isDefault from string to boolean
- change vmSizes to vmsizes
- change vmSizes_filters to vmsizes_filters
- Change the properties currentValue, limit's type to int64

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-01-25T11:51:52Z

Hi, @aim-for-better Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-25T11:51:53Z

Swagger Validation Report

️❌BreakingChange: 13 Errors, 0 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2018-06-01-preview/applications.json <---> new: stable/2018-06-01-preview/applications.json
- original: stable/2018-06-01-preview/cluster.json <---> new: stable/2018-06-01-preview/cluster.json
- original: stable/2018-06-01-preview/extensions.json <---> new: stable/2018-06-01-preview/extensions.json
- original: stable/2018-06-01-preview/locations.json <---> new: stable/2018-06-01-preview/locations.json

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.HDInsight/stable/2018-06-01-preview/locations.json#L416:9 Old: Microsoft.HDInsight/stable/2018-06-01-preview/locations.json#L374:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.HDInsight/stable/2018-06-01-preview/locations.json#L421:9 Old: Microsoft.HDInsight/stable/2018-06-01-preview/locations.json#L379:9
`❌` 1026 - TypeChanged	The new version has a different type 'boolean' than the previous one 'string'. New: Microsoft.HDInsight/stable/2018-06-01-preview/locations.json#L209:9 Old: Microsoft.HDInsight/stable/2018-06-01-preview/locations.json#L167:9
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'primaryKey' renamed or removed? New: Microsoft.HDInsight/stable/2018-06-01-preview/extensions.json#L335:7 Old: Microsoft.HDInsight/stable/2018-06-01-preview/extensions.json#L322:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'vmSizes' renamed or removed? New: Microsoft.HDInsight/stable/2018-06-01-preview/locations.json#L352:7 Old: Microsoft.HDInsight/stable/2018-06-01-preview/locations.json#L310:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'vmSize_filters' renamed or removed? New: Microsoft.HDInsight/stable/2018-06-01-preview/locations.json#L352:7 Old: Microsoft.HDInsight/stable/2018-06-01-preview/locations.json#L310:7
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json#L623:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.HDInsight/stable/2018-06-01-preview/locations.json#L154:5
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'VMGroupName' in response that was not found in the old version. New: Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json#L963:7 Old: Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json#L918:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'privateIPAddress' in response that was not found in the old version. New: Microsoft.HDInsight/stable/2018-06-01-preview/applications.json#L235:7 Old: Microsoft.HDInsight/stable/2018-06-01-preview/applications.json#L235:7

️⚠️LintDiff: 3 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- hdinsight/resource-manager/readme.md tag:package-2018-06-preview
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- hdinsight/resource-manager/readme.md tag:package-2018-06-preview

Rule	Message
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'azureasyncoperations' with immediate parent 'Cluster', must have a list by immediate parent operation. New: Microsoft.HDInsight/stable/2018-06-01-preview/virtualMachines.json#L132
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDefault New: Microsoft.HDInsight/stable/2018-06-01-preview/locations.json#L209
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get the subscription billingSpecs for the specified location New: Microsoft.HDInsight/stable/2018-06-01-preview/locations.json#L161

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-25T11:51:54Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2b69bec. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️hdinsight/mgmt/2018-06-01/hdinsight [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ExtensionsClient.Get` return value(s) have been changed from `(Extension, error)` to `(ClusterMonitoringResponse, error)`
info	[Changelog] - Function `ExtensionsClient.GetResponder` return value(s) have been changed from `(Extension, error)` to `(ClusterMonitoringResponse, error)`
info	[Changelog] - Type of `VersionSpec.IsDefault` has been changed from `*string` to `*bool`
info	[Changelog] - Type of `Usage.Limit` has been changed from `*int32` to `*int64`
info	[Changelog] - Type of `Usage.CurrentValue` has been changed from `*int32` to `*int64`
info	[Changelog] - Struct `OperationResource` has been removed
info	[Changelog] - Field `autorest.Response` of struct `Extension` has been removed
info	[Changelog] - Field `VMSizes` of struct `CapabilitiesResult` has been removed
info	[Changelog] - Field `VMSizeFilters` of struct `CapabilitiesResult` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `LocationsClient.GetAzureAsyncOperationStatusSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `LocationsClient.GetAzureAsyncOperationStatusResponder(*http.Response) (AsyncOperationResult, error)`
info	[Changelog] - New function `LocationsClient.GetAzureAsyncOperationStatus(context.Context, string, string) (AsyncOperationResult, error)`
info	[Changelog] - New function `LocationsClient.GetAzureAsyncOperationStatusPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `ClustersClient.GetAzureAsyncOperationStatusSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ClustersClient.GetAzureAsyncOperationStatusResponder(*http.Response) (AsyncOperationResult, error)`
info	[Changelog] - New function `ClustersClient.GetAzureAsyncOperationStatus(context.Context, string, string, string) (AsyncOperationResult, error)`
info	[Changelog] - New function `ClustersClient.GetAzureAsyncOperationStatusPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New struct `AsyncOperationResult`
info	[Changelog] - New field `Saskey` in struct `StorageAccount`
info	[Changelog] - New field `Fileshare` in struct `StorageAccount`
info	[Changelog] - New field `PrivateIPAddress` in struct `ApplicationGetHTTPSEndpoint`
info	[Changelog] - New field `VMGroupName` in struct `Role`
info	[Changelog] - New field `Vmsizes` in struct `CapabilitiesResult`
info	[Changelog] - New field `VmsizeFilters` in struct `CapabilitiesResult`
info	[Changelog]
info	[Changelog] Total 8 breaking change(s), 14 additive change(s).
info	[Changelog]

️✔️preview/hdinsight/mgmt/2015-03-01-preview/hdinsight [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 2b69bec. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/hdinsight/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.HDInsight [View full logs] [Release SDK Changes]

cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/ScenarioTests/LocationOperationTests.cs(44,47): error CS1061: 'CapabilitiesResult' does not contain a definition for 'VmSizeFilters' and no accessible extension method 'VmSizeFilters' accepting a first argument of type 'CapabilitiesResult' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/Microsoft.Azure.Management.HDInsight.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/ScenarioTests/LocationOperationTests.cs(45,47): error CS1061: 'CapabilitiesResult' does not contain a definition for 'VmSizes' and no accessible extension method 'VmSizes' accepting a first argument of type 'CapabilitiesResult' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/Microsoft.Azure.Management.HDInsight.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/ScenarioTests/LocationOperationTests.cs(67,55): error CS1061: 'CapabilitiesResult' does not contain a definition for 'VmSizeFilters' and no accessible extension method 'VmSizeFilters' accepting a first argument of type 'CapabilitiesResult' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/Microsoft.Azure.Management.HDInsight.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/ScenarioTests/LocationOperationTests.cs(72,57): error CS1061: 'CapabilitiesResult' does not contain a definition for 'VmSizes' and no accessible extension method 'VmSizes' accepting a first argument of type 'CapabilitiesResult' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/Microsoft.Azure.Management.HDInsight.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/ScenarioTests/LocationOperationTests.cs(74,51): error CS1061: 'CapabilitiesResult' does not contain a definition for 'VmSizes' and no accessible extension method 'VmSizes' accepting a first argument of type 'CapabilitiesResult' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/Microsoft.Azure.Management.HDInsight.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/ScenarioTests/LocationOperationTests.cs(44,47): error CS1061: 'CapabilitiesResult' does not contain a definition for 'VmSizeFilters' and no accessible extension method 'VmSizeFilters' accepting a first argument of type 'CapabilitiesResult' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/Microsoft.Azure.Management.HDInsight.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/ScenarioTests/LocationOperationTests.cs(45,47): error CS1061: 'CapabilitiesResult' does not contain a definition for 'VmSizes' and no accessible extension method 'VmSizes' accepting a first argument of type 'CapabilitiesResult' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/Microsoft.Azure.Management.HDInsight.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/ScenarioTests/LocationOperationTests.cs(67,55): error CS1061: 'CapabilitiesResult' does not contain a definition for 'VmSizeFilters' and no accessible extension method 'VmSizeFilters' accepting a first argument of type 'CapabilitiesResult' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/Microsoft.Azure.Management.HDInsight.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/ScenarioTests/LocationOperationTests.cs(72,57): error CS1061: 'CapabilitiesResult' does not contain a definition for 'VmSizes' and no accessible extension method 'VmSizes' accepting a first argument of type 'CapabilitiesResult' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/Microsoft.Azure.Management.HDInsight.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/ScenarioTests/LocationOperationTests.cs(74,51): error CS1061: 'CapabilitiesResult' does not contain a definition for 'VmSizes' and no accessible extension method 'VmSizes' accepting a first argument of type 'CapabilitiesResult' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/tests/Microsoft.Azure.Management.HDInsight.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 2b69bec. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-29 05:47:40 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-hdinsight;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-01-29 05:47:40 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-01-29 05:47:40 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/hdinsight/azure-resourcemanager-hdinsight --java.namespace=com.azure.resourcemanager.hdinsight   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/hdinsight/resource-manager/readme.md
cmderr	[generate.py] 2021-01-29 05:48:24 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-hdinsight
cmderr	[generate.py] 2021-01-29 05:48:24 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-29 05:48:24 INFO [POM][Skip] pom already has module azure-resourcemanager-hdinsight
cmderr	[generate.py] 2021-01-29 05:48:24 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-29 05:48:24 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-29 05:48:24 INFO [POM][Skip] pom already has module sdk/hdinsight
cmderr	[generate.py] 2021-01-29 05:48:24 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-hdinsight [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-29 05:51:28 DEBUG Got artifact_id: azure-resourcemanager-hdinsight
cmderr	[Inst] 2021-01-29 05:51:28 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-29 05:51:28 DEBUG Got artifact: azure-resourcemanager-hdinsight-1.0.0-beta.2.jar
cmderr	[Inst] 2021-01-29 05:51:28 DEBUG Match jar package: azure-resourcemanager-hdinsight-1.0.0-beta.2.jar
cmderr	[Inst] 2021-01-29 05:51:28 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12612/azure-sdk-for-java/azure-resourcemanager-hdinsight/azure-resourcemanager-hdinsight-1.0.0-beta.2.jar\" -o azure-resourcemanager-hdinsight-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-hdinsight -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-hdinsight-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 2b69bec. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-hdinsight [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Role has a new parameter vm_group_name
info	[Changelog]   - Model ApplicationGetHttpsEndpoint has a new parameter private_ip_address
info	[Changelog]   - Model CapabilitiesResult has a new parameter vmsize_filters
info	[Changelog]   - Model CapabilitiesResult has a new parameter vmsizes
info	[Changelog]   - Model StorageAccount has a new parameter fileshare
info	[Changelog]   - Model StorageAccount has a new parameter saskey
info	[Changelog]   - Added operation ClustersOperations.get_azure_async_operation_status
info	[Changelog]   - Added operation LocationsOperations.get_azure_async_operation_status
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model CapabilitiesResult no longer has parameter vm_sizes
info	[Changelog]   - Model CapabilitiesResult no longer has parameter vm_size_filters

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2b69bec. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/hdinsight/resource-manager/readme.md

️✔️@azure/arm-hdinsight [View full logs] [Release SDK Changes]

azure-arm-hdinsight-0.21.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/hDInsightManagementClient.js → ./dist/arm-hdinsight.js...
cmderr	[npmPack] created ./dist/arm-hdinsight.js in 515ms

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2b69bec. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/hdinsight/resource-manager/readme.md
cmdout	[Autorest] WARNING: Found duplicate definition for type Microsoft.HDInsight/clusters/extensions in scope ResourceGroup
cmdout	[Autorest] WARNING: Found duplicate definition for type Microsoft.HDInsight/clusters/extensions in scope ResourceGroup

️✔️hdinsight [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-25T11:53:36Z

Hi @aim-for-better, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-01-25T11:55:14Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2021-01-25T11:55:14Z

Hi @aim-for-better, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

aim-for-better · 2021-01-26T07:44:32Z

Hi @leni-msft Could you please help review the PR?

leni-msft · 2021-01-26T07:51:32Z

Hi @aim-for-better , pls fix the LintError

aim-for-better · 2021-01-26T08:25:18Z

LintError

Hi @aim-for-better , pls fix the LintError

There is a conflict when generating sdk if I fix this linting error. The required error response structure is not consistent with the existing error response in swagger. And the fixing is not the same with the response from our service's backend. What should I do?

leni-msft · 2021-01-26T09:34:56Z

I see. Since this is to fix existing apiVersion, it's ok to me if you fix it in new apiVersion.

akning-ms · 2021-01-26T09:53:38Z

Hi @aim-for-better, is there any SDK refresh this PR change? @msyyc @ArcturusZhang (Python & GO) SDK owner for awareness possible breaking change caused by this fix

msyyc · 2021-01-27T01:53:14Z

For python, we will discuss about the breaking change

ArcturusZhang · 2021-01-27T07:42:26Z

...cation/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json

@@ -1733,7 +1790,7 @@
      },
      "description": "Gateway settings."
    },
-    "OperationResource": {
+    "AsyncOperationResult": {


Do we really need to rename this model? This renaming causes SDK breaking changes.
This model is not used at all in the previous version of this swagger, therefore could we just keep this name unchanged?

Do we really need to rename this model? This renaming causes SDK breaking changes.
This model is not used at all in the previous version of this swagger, therefore could we just keep this name unchanged?

Hi @ArcturusZhang , Thanks for your comment.
I think the new name is more meaningful. As you said, the class "OperationResource" is never used. I think this breaking change is ok, no customer will be impacted.

I know this PR will cause breaking change but we have to fix S360 issues.I just submitted the sdk release requirement about one week ago. Now we do not have the requirement for release sdk based this PR. Thank you very much~

Hi @ArcturusZhang , Is the reply accpetable for you? Besides this class name, there are other changes will cause breaking change too. This PR is fixing the S360 issues which will cause breaking changes in Sdks level.

aim-for-better · 2021-01-27T09:15:49Z

Hi @aim-for-better, is there any SDK refresh this PR change? @msyyc @ArcturusZhang (Python & GO) SDK owner for awareness possible breaking change caused by this fix

Hi @akning-ms Thanks for you comment. you concern is right, this PR will actually cause breaking change in Sdks. But now we do not need to refresh any sdks based this PR. I will submit sdk release request if we need. Thank you very much~

aim-for-better · 2021-01-27T09:26:53Z

The reason for the CI"SDK azure-sdk-for-net" Failed is that the sdk test project failed due to the breaking change caused by this PR.
There is not error when generating sdk.

aim-for-better · 2021-01-27T09:30:08Z

Hi @leni-msft , We can not fix the DefaultErrorResponseSchema linting error forever in swagger spec due to it will cause breaking change in our service, so I add suppression. Could you please help review again? Thank you very much~

* Add networkProperties and clusterId * Add properties: VMGroupName, saskey, fileshare Change vmSizes to vmsizes, vmSizes_filter to vmsizes_filter to fix S360 issue * Suppress R4007 DefaultErrorResponseSchema Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>

Zhenyu Zhou added 13 commits October 10, 2020 15:56

Add networkProperties and clusterId

46e7cb8

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

afc3561

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

75a1f51

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

34c9683

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

151f917

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

f271a42

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

92044fa

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

11e9fac

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

bbe65a3

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

a858456

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

2418dfb

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

891652d

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

3a250aa

aim-for-better requested a review from lirenhe as a code owner January 25, 2021 11:51

openapi-assignment-bot bot assigned leni-msft Jan 25, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 25, 2021

openapi-pipeline-app bot added BreakingChangeReviewRequired and removed CI-FixRequiredOnFailure labels Jan 25, 2021

openapi-sdkautomation bot mentioned this pull request Jan 25, 2021

[AutoPR @azure/arm-hdinsight] [Fix S360 Broken Issues][HDInsight]Fix s360 issues batch3 AzureSDKAutomation/azure-sdk-for-js#3357

Closed

openapi-pipeline-app bot added CI-FixRequiredOnFailure CI-BreakingChange-Go labels Jan 25, 2021

leni-msft approved these changes Jan 26, 2021

View reviewed changes

openapi-workflow-bot bot added the FixS360 label Jan 26, 2021

ArcturusZhang reviewed Jan 27, 2021

View reviewed changes

Suppress R4007 DefaultErrorResponseSchema

f6b8b18

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jan 27, 2021

aim-for-better requested review from ArcturusZhang and leni-msft January 27, 2021 09:27

ArcturusZhang approved these changes Jan 29, 2021

View reviewed changes

leni-msft merged commit 2b69bec into Azure:master Jan 29, 2021

aim-for-better mentioned this pull request Feb 1, 2021

[HDInsight]Support compute isolation and return private ip address Azure/azure-cli#16752

Merged

3 tasks

ArcturusZhang mentioned this pull request Feb 4, 2021

HDInsight Location Client Fails to Deserialize VersionSpec Model Azure/azure-sdk-for-go#14238

Closed

aim-for-better mentioned this pull request May 28, 2021

[HDInsight] Support azure monitor feature and fix S360 issues Azure/azure-sdk-for-net#21438

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix S360 Broken Issues][HDInsight]Fix s360 issues batch3 #12612

[Fix S360 Broken Issues][HDInsight]Fix s360 issues batch3 #12612

aim-for-better commented Jan 25, 2021 •

edited by akning-ms

Loading

openapi-workflow-bot bot commented Jan 25, 2021

openapi-pipeline-app bot commented Jan 25, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 25, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 25, 2021

openapi-workflow-bot bot commented Jan 25, 2021

openapi-workflow-bot bot commented Jan 25, 2021

aim-for-better commented Jan 26, 2021

leni-msft commented Jan 26, 2021

aim-for-better commented Jan 26, 2021 •

edited

Loading

leni-msft commented Jan 26, 2021

akning-ms commented Jan 26, 2021

msyyc commented Jan 27, 2021

ArcturusZhang Jan 27, 2021

aim-for-better Jan 27, 2021 •

edited

Loading

aim-for-better Jan 29, 2021

aim-for-better commented Jan 27, 2021

aim-for-better commented Jan 27, 2021

aim-for-better commented Jan 27, 2021 •

edited

Loading

[Fix S360 Broken Issues][HDInsight]Fix s360 issues batch3 #12612

[Fix S360 Broken Issues][HDInsight]Fix s360 issues batch3 #12612

Conversation

aim-for-better commented Jan 25, 2021 • edited by akning-ms Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 25, 2021

openapi-pipeline-app bot commented Jan 25, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 25, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 25, 2021

openapi-workflow-bot bot commented Jan 25, 2021

openapi-workflow-bot bot commented Jan 25, 2021

aim-for-better commented Jan 26, 2021

leni-msft commented Jan 26, 2021

aim-for-better commented Jan 26, 2021 • edited Loading

leni-msft commented Jan 26, 2021

akning-ms commented Jan 26, 2021

msyyc commented Jan 27, 2021

ArcturusZhang Jan 27, 2021

Choose a reason for hiding this comment

aim-for-better Jan 27, 2021 • edited Loading

Choose a reason for hiding this comment

aim-for-better Jan 29, 2021

Choose a reason for hiding this comment

aim-for-better commented Jan 27, 2021

aim-for-better commented Jan 27, 2021

aim-for-better commented Jan 27, 2021 • edited Loading

aim-for-better commented Jan 25, 2021 •

edited by akning-ms

Loading

openapi-pipeline-app bot commented Jan 25, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 25, 2021 •

edited

Loading

aim-for-better commented Jan 26, 2021 •

edited

Loading

aim-for-better Jan 27, 2021 •

edited

Loading

aim-for-better commented Jan 27, 2021 •

edited

Loading