Fix Swagger Correctness Issues For HealthcareApis #12651

anrudraw · 2021-01-26T17:11:53Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-01-26T17:11:56Z

Hi, @anrudraw Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-26T17:11:58Z

Swagger Validation Report

️❌BreakingChange: 12 Errors, 0 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2018-08-20-preview/healthcare-apis.json <---> new: preview/2018-08-20-preview/healthcare-apis.json
- original: stable/2019-09-16/healthcare-apis.json <---> new: stable/2019-09-16/healthcare-apis.json
- original: stable/2020-03-15/healthcare-apis.json <---> new: stable/2020-03-15/healthcare-apis.json
- original: stable/2020-03-30/healthcare-apis.json <---> new: stable/2020-03-30/healthcare-apis.json

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.HealthcareApis/stable/2019-09-16/healthcare-apis.json#L431:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.HealthcareApis/stable/2020-03-15/healthcare-apis.json#L431:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.HealthcareApis/stable/2020-03-30/healthcare-apis.json#L181:11
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'identity' in response that was not found in the old version. New: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L600:7 Old: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L600:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'isDataAction' in response that was not found in the old version. New: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L782:7 Old: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L754:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'properties' in response that was not found in the old version. New: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L782:7 Old: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L754:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'isDataAction' in response that was not found in the old version. New: Microsoft.HealthcareApis/stable/2019-09-16/healthcare-apis.json#L803:7 Old: Microsoft.HealthcareApis/stable/2019-09-16/healthcare-apis.json#L800:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'properties' in response that was not found in the old version. New: Microsoft.HealthcareApis/stable/2019-09-16/healthcare-apis.json#L803:7 Old: Microsoft.HealthcareApis/stable/2019-09-16/healthcare-apis.json#L800:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'isDataAction' in response that was not found in the old version. New: Microsoft.HealthcareApis/stable/2020-03-15/healthcare-apis.json#L808:7 Old: Microsoft.HealthcareApis/stable/2020-03-15/healthcare-apis.json#L805:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'properties' in response that was not found in the old version. New: Microsoft.HealthcareApis/stable/2020-03-15/healthcare-apis.json#L808:7 Old: Microsoft.HealthcareApis/stable/2020-03-15/healthcare-apis.json#L805:7

️⚠️LintDiff: 10 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )

Rule	Message
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L801
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.HealthcareApis/stable/2019-09-16/healthcare-apis.json#L822
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.HealthcareApis/stable/2020-03-15/healthcare-apis.json#L827
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.HealthcareApis/stable/2020-03-30/healthcare-apis.json#L1132
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'OperationResults_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. New: Microsoft.HealthcareApis/stable/2019-09-16/healthcare-apis.json#L399
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'OperationResults_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. New: Microsoft.HealthcareApis/stable/2020-03-15/healthcare-apis.json#L399
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction New: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L788
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction New: Microsoft.HealthcareApis/stable/2019-09-16/healthcare-apis.json#L809
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction New: Microsoft.HealthcareApis/stable/2020-03-15/healthcare-apis.json#L814
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction New: Microsoft.HealthcareApis/stable/2020-03-30/healthcare-apis.json#L1119

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-26T17:11:59Z

Swagger Generation Artifacts

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 0529893. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-02 02:59:36 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-healthcareapis"
cmderr	[generate.py] 2021-02-02 02:59:36 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-02 02:59:36 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/healthcareapis/azure-resourcemanager-healthcareapis --java.namespace=com.azure.resourcemanager.healthcareapis   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/healthcareapis/resource-manager/readme.md
cmderr	[generate.py] 2021-02-02 03:00:15 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-02 03:00:15 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-02 03:00:15 INFO [POM][Skip] pom already has module azure-resourcemanager-healthcareapis
cmderr	[generate.py] 2021-02-02 03:00:15 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-02 03:00:15 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-02 03:00:15 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-healthcareapis [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-02 03:03:13 DEBUG Got artifact_id: azure-resourcemanager-healthcareapis
cmderr	[Inst] 2021-02-02 03:03:13 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-02 03:03:13 DEBUG Got artifact: azure-resourcemanager-healthcareapis-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-02-02 03:03:13 DEBUG Got artifact: azure-resourcemanager-healthcareapis-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-02 03:03:13 DEBUG Match jar package: azure-resourcemanager-healthcareapis-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-02 03:03:13 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12651/azure-sdk-for-java/azure-resourcemanager-healthcareapis/azure-resourcemanager-healthcareapis-1.0.0-beta.1.jar\" -o azure-resourcemanager-healthcareapis-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-healthcareapis -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-healthcareapis-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0529893. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️healthcareapis/mgmt/2020-03-30/healthcareapis [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `IsDataAction` in struct `Operation`
info	[Changelog] - New field `Properties` in struct `Operation`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]

️✔️healthcareapis/mgmt/2020-03-15/healthcareapis [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `IsDataAction` in struct `Operation`
info	[Changelog] - New field `Properties` in struct `Operation`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]

️✔️healthcareapis/mgmt/2019-09-16/healthcareapis [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `Properties` in struct `Operation`
info	[Changelog] - New field `IsDataAction` in struct `Operation`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]

️✔️preview/healthcareapis/mgmt/2018-08-20-preview/healthcareapis [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `SystemAssigned`
info	[Changelog] - New const `None`
info	[Changelog] - New function `ResourceIdentity.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleManagedServiceIdentityTypeValues() []ManagedServiceIdentityType`
info	[Changelog] - New struct `ResourceIdentity`
info	[Changelog] - New field `Identity` in struct `ServicesDescription`
info	[Changelog] - New field `Identity` in struct `Resource`
info	[Changelog] - New field `Properties` in struct `Operation`
info	[Changelog] - New field `IsDataAction` in struct `Operation`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 9 additive change(s).
info	[Changelog]

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0529893. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/healthcareapis/resource-manager/readme.md

️✔️healthcareapis [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 0529893. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-healthcareapis [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ServicesDescription has a new parameter system_data
info	[Changelog]   - Model ServicesProperties has a new parameter acr_configuration

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0529893. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/healthcareapis/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.HealthcareApis [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.HealthcareApis.3.0.0.nupkg
- Microsoft.Azure.Management.HealthcareApis.3.0.0.snupkg

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0529893. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/healthcareapis/resource-manager/readme.md

️✔️@azure/arm-healthcareapis [View full logs] [Release SDK Changes]

azure-arm-healthcareapis-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/healthcareApisManagementClient.js → ./dist/arm-healthcareapis.js...
cmderr	[npmPack] created ./dist/arm-healthcareapis.js in 344ms

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-26T17:13:45Z

Hi @anrudraw, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-01-26T17:15:23Z

Hi @anrudraw, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

anrudraw · 2021-01-27T23:25:32Z

@PhoenixHe-msft This PR has a fix for below errors/action items:

PhoenixHe-NV · 2021-01-29T06:21:05Z

@anrudraw Do you need a refresh of SDK?

anrudraw · 2021-01-29T18:50:16Z

@PhoenixHe-msft Do you know what will be customer impact if we refresh SDKs?

PhoenixHe-NV · 2021-02-01T03:33:17Z

@anrudraw User will get latest update for your fix, but this may cause breaking change in SDK. Suggest to do so to fix SDK issues.

* Initial commit * Fix model validation * Fix typo

Initial commit

ea8cc85

openapi-assignment-bot bot assigned PhoenixHe-NV Jan 26, 2021

openapi-workflow-bot bot added the FixS360 label Jan 26, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 26, 2021

openapi-pipeline-app bot added BreakingChangeReviewRequired and removed CI-FixRequiredOnFailure labels Jan 26, 2021

anrudraw added the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label Jan 26, 2021

Fix model validation

3612880

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Jan 26, 2021

Fix typo

08b9c60

anrudraw removed the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label Jan 26, 2021

PhoenixHe-NV added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 29, 2021

PhoenixHe-NV approved these changes Jan 29, 2021

View reviewed changes

JeffreyRichter approved these changes Feb 1, 2021

View reviewed changes

PhoenixHe-NV merged commit 0529893 into Azure:master Feb 2, 2021

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

Fix Swagger Correctness Issues For HealthcareApis (Azure#12651)

cc7f628

* Initial commit * Fix model validation * Fix typo

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Swagger Correctness Issues For HealthcareApis #12651

Fix Swagger Correctness Issues For HealthcareApis #12651

anrudraw commented Jan 26, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 26, 2021

openapi-pipeline-app bot commented Jan 26, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 26, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 26, 2021

openapi-workflow-bot bot commented Jan 26, 2021

anrudraw commented Jan 27, 2021

PhoenixHe-NV commented Jan 29, 2021

anrudraw commented Jan 29, 2021

PhoenixHe-NV commented Feb 1, 2021

Fix Swagger Correctness Issues For HealthcareApis #12651

Fix Swagger Correctness Issues For HealthcareApis #12651

Conversation

anrudraw commented Jan 26, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 26, 2021

openapi-pipeline-app bot commented Jan 26, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 26, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 26, 2021

openapi-workflow-bot bot commented Jan 26, 2021

anrudraw commented Jan 27, 2021

PhoenixHe-NV commented Jan 29, 2021

anrudraw commented Jan 29, 2021

PhoenixHe-NV commented Feb 1, 2021

anrudraw commented Jan 26, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 26, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 26, 2021 •

edited

Loading