Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger Correctness Fixes MachineLearningServices #12662

Merged
merged 11 commits into from
Feb 3, 2021
Merged

Swagger Correctness Fixes MachineLearningServices #12662

merged 11 commits into from
Feb 3, 2021

Conversation

joshanator
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @joshanator Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 27, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

    Rule Message
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.MachineLearningServices/stable/2020-08-01/machineLearningServices.json#L2789:17
    Old: Microsoft.MachineLearningServices/stable/2020-08-01/machineLearningServices.json#L2785:17
    ❌ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L3329:17
    Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L3325:17
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'agentVMSize' renamed or removed?
    New: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L3278:15
    Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L3274:15
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'agentVMSize' renamed or removed?
    New: Microsoft.MachineLearningServices/stable/2020-08-01/machineLearningServices.json#L2776:15
    Old: Microsoft.MachineLearningServices/stable/2020-08-01/machineLearningServices.json#L2772:15
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 27, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7c043f3. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.MachineLearningServices [View full logs]  [Release SDK Changes]
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7c043f3. Azure CLI Automation 14.0.0
      Only show 120 items here, please refer to log for details.
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'VirtualMachineSize' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'EstimatedVMPrices' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'EstimatedVMPrice' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'VirtualMachineSizeListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'WorkspaceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'QuotaBaseProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'QuotaUpdateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'UpdateWorkspaceQuotasResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'UpdateWorkspaceQuotas' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceName' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceQuota' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ListWorkspaceQuotas' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Identity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DataFactory' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'UserAccountCredentials' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'NodeStateCounts' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ClusterUpdateProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ClusterUpdateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AmlComputeNodeInformation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceSkuLocationInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceSkuZoneDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Restriction' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateEndpointConnectionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateEndpoint' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkServiceConnectionState' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkResourceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkResourceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'SharedPrivateLinkResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'SharedPrivateLinkResourceProperty' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'AmlComputeNodesInformation' has a property 'nextLink' that is already declared the parent schema 'ComputeNodesInformation' but isn't significantly different. The property has been removed from AmlComputeNodesInformation
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmdout	[Autorest] WARNING: parameter properties has two different references but they have the same flattened name
cmdout	[Autorest] WARNING: parameter properties has two different references but they have the same flattened name
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Workspaces/put/Create Workspace
cmderr	[Autorest]     - name: /Workspaces/get/Get Workspace
cmderr	[Autorest]     - name: /Workspaces/get/Get Workspaces by Resource Group
cmderr	[Autorest]     - name: /Workspaces/get/Get Workspaces by subscription
cmderr	[Autorest]     - name: /Workspaces/patch/Update Workspace
cmderr	[Autorest]     - name: /Workspaces/post/List Workspace Keys
cmderr	[Autorest]     - name: /Workspaces/post/Resync Workspace Keys
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a AML Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a AML Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a AML Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a AML Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a AML Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a AML Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a AML Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a AML Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute with minimal inputs
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute with minimal inputs
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute with minimal inputs
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute with minimal inputs
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute with minimal inputs
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute with minimal inputs
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute with minimal inputs
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a ComputeInstance Compute with minimal inputs
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create AKS Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create AKS Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create AKS Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create AKS Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create AKS Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create AKS Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create AKS Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/put/Create AKS Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/get/Get a AKS Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/get/Get a AML Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/get/Get a ComputeInstance
cmderr	[Autorest]     - name: /MachineLearningCompute/get/Get Computes
cmderr	[Autorest]     - name: /MachineLearningCompute/patch/Update a AmlCompute Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/post/Get compute nodes information for a compute
cmderr	[Autorest]     - name: /MachineLearningCompute/post/List AKS Compute Keys
cmderr	[Autorest]     - name: /MachineLearningCompute/post/Restart ComputeInstance Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/post/Start ComputeInstance Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/post/Stop ComputeInstance Compute
cmderr	[Autorest]     - name: /MachineLearningCompute/delete/Delete Compute
cmderr	[Autorest]     - name: /machinelearningservices/get/List Skus
cmderr	[Autorest]     - name: /Notebooks/post/Prepare Notebook
cmderr	[Autorest]     - name: /PrivateEndpointConnections/put/WorkspacePutPrivateEndpointConnection
cmderr	[Autorest]     - name: /PrivateEndpointConnections/get/WorkspaceGetPrivateEndpointConnection
cmderr	[Autorest]     - name: /PrivateEndpointConnections/delete/WorkspaceDeletePrivateEndpointConnection
cmderr	[Autorest]     - name: /PrivateLinkResources/get/WorkspaceListPrivateLinkResources
cmderr	[Autorest]     - name: /Quotas/get/List workspace quotas by VMFamily
cmderr	[Autorest]     - name: /Quotas/post/update quotas
cmderr	[Autorest]     - name: /Usages/get/List Usages
cmderr	[Autorest]     - name: /VirtualMachineSizes/get/List VM Sizes
cmderr	[Autorest]     - name: /WorkspaceConnections/put/CreateWorkspaceConnection
cmderr	[Autorest]     - name: /WorkspaceConnections/get/GetWorkspaceConnection
cmderr	[Autorest]     - name: /WorkspaceConnections/get/ListWorkspaceConnections
cmderr	[Autorest]     - name: /WorkspaceConnections/delete/DeleteWorkspaceConnection
cmderr	[Autorest]     - name: /WorkspaceFeatures/get/List Workspace features
cmderr	[Autorest]     - name: /Workspaces/delete/Delete Workspace
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest] /bin/sh: 1: cd: can't cd to home/vsts/work/1/s/azure-rest-api-specs
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
    • ️✔️machinelearningservices [View full logs]  [Release Azure CLI Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7c043f3. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️machinelearningservices/mgmt/2020-04-01/machinelearningservices [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️machinelearningservices/mgmt/2020-03-01/machinelearningservices [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️machinelearningservices/mgmt/2020-01-01/machinelearningservices [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️machinelearningservices/mgmt/2019-11-01/machinelearningservices [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️machinelearningservices/mgmt/2019-06-01/machinelearningservices [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️machinelearningservices/mgmt/2019-05-01/machinelearningservices [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️machinelearningservices/mgmt/2018-11-19/machinelearningservices [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/machinelearningservices/mgmt/2020-02-18-preview/machinelearningservices [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/machinelearningservices/mgmt/2018-03-01-preview/machinelearningservices [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7c043f3. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md
    • ️✔️@azure/arm-machinelearningservices [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/azureMachineLearningWorkspaces.js → ./dist/arm-machinelearningservices.js...
cmderr	[npmPack] created ./dist/arm-machinelearningservices.js in 528ms
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7c043f3. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-machinelearningservices [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Workspace has a new parameter sku
info	[Changelog]   - Model Workspace has a new parameter shared_private_link_resources
info	[Changelog]   - Model Workspace has a new parameter service_provisioned_resource_group
info	[Changelog]   - Model Workspace has a new parameter private_link_count
info	[Changelog]   - Model Workspace has a new parameter image_build_compute
info	[Changelog]   - Model Workspace has a new parameter allow_public_access_when_behind_vnet
info	[Changelog]   - Model Workspace has a new parameter notebook_info
info	[Changelog]   - Model Workspace has a new parameter encryption
info	[Changelog]   - Model Workspace has a new parameter hbi_workspace
info	[Changelog]   - Model Workspace has a new parameter private_endpoint_connections
info	[Changelog]   - Model ListWorkspaceKeysResult has a new parameter notebook_access_keys
info	[Changelog]   - Model ComputeResource has a new parameter sku
info	[Changelog]   - Model AmlComputeProperties has a new parameter remote_login_port_public_access
info	[Changelog]   - Model AmlComputeProperties has a new parameter os_type
info	[Changelog]   - Model Resource has a new parameter sku
info	[Changelog]   - Model VirtualMachineSize has a new parameter supported_compute_types
info	[Changelog]   - Model VirtualMachineSize has a new parameter estimated_vm_prices
info	[Changelog]   - Model VirtualMachineSize has a new parameter gpus
info	[Changelog]   - Model Identity has a new parameter user_assigned_identities
info	[Changelog]   - Model WorkspaceUpdateParameters has a new parameter sku
info	[Changelog]   - Added operation MachineLearningComputeOperations.restart
info	[Changelog]   - Added operation MachineLearningComputeOperations.start
info	[Changelog]   - Added operation MachineLearningComputeOperations.stop
info	[Changelog]   - Added operation group QuotasOperations
info	[Changelog]   - Added operation group AzureMachineLearningWorkspacesOperationsMixin
info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
info	[Changelog]   - Added operation group WorkspaceFeaturesOperations
info	[Changelog]   - Added operation group WorkspaceConnectionsOperations
info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
info	[Changelog]   - Added operation group NotebooksOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Parameter type of model Identity is now required
info	[Changelog]   - Operation VirtualMachineSizesOperations.list has a new signature
info	[Changelog]   - Model AmlComputeNodeInformation has a new signature
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7c043f3. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/machinelearningservices/resource-manager/readme.md
cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/Microsoft.MachineLearningServices/workspaces/{workspaceName}/linkedWorkspaces/{linkName}': Unable to locate '/providers/' segment
    • ️✔️machinelearningservices [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
cmderr	[resource-manager]  ELIFECYCLE
cmderr	[resource-manager] npm ERR! errno 1
cmderr	[resource-manager] ERR! template-schema-validation-tools@1.0.0 test: `mocha -r ts-node/register tests.ts`
cmderr	[resource-manager] npm ERR! Exit status 1
cmderr	[resource-manager] npm ERR!
cmderr	[resource-manager] npm ERR! Failed at the template-schema-validation-tools@1.0.0 test script.
cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
cmderr	[resource-manager]  A complete log of this run can be found in:
cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2021-02-03T07_40_32_499Z-debug.log
cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
cmderr	[resource-manager]   status: 1,
cmderr	[resource-manager]   signal: null,
cmderr	[resource-manager]   output: [ null, null, null ],
cmderr	[resource-manager]   pid: 3299,
cmderr	[resource-manager]   stdout: null,
cmderr	[resource-manager]   stderr: null
cmderr	[resource-manager] }
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @joshanator, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    This was referenced Jan 27, 2021
    Closed
    Closed
    Closed
    This was referenced Jan 27, 2021
    Closed
    Closed
    @ArcturusZhang
    Copy link
    Member

    @joshanator please make sure you submit breaking change review request. You can find the guidance in the comment by the openapi-workflow-bot.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 1, 2021
    @joshanator
    Copy link
    Contributor Author

    @JeffreyRichter Can this be merged at this point? I submitted a breaking change work item: https://msazure.visualstudio.com/One/_workitems/edit/9222426, do we wait for that to be addressed or is the "Approved-BreakingChange" tag sufficient?

    @JeffreyRichter
    Copy link
    Member

    Yes, this can be merged

    @joshanator
    Copy link
    Contributor Author

    I do not have permissions to merge. Is there anything I need to do?

    @ArcturusZhang ArcturusZhang merged commit 7c043f3 into Azure:master Feb 3, 2021
    This was referenced Feb 3, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Merged
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @mikhailshilkov mikhailshilkov mentioned this pull request Feb 4, 2021
    Closed
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @joshanator @mkarmark
    Swagger Correctness Fixes MachineLearningServices (Azure#12662)
    578bf89 
    * Fix GetAmlCompute examples for isolatedNetwork

* add computeInstanceAuthorizationType to 20200801

* add OsType to amlcompute 20200801

* give default ostype for amlcompute

* Update nodeIdleTimeBeforeScaleDown description 20200801

* add "auto" to SslConfiguration enum

* matching identiity.type enum order of future

* agentvmsize typo fixed

* add setupScripts to computeInstance 09-01

* add format to agentCount 20200801

* mark listnodes as pageable

Co-authored-by: jopet@microsoft.com <jopet@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

    Assignees

    @ArcturusZhang ArcturusZhang

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python FixS360
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @joshanator @ArcturusZhang @JeffreyRichter