-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[DataFactory]Set servicePrincipalId,servicePrincipalKey and tenant to be optional from AzureDataExplorerLinkedServiceTypeProperties" #12769
Conversation
Hi, @Jingshu923 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
1034 - AddedRequiredProperty |
The new version has new required property 'servicePrincipalId, servicePrincipalKey, tenant' that was not found in the old version. New: stable/2018-06-01/entityTypes/LinkedService.json#L5792:9 Old: stable/2018-06-01/entityTypes/LinkedService.json#L5792:9 |
1034 - AddedRequiredProperty |
The new version has new required property 'servicePrincipalId, servicePrincipalKey, tenant' that was not found in the old version. New: stable/2018-06-01/entityTypes/LinkedService.json#L5802:5 Old: stable/2018-06-01/entityTypes/LinkedService.json#L5802:5 |
️️✔️
LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
Hi @Jingshu923, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This PR is to revert a previous PR merged one day ago as the last PR is declared as a breaking change in .net SDK. |
…enant to be optional from AzureDataExplorerLinkedServiceTypeProperties (Azure#12755)" (Azure#12769) This reverts commit baa5ac2.
Reverts #12755