Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 #12802

Merged
merged 3 commits into from
Feb 4, 2021
Merged

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 #12802

merged 3 commits into from
Feb 4, 2021

Conversation

sashahdo
Copy link
Contributor

@sashahdo sashahdo commented Feb 3, 2021 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 3, 2021 •
edited
Loading

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Rule Message
❌ 1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L651:11
️️✔️LintDiff succeeded [Detail] [Expand] 
Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @sashahdo Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 3, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 460e239. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/cost-management/resource-manager/readme.md
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.CostManagement/reports. Skipping definition with path '/providers/Microsoft.Billing/departments/{departmentId}/providers/Microsoft.CostManagement/reports/{reportName}'.
cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.CostManagement/reports. Using definition with path '/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/providers/Microsoft.CostManagement/reports/{reportName}'.
    • ️✔️cost-management [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
cmderr	[resource-manager]  ERR! code ELIFECYCLE
cmderr	[resource-manager] npm ERR! errno 9
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 test: `mocha -r ts-node/register tests.ts`
cmderr	[resource-manager] npm ERR! Exit status 9
cmderr	[resource-manager] npm ERR!
cmderr	[resource-manager] npm ERR! Failed at the template-schema-validation-tools@1.0.0 test script.
cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
cmderr	[resource-manager] npm ERR! A complete log of this run can be found in:
cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2021-02-04T03_06_29_266Z-debug.log
cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
cmderr	[resource-manager]   status: 9,
cmderr	[resource-manager]   signal: null,
cmderr	[resource-manager]   output: [ null, null, null ],
cmderr	[resource-manager]   pid: 2967,
cmderr	[resource-manager]   stdout: null,
cmderr	[resource-manager]   stderr: null
cmderr	[resource-manager] }
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 460e239. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️costmanagement/mgmt/2019-10-01/costmanagement [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️costmanagement/mgmt/2019-01-01/costmanagement [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️costmanagement/mgmt/2018-05-31/costmanagement [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/costmanagement/mgmt/2019-03-01/costmanagement [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/costmanagement/mgmt/2018-08-01-preview/costmanagement [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 460e239. Azure CLI Automation 14.0.0
      Only show 120 items here, please refer to log for details.
      cmderr	[Autorest]     - name: /Alerts/get/BillingAccountAlerts
cmderr	[Autorest]     - name: /Alerts/get/BillingProfileAlerts
cmderr	[Autorest]     - name: /Alerts/get/DepartmentAlerts
cmderr	[Autorest]     - name: /Alerts/get/EnrollmentAccountAlerts
cmderr	[Autorest]     - name: /Alerts/get/ExternalBillingAccountAlerts
cmderr	[Autorest]     - name: /Alerts/get/ExternalSubscriptionAlerts
cmderr	[Autorest]     - name: /Alerts/get/InvoiceSectionAlerts
cmderr	[Autorest]     - name: /Alerts/get/ResourceGroupAlerts
cmderr	[Autorest]     - name: /Alerts/get/ResourceGroupAlerts
cmderr	[Autorest]     - name: /Alerts/get/SubscriptionAlerts
cmderr	[Autorest]     - name: /Alerts/get/SubscriptionAlerts
cmderr	[Autorest]     - name: /Alerts/patch/ResourceGroupAlerts
cmderr	[Autorest]     - name: /Alerts/patch/SubscriptionAlerts
cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsList-Legacy
cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsList-Modern
cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Legacy
cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Modern
cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Legacy
cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Modern
cmderr	[Autorest]     - name: /Dimensions/get/BillingProfileDimensionsList-Modern
cmderr	[Autorest]     - name: /Dimensions/get/BillingProfileDimensionsListExpandAndTop-Modern
cmderr	[Autorest]     - name: /Dimensions/get/BillingProfileDimensionsListWithFilter-Modern
cmderr	[Autorest]     - name: /Dimensions/get/CustomerDimensionsList-Modern
cmderr	[Autorest]     - name: /Dimensions/get/CustomerDimensionsListExpandAndTop-Modern
cmderr	[Autorest]     - name: /Dimensions/get/CustomerDimensionsListWithFilter-Modern
cmderr	[Autorest]     - name: /Dimensions/get/DepartmentDimensionsList-Legacy
cmderr	[Autorest]     - name: /Dimensions/get/DepartmentDimensionsListExpandAndTop-Legacy
cmderr	[Autorest]     - name: /Dimensions/get/DepartmentDimensionsListWithFilter-Legacy
cmderr	[Autorest]     - name: /Dimensions/get/EnrollmentAccountDimensionsList-Legacy
cmderr	[Autorest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListExpandAndTop-Legacy
cmderr	[Autorest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListWithFilter-Legacy
cmderr	[Autorest]     - name: /Dimensions/get/ExternalBillingAccountDimensionList
cmderr	[Autorest]     - name: /Dimensions/get/ExternalSubscriptionDimensionList
cmderr	[Autorest]     - name: /Dimensions/get/InvoiceSectionDimensionsList-Modern
cmderr	[Autorest]     - name: /Dimensions/get/InvoiceSectionDimensionsListExpandAndTop-Modern
cmderr	[Autorest]     - name: /Dimensions/get/InvoiceSectionDimensionsListWithFilter-Modern
cmderr	[Autorest]     - name: /Dimensions/get/ManagementGroupDimensionsList-Legacy
cmderr	[Autorest]     - name: /Dimensions/get/ManagementGroupDimensionsListExpandAndTop-Legacy
cmderr	[Autorest]     - name: /Dimensions/get/ManagementGroupDimensionsListWithFilter-Legacy
cmderr	[Autorest]     - name: /Dimensions/get/ResourceGroupDimensionsList-Legacy
cmderr	[Autorest]     - name: /Dimensions/get/SubscriptionDimensionsList-Legacy
cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByBillingAccount
cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByDepartment
cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByEnrollmentAccount
cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByManagementGroup
cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByResourceGroup
cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateBySubscription
cmderr	[Autorest]     - name: /Exports/get/ExportGetByBillingAccount
cmderr	[Autorest]     - name: /Exports/get/ExportGetByDepartment
cmderr	[Autorest]     - name: /Exports/get/ExportGetByEnrollmentAccount
cmderr	[Autorest]     - name: /Exports/get/ExportGetByManagementGroup
cmderr	[Autorest]     - name: /Exports/get/ExportGetByResourceGroup
cmderr	[Autorest]     - name: /Exports/get/ExportGetBySubscription
cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByBillingAccount
cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByDepartment
cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByEnrollmentAccount
cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByManagementGroup
cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByResourceGroup
cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetBySubscription
cmderr	[Autorest]     - name: /Exports/get/ExportsGetByBillingAccount
cmderr	[Autorest]     - name: /Exports/get/ExportsGetByDepartment
cmderr	[Autorest]     - name: /Exports/get/ExportsGetByEnrollmentAccount
cmderr	[Autorest]     - name: /Exports/get/ExportsGetByManagementGroup
cmderr	[Autorest]     - name: /Exports/get/ExportsGetByResourceGroup
cmderr	[Autorest]     - name: /Exports/get/ExportsGetBySubscription
cmderr	[Autorest]     - name: /Exports/post/ExportRunByBillingAccount
cmderr	[Autorest]     - name: /Exports/post/ExportRunByDepartment
cmderr	[Autorest]     - name: /Exports/post/ExportRunByEnrollmentAccount
cmderr	[Autorest]     - name: /Exports/post/ExportRunByManagementGroup
cmderr	[Autorest]     - name: /Exports/post/ExportRunByResourceGroup
cmderr	[Autorest]     - name: /Exports/post/ExportRunBySubscription
cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByBillingAccount
cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByDepartment
cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByEnrollmentAccount
cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByManagementGroup
cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByResourceGroup
cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteBySubscription
cmderr	[Autorest]     - name: /Forecast/post/BillingAccountForecast
cmderr	[Autorest]     - name: /Forecast/post/BillingProfileForecast
cmderr	[Autorest]     - name: /Forecast/post/DepartmentForecast
cmderr	[Autorest]     - name: /Forecast/post/EnrollmentAccountForecast
cmderr	[Autorest]     - name: /Forecast/post/ExternalBillingAccountForecast
cmderr	[Autorest]     - name: /Forecast/post/ExternalSubscriptionForecast
cmderr	[Autorest]     - name: /Forecast/post/InvoiceSectionForecast
cmderr	[Autorest]     - name: /Forecast/post/ResourceGroupForecast
cmderr	[Autorest]     - name: /Forecast/post/SubscriptionForecast
cmderr	[Autorest]     - name: /Query/post/BillingAccountQuery-Legacy
cmderr	[Autorest]     - name: /Query/post/BillingAccountQuery-Modern
cmderr	[Autorest]     - name: /Query/post/BillingAccountQueryGrouping-Legacy
cmderr	[Autorest]     - name: /Query/post/BillingAccountQueryGrouping-Modern
cmderr	[Autorest]     - name: /Query/post/BillingProfileQuery-Modern
cmderr	[Autorest]     - name: /Query/post/BillingProfileQueryGrouping-Modern
cmderr	[Autorest]     - name: /Query/post/CustomerQuery-Modern
cmderr	[Autorest]     - name: /Query/post/CustomerQueryGrouping-Modern
cmderr	[Autorest]     - name: /Query/post/DepartmentQuery-Legacy
cmderr	[Autorest]     - name: /Query/post/DepartmentQueryGrouping-Legacy
cmderr	[Autorest]     - name: /Query/post/EnrollmentAccountQuery-Legacy
cmderr	[Autorest]     - name: /Query/post/EnrollmentAccountQueryGrouping-Legacy
cmderr	[Autorest]     - name: /Query/post/ExternalBillingAccountQueryList
cmderr	[Autorest]     - name: /Query/post/ExternalSubscriptionsQuery
cmderr	[Autorest]     - name: /Query/post/InvoiceSectionQuery-Modern
cmderr	[Autorest]     - name: /Query/post/InvoiceSectionQueryGrouping-Modern
cmderr	[Autorest]     - name: /Query/post/ManagementGroupQuery-Legacy
cmderr	[Autorest]     - name: /Query/post/ManagementGroupQueryGrouping-Legacy
cmderr	[Autorest]     - name: /Query/post/ResourceGroupQuery-Legacy
cmderr	[Autorest]     - name: /Query/post/ResourceGroupQueryGrouping-Legacy
cmderr	[Autorest]     - name: /Query/post/SubscriptionQuery-Legacy
cmderr	[Autorest]     - name: /Query/post/SubscriptionQueryGrouping-Legacy
cmderr	[Autorest]     - name: /Views/put/CreateOrUpdatePrivateView
cmderr	[Autorest]     - name: /Views/put/ResourceGroupCreateOrUpdateView
cmderr	[Autorest]     - name: /Views/get/PrivateView
cmderr	[Autorest]     - name: /Views/get/PrivateViewList
cmderr	[Autorest]     - name: /Views/get/ResourceGroupView
cmderr	[Autorest]     - name: /Views/get/ResourceGroupViewList
cmderr	[Autorest]     - name: /Views/delete/DeletePrivateView
cmderr	[Autorest]     - name: /Views/delete/ResourceGroupDeleteView
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest] /bin/sh: 1: cd: can't cd to home/vsts/work/1/s/azure-rest-api-specs
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
    • ️✔️costmanagement [View full logs]  [Release Azure CLI Changes]
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 460e239. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/cost-management/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.CostManagement [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 460e239. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-costmanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ExportExecution has a new parameter error
info	[Changelog]   - Model ExportExecution has a new parameter e_tag
info	[Changelog]   - Model CommonExportProperties has a new parameter next_run_time_estimate
info	[Changelog]   - Model CommonExportProperties has a new parameter run_history
info	[Changelog]   - Model Export has a new parameter next_run_time_estimate
info	[Changelog]   - Model Export has a new parameter run_history
info	[Changelog]   - Model Export has a new parameter e_tag
info	[Changelog]   - Added operation QueryOperations.usage_by_external_cloud_provider_type
info	[Changelog]   - Added operation DimensionsOperations.by_external_cloud_provider_type
info	[Changelog]   - Added operation group ForecastOperations
info	[Changelog]   - Added operation group AlertsOperations
info	[Changelog]   - Added operation group ViewsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation ExportsOperations.get has a new signature
info	[Changelog]   - Operation ExportsOperations.list has a new signature
info	[Changelog]   - Model ExportExecution no longer has parameter tags
info	[Changelog]   - Model Export no longer has parameter tags
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @sashahdo, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    This was referenced Feb 3, 2021
    Closed
    Closed
    Closed
    @sashahdo sashahdo marked this pull request as ready for review February 3, 2021 17:54
    @openapi-workflow-bot
    Copy link

    In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details.

    @sashahdo
    Copy link
    Contributor Author

    sashahdo commented Feb 3, 2021

    This PR is to fix the following validation error: https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=0BA60D7B-3D9F-4C83-91D1-06D3A69188E4

    It simply fixes the Swagger to match with what the API actually does and thus isn't a true breaking change.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 3, 2021
    @PhoenixHe-NV PhoenixHe-NV merged commit 460e239 into Azure:master Feb 4, 2021
    This was referenced Feb 4, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @sashahdo @mkarmark
    [Hub Generated] Review request for Microsoft.CostManagement to add ve…
    134488b 
    …rsion stable/2019-11-01 (Azure#12802)

* Added 204 response to Forecast to match Query.

* added 204 response to forecast examples

* fixed typo
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

    @PhoenixHe-NV PhoenixHe-NV PhoenixHe-NV approved these changes

    Assignees

    @PhoenixHe-NV PhoenixHe-NV

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python FixS360
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @sashahdo @JeffreyRichter @PhoenixHe-NV