Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Data Share: Remove UserAssigned MSI #12900

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Azure Data Share: Remove UserAssigned MSI #12900

merged 1 commit into from
Feb 10, 2021

Conversation

ahermas
Copy link
Contributor

@ahermas ahermas commented Feb 8, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ahermas Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 8, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 3 Warnings warning [Detail]

    Rule Message
    ⚠️ PreCheck/SchemaMissingType "readme":"datashare/resource-manager/readme.md",
    "tag":"package-2020-09-01",
    "details":"The schema 'DefaultDto-systemData' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"datashare/resource-manager/readme.md",
    "tag":"package-2020-09-01",
    "details":"The schema 'ProxyDto-systemData' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/CheckDuplicateSchemas "readme":"datashare/resource-manager/readme.md",
    "tag":"package-2020-09-01",
    "details":"Checking for duplicate schemas,
    this could take a (long) while. Run with --verbose for more detail."
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 8, 2021

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0701d53. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-datashare [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation DataSetMappingsOperations.list_by_share_subscription has a new signature
      info	[Changelog]   - Operation DataSetMappingsOperations.list_by_share_subscription has a new signature
      info	[Changelog]   - Operation DataSetsOperations.list_by_share has a new signature
      info	[Changelog]   - Operation DataSetsOperations.list_by_share has a new signature
      info	[Changelog]   - Operation InvitationsOperations.list_by_share has a new signature
      info	[Changelog]   - Operation InvitationsOperations.list_by_share has a new signature
      info	[Changelog]   - Operation ShareSubscriptionsOperations.list_synchronization_details has a new signature
      info	[Changelog]   - Operation ShareSubscriptionsOperations.list_synchronization_details has a new signature
      info	[Changelog]   - Operation ShareSubscriptionsOperations.list_synchronizations has a new signature
      info	[Changelog]   - Operation ShareSubscriptionsOperations.list_synchronizations has a new signature
      info	[Changelog]   - Operation SharesOperations.list_synchronization_details has a new signature
      info	[Changelog]   - Operation SharesOperations.list_synchronization_details has a new signature
      info	[Changelog]   - Operation SharesOperations.list_synchronizations has a new signature
      info	[Changelog]   - Operation SharesOperations.list_synchronizations has a new signature
      info	[Changelog]   - Operation SharesOperations.list_by_account has a new signature
      info	[Changelog]   - Operation ShareSubscriptionsOperations.list_by_account has a new signature
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0701d53. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️datashare/mgmt/2019-11-01/datashare [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/datashare/mgmt/2018-11-01-preview/datashare [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️❌ azure-cli-extensions failed [Detail]
    • Failed [Logs]Release - Generate from 0701d53. Azure CLI Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/datashare/resource-manager/readme.md
      cmderr	[Autorest] Failed to install or start extension '@autorest/python' (5.4.0)
      cmderr	[Autorest]   Error: Package '@autorest/python' - '5.4.0' failed to install:
      cmderr	[Autorest]   Failed to install package 'https://registry.npmjs.org/@autorest/python/-/python-5.4.0.tgz' -- Error: Process Failed.Error: Failed to install package 'https://registry.npmjs.org/@autorest/python/-/python-5.4.0.tgz' -- Error: Process Failed.
      cmderr	[Autorest]     at install (/node_modules/@azure-tools/extension/dist/main.js:367:15)
      cmderr	[Autorest]     at processTicksAndRejections (internal/process/task_queues.js:97:5)
      cmderr	[Autorest]     at async ExtensionManager.installPackage (/node_modules/@azure-tools/extension/dist/main.js:571:13)
      cmderr	[Autorest]     at async resolveExtensions (/home/vsts/.autorest/@autorest_core@3.0.6271/node_modules/@autorest/core/dist/lib/configuration.js:926:55)
      cmderr	[Autorest]     at async Configuration.CreateView (/home/vsts/.autorest/@autorest_core@3.0.6271/node_modules/@autorest/core/dist/lib/configuration.js:967:9)
      cmderr	[Autorest]     at async AutoRest.RegenerateView (/home/vsts/.autorest/@autorest_core@3.0.6271/node_modules/@autorest/core/dist/lib/autorest-core.js:66:29)
      cmderr	[Autorest]     at async currentMain (/home/vsts/.autorest/@autorest_core@3.0.6271/node_modules/@autorest/core/dist/app.js:311:21)
      cmderr	[Autorest]     at async mainImpl (/home/vsts/.autorest/@autorest_core@3.0.6271/node_modules/@autorest/core/dist/app.js:510:20)
      cmderr	[Autorest]     at async main (/home/vsts/.autorest/@autorest_core@3.0.6271/node_modules/@autorest/core/dist/app.js:537:20)
      error	Script return with result [failed] code [1] signal [null] cwd [azure-cli-extensions]: autorest
      warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0701d53. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datashare/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.DataShare [View full logs]  [Release SDK Changes]
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details.

    @ahermas
    Copy link
    Contributor Author

    ahermas commented Feb 8, 2021

    This PR removes the "UserAssigned" item under "Identity" that was added last week for 2020-09-01.
    The addition of "UserAssigned" was done by mistake.

    @ahermas
    Copy link
    Contributor Author

    ahermas commented Feb 9, 2021

    @markcowl Hi Mark, I'm wondering if you or someone else from the reviewers is taking a look at this PR?
    Thanks in advance!

    @markcowl markcowl added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Feb 10, 2021
    @markcowl markcowl merged commit 0701d53 into Azure:master Feb 10, 2021
    iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Feb 10, 2021
    …into fix_resource_multiapi_submodule
    
    * 'master' of https://github.com/Azure/azure-rest-api-specs: (452 commits)
      Dev cost management microsoft.cost management 2020 12 01 preview new (Azure#12259)
      Edit securityContact swagger for 2020-01-01 (Azure#12265)
      [Hub Generated] Review request for Microsoft.Insights to add version stable/2020-10-01 (Azure#11579)
      [Hub Generated] Review request for Microsoft.Media to add version stable/2020-05-01 (Azure#12681)
      Fix TimeSeriesInsights swagger issues (Azure#12204)
      Fixing error in lastModifiedAt description (Azure#12854)
      Update comment.yml (Azure#12910)
      Fixing RI s360 Flagged corrections in 2019-10-01 version (Azure#12777)
      [Hub Generated] Review request for Microsoft.Web to add version stable/2020-10-01 (Azure#11636)
      [Ready For Review] New version 20210101 (Azure#12111)
      Update scheduledQueryRule_API.json (Azure#12895)
      Remove UserAssigned MSI (Azure#12900)
      Update library.json (Azure#12922)
      KeyVault: Feature/update security domain spec (Azure#12863)
      Fixes ExampleId type and incorrect ArmTokenParameter name (Azure#12896)
      Update contract for anomaly detector (Azure#12487)
      [NetAppFiles] Urgent bug fix, backup response, remove systemData(not in response yet) (Azure#12852)
      [AML] Add PipelineEndpoint with version and DataPathAssignments fields in AzureMLExecutePipeline (Azure#12744)
      remove duplicated schema (Azure#12779)
      [Web] Add Swagger for Service Principal (Azure#12780)
      ...
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates CI-BreakingChange-Python FixS360
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants