[Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2019-01-01-preview #12993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @hassanchawiche Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
/azp run unifiedPipeline |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/servicefabric/resource-manager/readme.md tag: specification/servicefabric/resource-manager/readme.md#tag-package-2020-03 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 8 Errors, 47 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named AggregationsKind -- properties: "kind":"description":"The kind of the setting", "$ref":"#/components/schemas/AggregationsKind" =>, type: undefined => "string", required: ["kind"] =>, enum: undefined => ["CasesAggregation"], x-ms-enum: undefined => "modelAsString":true, "name":"AggregationsKind" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named AlertRuleKind -- properties: "kind":"description":"The kind of the alert rule", "$ref":"#/components/schemas/AlertRuleKind" =>, type: undefined => "string", required: ["kind"] =>, enum: undefined => ["Scheduled", "MicrosoftSecurityIncidentCreation", "Fusion", "MLBehaviorAnalytics", "ThreatIntelligence", "Anomaly"], x-ms-enum: undefined => "modelAsString":true, "name":"AlertRuleKind", "values":["value":"Scheduled", "value":"MicrosoftSecurityIncidentCreation", "value":"Fusion", "value":"MLBehaviorAnalytics", "value":"ThreatIntelligence", "value":"Anomaly"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named DataConnectorKind -- properties: "kind":"description":"The kind of the data connector", "$ref":"#/components/schemas/DataConnectorKind" =>, type: undefined => "string", required: ["kind"] =>, enum: undefined => ["AzureActiveDirectory", "AzureSecurityCenter", "MicrosoftCloudAppSecurity", "ThreatIntelligence", "ThreatIntelligenceTaxii", "Office365", "OfficeATP", "AmazonWebServicesCloudTrail", "AzureAdvancedThreatProtection", "MicrosoftDefenderAdvancedThreatProtection", "Dynamics365", "MicrosoftThreatProtection", "MicrosoftThreatIntelligence"], x-ms-enum: undefined => "modelAsString":true, "name":"DataConnectorKind", "values":["value":"AzureActiveDirectory", "value":"AzureSecurityCenter", "value":"MicrosoftCloudAppSecurity", "value":"ThreatIntelligence", "value":"ThreatIntelligenceTaxii", "value":"Office365", "value":"OfficeATP", "value":"AmazonWebServicesCloudTrail", "value":"AzureAdvancedThreatProtection", "value":"MicrosoftDefenderAdvancedThreatProtection", "value":"Dynamics365", "value":"MicrosoftThreatProtection", "value":"MicrosoftThreatIntelligence"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named EntityKind -- properties: "kind":"description":"The kind of the entity.", "$ref":"#/components/schemas/EntityKind" =>, type: undefined => "string", required: ["kind"] =>, enum: undefined => ["Account", "Host", "File", "AzureResource", "CloudApplication", "DnsResolution", "FileHash", "Ip", "Malware", "Process", "RegistryKey", "RegistryValue", "SecurityGroup", "Url", "IoTDevice", "SecurityAlert", "Bookmark", "Mailbox", "MailCluster", "MailMessage", "SubmissionMail"], x-ms-enum: undefined => "modelAsString":true, "name":"EntityKind", "values":["description":"Entity represents account in the system.", "value":"Account", "description":"Entity represents host in the system.", "value":"Host", "description":"Entity represents file in the system.", "value":"File", "description":"Entity represents azure resource in the system.", "value":"AzureResource", "description":"Entity represents cloud application in the system.", "value":"CloudApplication", "description":"Entity represents dns resolution in the system.", "value":"DnsResolution", "description":"Entity represents file hash in the system.", "value":"FileHash", "description":"Entity represents ip in the system.", "value":"Ip", "description":"Entity represents malware in the system.", "value":"Malware", "description":"Entity represents process in the system.", "value":"Process", "description":"Entity represents registry key in the system.", "value":"RegistryKey", "description":"Entity represents registry value in the system.", "value":"RegistryValue", "description":"Entity represents security group in the system.", "value":"SecurityGroup", "description":"Entity represents url in the system.", "value":"Url", "description":"Entity represents IoT device in the system.", "value":"IoTDevice", "description":"Entity represents security alert in the system.", "value":"SecurityAlert", "description":"Entity represents bookmark in the system.", "value":"Bookmark", "description":"Entity represents mail cluster in the system.", "value":"MailCluster", "description":"Entity represents mail message in the system.", "value":"MailMessage", "description":"Entity represents mailbox in the system.", "value":"Mailbox", "description":"Entity represents submission mail in the system.", "value":"SubmissionMail"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named EntityQueryKind -- properties: "kind":"description":"The kind of the entity query", "$ref":"#/components/schemas/EntityQueryKind" =>, type: undefined => "string", required: ["kind"] =>, enum: undefined => ["Expansion", "Insight"], x-ms-enum: undefined => "modelAsString":true, "name":"EntityQueryKind", "values":["value":"Expansion", "value":"Insight"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named ThreatIntelligenceResourceKind -- properties: "kind":"description":"The kind of the entity.", "$ref":"#/components/schemas/ThreatIntelligenceResourceKind" =>, type: undefined => "string", required: ["kind"] =>, enum: undefined => ["indicator"], x-ms-enum: undefined => "modelAsString":true, "name":"ThreatIntelligenceResourceKind", "values":["description":"Entity represents threat intelligence indicator in the system.", "value":"indicator"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named ThreatIntelligenceSortingCriteria -- properties: "itemKey":"description":"Column name", "$ref":"#/components/schemas/schemas:838", "sortOrder":"description":"Sorting order (ascending/descending/unsorted).", "$ref":"#/components/schemas/ThreatIntelligenceSortingCriteria" =>, type: undefined => "string", enum: undefined => ["unsorted", "ascending", "descending"], x-ms-enum: undefined => "modelAsString":true, "name":"ThreatIntelligenceSortingCriteria", "values":["value":"unsorted", "value":"ascending", "value":"descending"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Error: Plugin prechecker reported failure." |
| "readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"The schema 'MLBehaviorAnalyticsAlertRuleTemplate-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
No pipelines are associated with this pull request. |
|
Hi @hassanchawiche, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
BreakingChangeReviewRequired
and removed
CI-FixRequiredOnFailure
labels
|
Hi @hassanchawiche, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
NewApiVersionRequired reason: |
This was referenced Feb 16, 2021
This was referenced Feb 16, 2021
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details. |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @hassanchawiche your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @allenjzhang |
The link to WatchlistItems Swagger completeness : |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
allenjzhang
reviewed
Feb 19, 2021
| "WatchlistItems" | ||
| ], | ||
| "description": "Gets a watchlist, without its watchlist items.", | ||
| "operationId": "watchlistItems_Get", |
There was a problem hiding this comment.
nit: casing WatchlistItems_Get
| @@ -3908,7 +4008,7 @@ | |||
| "WatchlistItems" | |||
| ], | |||
| "description": "Delete a watchlist item.", | |||
| "operationId": "WatchlistItem_Delete", | |||
| "operationId": "watchlistItems_Delete", | |||
There was a problem hiding this comment.
nit: casing WatchlistItems_
| @@ -3957,7 +4057,7 @@ | |||
| "WatchlistItems" | |||
| ], | |||
| "description": "Creates or updates a watchlist item.", | |||
| "operationId": "WatchlistItem_CreateOrUpdate", | |||
| "operationId": "watchlistItems_CreateOrUpdate", | |||
There was a problem hiding this comment.
nit: casing WatchlistItems_
Just fixed all of them. |
allenjzhang
approved these changes
Feb 23, 2021
allenjzhang
added
Approved-BreakingChange
This was referenced Feb 23, 2021
Merged
hassanchawiche
deleted the
hc-wlitems-securityinsights-Microsoft.SecurityInsights-2019-01-01-preview
branch
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…version preview/2019-01-01-preview (Azure#12993) * Swagger correctness : add Get all Watchlist Items * Swagger correctness : add Get Watchlist Item by Id * Adjusted cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.