ADP: minor codegen changes #13165

aelij · 2021-02-25T07:21:32Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-02-25T07:21:35Z

Hi, @aelij Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-02-25T07:21:36Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2021-02-01-preview/adp.json <---> new: preview/2021-02-01-preview/adp.json

Rule	Message
`❌` 1036 - ConstraintChanged	The new version has a different 'minItems' value than the previous one. New: Microsoft.AutonomousDevelopmentPlatform/preview/2021-02-01-preview/adp.json#L866:9 Old: Microsoft.AutonomousDevelopmentPlatform/preview/2021-02-01-preview/adp.json#L866:9
`❌` 1036 - ConstraintChanged	The new version has a different 'minItems' value than the previous one. New: Microsoft.AutonomousDevelopmentPlatform/preview/2021-02-01-preview/adp.json#L866:9 Old: Microsoft.AutonomousDevelopmentPlatform/preview/2021-02-01-preview/adp.json#L866:9

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- adp/resource-manager/readme.md tag:package-2021-02-01-preview
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- adp/resource-manager/readme.md tag:package-2021-02-01-preview

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 5 Warnings warning [Detail]

The following tags are being changed in this PR

adp/resource-manager/readme.md#package-2021-02-01-preview

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"adp/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'AccountCheckNameAvailabilityParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"adp/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'CheckNameAvailabilityResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"adp/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"adp/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"adp/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-25T07:21:37Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 923f465. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/adp/resource-manager/readme.md

️✔️adp [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 923f465. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-adp [View full logs] [Release SDK Changes] Breaking Change Detected
- azure_mgmt_adp-0.1.0-py2.py3-none-any.whl
- azure-mgmt-adp-0.1.0.zip
```
info	[Changelog]   - Initial Release
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 923f465. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/adp/resource-manager/readme.md

️✔️adp [View full logs] [Release SDK Changes]

adp-0.0.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/adpManagementClient.js → ./dist/adp.js...
cmderr	[npmPack] created ./dist/adp.js in 224ms

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 923f465. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/adp/mgmt/2021-02-01-preview/adp [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️preview/adp/mgmt/2020-07-01-preview/adp [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 923f465. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-25 08:50:13 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-adp"
cmderr	[generate.py] 2021-02-25 08:50:13 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-25 08:50:13 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.17 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/adp/azure-resourcemanager-adp --java.namespace=com.azure.resourcemanager.adp   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/adp/resource-manager/readme.md
cmderr	[generate.py] 2021-02-25 08:50:51 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-25 08:50:51 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-25 08:50:51 INFO [POM][Skip] pom already has module azure-resourcemanager-adp
cmderr	[generate.py] 2021-02-25 08:50:51 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-25 08:50:51 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-25 08:50:51 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-adp [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-25 08:54:12 DEBUG Got artifact_id: azure-resourcemanager-adp
cmderr	[Inst] 2021-02-25 08:54:12 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-25 08:54:12 DEBUG Got artifact: azure-resourcemanager-adp-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-02-25 08:54:12 DEBUG Got artifact: azure-resourcemanager-adp-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-25 08:54:12 DEBUG Match jar package: azure-resourcemanager-adp-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-25 08:54:12 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13165/azure-sdk-for-java/azure-resourcemanager-adp/azure-resourcemanager-adp-1.0.0-beta.1.jar\" -o azure-resourcemanager-adp-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-adp -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-adp-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 923f465. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/adp/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'DataPoolProperties' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AccountCheckNameAvailabilityParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CheckNameAvailabilityResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Accounts/put/Put account
cmderr	[Autorest]     - name: /Accounts/get/Get account
cmderr	[Autorest]     - name: /Accounts/get/List accounts
cmderr	[Autorest]     - name: /Accounts/get/List accounts by resource group
cmderr	[Autorest]     - name: /Accounts/patch/Patch account
cmderr	[Autorest]     - name: /DataPools/put/Put Data Pool
cmderr	[Autorest]     - name: /DataPools/get/Get Data Pool
cmderr	[Autorest]     - name: /DataPools/get/List Data Pools
cmderr	[Autorest]     - name: /DataPools/patch/Patch Data Pool
cmderr	[Autorest]     - name: /DataPools/delete/Delete Data Pool
cmderr	[Autorest]     - name: /Accounts/delete/Delete account
cmderr	[Autorest] --------------------------------------------------------

️✔️adp [View full logs] [Release Azure CLI Changes]
- adp-0.1.0-py3-none-any.whl
- adp-0.1.0.zip

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-25T07:56:55Z

Hi @aelij, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

aelij · 2021-02-25T08:20:20Z

Note this service is in private preview.

* ADP: minor codegen changes * Fix * Flatten CLI only

ADP: minor codegen changes

11b1fcb

openapi-assignment-bot bot assigned qianwens Feb 25, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Feb 25, 2021

openapi-sdkautomation bot mentioned this pull request Feb 25, 2021

[AutoPR azure-resourcemanager-adp] ADP: minor codegen changes AzureSDKAutomation/azure-sdk-for-java#7627

Closed

Fix

7ec8f1b

akning-ms added the BreakingChangeReviewRequired label Feb 25, 2021

Flatten CLI only

81f6a43

qianwens added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 25, 2021

qianwens approved these changes Feb 25, 2021

View reviewed changes

qianwens merged commit 923f465 into Azure:master Feb 25, 2021

aelij deleted the adpremovemin branch February 25, 2021 08:45

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

ADP: minor codegen changes (Azure#13165)

d9f076a

* ADP: minor codegen changes * Fix * Flatten CLI only

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ADP: minor codegen changes #13165

ADP: minor codegen changes #13165

aelij commented Feb 25, 2021

openapi-workflow-bot bot commented Feb 25, 2021

openapi-pipeline-app bot commented Feb 25, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 25, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 25, 2021

aelij commented Feb 25, 2021

ADP: minor codegen changes #13165

ADP: minor codegen changes #13165

Conversation

aelij commented Feb 25, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 25, 2021

openapi-pipeline-app bot commented Feb 25, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 25, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 25, 2021

aelij commented Feb 25, 2021

openapi-pipeline-app bot commented Feb 25, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 25, 2021 •

edited

Loading