Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operations API - added missing property (s360 bug) #13229

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Operations API - added missing property (s360 bug) #13229

merged 3 commits into from
Mar 11, 2021

Conversation

dosegal
Copy link
Contributor

@dosegal dosegal commented Mar 2, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @dosegal Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 2, 2021

    Swagger Validation Report

    ️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]

    Rule Message
    1041 - AddedPropertyInResponse The new version has a new property 'origin' in response that was not found in the old version.
    New: Microsoft.SecurityInsights/preview/2021-03-01-preview/operations.json#L92:7
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/operations.json#L92:7
    1041 - AddedPropertyInResponse The new version has a new property 'origin' in response that was not found in the old version.
    New: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L2969:7
    Old: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L2969:7
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/735ca88b9ee795f67e2bbb18bc19af556c0f5f3c/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json",
    "details":"Error: Command failed: dotnet /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/oad@0.8.7/node_modules/@azure/oad/dlls/OpenApiDiff.dll -o /tmp/old-resolved.json -n /tmp/new-resolved.json
    Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.\n at AutoRest.Swagger.Model.ServiceDefinition.FindDiscriminator(String reference,
    IDictionary2 definitions) in D:\\a\\1\\s\\openapi-diff\\src\\modeler\\AutoRest.Swagger\\Model\\ServiceDefinition.cs:line 603\n at AutoRest.Swagger.Model.ServiceDefinition.FindDiscriminator(String reference,<br> IDictionary2 definitions) in D:\a\1\s\openapi-diff\src\modeler\AutoRest.Swagger\Model\ServiceDefinition.cs:line 610\n at AutoRest.Swagger.Model.ServiceDefinition.ReferenceTrackSchemas(ServiceDefinition service) in D:\a\1\s\openapi-diff\src\modeler\AutoRest.Swagger\Model\ServiceDefinition.cs:line 557\n at AutoRest.Swagger.Model.ServiceDefinition.Compare(ComparisonContext`1 context,
    ServiceDefinition previousD"
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌[Staging] SDK Track2 Validation: 8 Errors, 71 Warnings failed [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named AggregationsKind -- properties: "kind":"description":"The kind of the setting",
    "$ref":"#/components/schemas/AggregationsKind" =>,
    type: undefined => "string",
    required: ["kind"] =>,
    enum: undefined => ["CasesAggregation"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"AggregationsKind" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named AlertRuleKind -- properties: "kind":"description":"The kind of the alert rule",
    "$ref":"#/components/schemas/AlertRuleKind" =>,
    type: undefined => "string",
    required: ["kind"] =>,
    enum: undefined => ["Scheduled",
    "MicrosoftSecurityIncidentCreation",
    "Fusion",
    "MLBehaviorAnalytics",
    "ThreatIntelligence"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"AlertRuleKind",
    "values":["value":"Scheduled",
    "value":"MicrosoftSecurityIncidentCreation",
    "value":"Fusion",
    "value":"MLBehaviorAnalytics",
    "value":"ThreatIntelligence"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named DataConnectorKind -- properties: "kind":"description":"The kind of the data connector",
    "$ref":"#/components/schemas/DataConnectorKind" =>,
    type: undefined => "string",
    required: ["kind"] =>,
    enum: undefined => ["AzureActiveDirectory",
    "AzureSecurityCenter",
    "MicrosoftCloudAppSecurity",
    "ThreatIntelligence",
    "ThreatIntelligenceTaxii",
    "Office365",
    "OfficeATP",
    "AmazonWebServicesCloudTrail",
    "AzureAdvancedThreatProtection",
    "MicrosoftDefenderAdvancedThreatProtection",
    "Dynamics365",
    "MicrosoftThreatProtection",
    "MicrosoftThreatIntelligence"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"DataConnectorKind",
    "values":["value":"AzureActiveDirectory",
    "value":"AzureSecurityCenter",
    "value":"MicrosoftCloudAppSecurity",
    "value":"ThreatIntelligence",
    "value":"ThreatIntelligenceTaxii",
    "value":"Office365",
    "value":"OfficeATP",
    "value":"AmazonWebServicesCloudTrail",
    "value":"AzureAdvancedThreatProtection",
    "value":"MicrosoftDefenderAdvancedThreatProtection",
    "value":"Dynamics365",
    "value":"MicrosoftThreatProtection",
    "value":"MicrosoftThreatIntelligence"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named EntityKind -- properties: "kind":"description":"The kind of the entity.",
    "$ref":"#/components/schemas/EntityKind" =>,
    type: undefined => "string",
    required: ["kind"] =>,
    enum: undefined => ["Account",
    "Host",
    "File",
    "AzureResource",
    "CloudApplication",
    "DnsResolution",
    "FileHash",
    "Ip",
    "Malware",
    "Process",
    "RegistryKey",
    "RegistryValue",
    "SecurityGroup",
    "Url",
    "IoTDevice",
    "SecurityAlert",
    "Bookmark",
    "Mailbox",
    "MailCluster",
    "MailMessage",
    "SubmissionMail"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"EntityKind",
    "values":["description":"Entity represents account in the system.",
    "value":"Account",
    "description":"Entity represents host in the system.",
    "value":"Host",
    "description":"Entity represents file in the system.",
    "value":"File",
    "description":"Entity represents azure resource in the system.",
    "value":"AzureResource",
    "description":"Entity represents cloud application in the system.",
    "value":"CloudApplication",
    "description":"Entity represents dns resolution in the system.",
    "value":"DnsResolution",
    "description":"Entity represents file hash in the system.",
    "value":"FileHash",
    "description":"Entity represents ip in the system.",
    "value":"Ip",
    "description":"Entity represents malware in the system.",
    "value":"Malware",
    "description":"Entity represents process in the system.",
    "value":"Process",
    "description":"Entity represents registry key in the system.",
    "value":"RegistryKey",
    "description":"Entity represents registry value in the system.",
    "value":"RegistryValue",
    "description":"Entity represents security group in the system.",
    "value":"SecurityGroup",
    "description":"Entity represents url in the system.",
    "value":"Url",
    "description":"Entity represents IoT device in the system.",
    "value":"IoTDevice",
    "description":"Entity represents security alert in the system.",
    "value":"SecurityAlert",
    "description":"Entity represents bookmark in the system.",
    "value":"Bookmark",
    "description":"Entity represents mail cluster in the system.",
    "value":"MailCluster",
    "description":"Entity represents mail message in the system.",
    "value":"MailMessage",
    "description":"Entity represents mailbox in the system.",
    "value":"Mailbox",
    "description":"Entity represents submission mail in the system.",
    "value":"SubmissionMail"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named EntityQueryKind -- properties: "kind":"description":"The kind of the entity query",
    "$ref":"#/components/schemas/EntityQueryKind" =>,
    type: undefined => "string",
    required: ["kind"] =>,
    enum: undefined => ["Expansion",
    "Insight"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"EntityQueryKind",
    "values":["value":"Expansion",
    "value":"Insight"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named ThreatIntelligenceResourceKind -- properties: "kind":"description":"The kind of the entity.",
    "$ref":"#/components/schemas/ThreatIntelligenceResourceKind" =>,
    type: undefined => "string",
    required: ["kind"] =>,
    enum: undefined => ["indicator"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"ThreatIntelligenceResourceKind",
    "values":["description":"Entity represents threat intelligence indicator in the system.",
    "value":"indicator"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named ThreatIntelligenceSortingCriteria -- properties: "itemKey":"description":"Column name",
    "$ref":"#/components/schemas/schemas:853",
    "sortOrder":"description":"Sorting order (ascending/descending/unsorted).",
    "$ref":"#/components/schemas/ThreatIntelligenceSortingCriteria" =>,
    type: undefined => "string",
    enum: undefined => ["unsorted",
    "ascending",
    "descending"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"ThreatIntelligenceSortingCriteria",
    "values":["value":"unsorted",
    "value":"ascending",
    "value":"descending"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Error: Plugin prechecker reported failure."
    ⚠️ PreCheck/SchemaMissingType "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-composite-v1",
    "details":"The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-composite-v1",
    "details":"The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 2, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e6731e9. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️securityinsight/mgmt/v1.0/securityinsight [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `AlertRulesClient.DeleteActionPreparer` has been removed
      info	[Changelog] - Function `AlertRulesClient.CreateOrUpdateActionResponder` has been removed
      info	[Changelog] - Function `AlertRulesClient.CreateOrUpdateActionPreparer` has been removed
      info	[Changelog] - Function `AlertRulesClient.CreateOrUpdateAction` has been removed
      info	[Changelog] - Function `AlertRulesClient.GetActionResponder` has been removed
      info	[Changelog] - Function `AlertRulesClient.DeleteActionResponder` has been removed
      info	[Changelog] - Function `AlertRulesClient.CreateOrUpdateActionSender` has been removed
      info	[Changelog] - Function `AlertRulesClient.GetActionPreparer` has been removed
      info	[Changelog] - Function `AlertRulesClient.GetActionSender` has been removed
      info	[Changelog] - Function `AlertRulesClient.DeleteAction` has been removed
      info	[Changelog] - Function `AlertRulesClient.DeleteActionSender` has been removed
      info	[Changelog] - Function `AlertRulesClient.GetAction` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `ActionsClient.CreateOrUpdatePreparer(context.Context, string, string, string, string, ActionRequest) (*http.Request, error)`
      info	[Changelog] - New function `ActionsClient.DeleteResponder(*http.Response) (autorest.Response, error)`
      info	[Changelog] - New function `ActionsClient.DeletePreparer(context.Context, string, string, string, string) (*http.Request, error)`
      info	[Changelog] - New function `ActionsClient.GetPreparer(context.Context, string, string, string, string) (*http.Request, error)`
      info	[Changelog] - New function `ActionsClient.CreateOrUpdate(context.Context, string, string, string, string, ActionRequest) (ActionResponse, error)`
      info	[Changelog] - New function `ActionsClient.DeleteSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `ActionsClient.Get(context.Context, string, string, string, string) (ActionResponse, error)`
      info	[Changelog] - New function `ActionsClient.Delete(context.Context, string, string, string, string) (autorest.Response, error)`
      info	[Changelog] - New function `ActionsClient.GetResponder(*http.Response) (ActionResponse, error)`
      info	[Changelog] - New function `ActionsClient.GetSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `ActionsClient.CreateOrUpdateSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `ActionsClient.CreateOrUpdateResponder(*http.Response) (ActionResponse, error)`
      info	[Changelog] - New struct `OfficeDataConnectorDataTypesTeams`
      info	[Changelog] - New field `EventTime` in struct `BookmarkProperties`
      info	[Changelog] - New field `QueryStartTime` in struct `BookmarkProperties`
      info	[Changelog] - New field `QueryEndTime` in struct `BookmarkProperties`
      info	[Changelog] - New field `TipLookbackPeriod` in struct `TIDataConnectorProperties`
      info	[Changelog] - New field `Teams` in struct `OfficeDataConnectorDataTypes`
      info	[Changelog] - New field `Origin` in struct `Operation`
      info	[Changelog]
      info	[Changelog] Total 12 breaking change(s), 18 additive change(s).
      info	[Changelog]
    • ️✔️preview/securityinsight/mgmt/2019-01-01-preview/securityinsight [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 60 items here, please refer to log for details.
      info	[Changelog] - New function `MSTICheckRequirements.AsMCASCheckRequirements() (*MCASCheckRequirements, bool)`
      info	[Changelog] - New function `PossiblePollingFrequencyValues() []PollingFrequency`
      info	[Changelog] - New function `OfficeATPCheckRequirements.AsMSTICheckRequirements() (*MSTICheckRequirements, bool)`
      info	[Changelog] - New function `AwsCloudTrailCheckRequirements.AsMtpCheckRequirements() (*MtpCheckRequirements, bool)`
      info	[Changelog] - New function `MSTIDataConnector.AsOfficeDataConnector() (*OfficeDataConnector, bool)`
      info	[Changelog] - New function `ScheduledAlertRule.AsThreatIntelligenceAlertRule() (*ThreatIntelligenceAlertRule, bool)`
      info	[Changelog] - New function `TiTaxiiDataConnector.AsMSTIDataConnector() (*MSTIDataConnector, bool)`
      info	[Changelog] - New struct `ConnectedEntity`
      info	[Changelog] - New struct `EntityEdges`
      info	[Changelog] - New struct `IPSyncer`
      info	[Changelog] - New struct `IPSyncerSettingsProperties`
      info	[Changelog] - New struct `MSTICheckRequirements`
      info	[Changelog] - New struct `MSTICheckRequirementsProperties`
      info	[Changelog] - New struct `MSTIDataConnector`
      info	[Changelog] - New struct `MSTIDataConnectorDataTypes`
      info	[Changelog] - New struct `MSTIDataConnectorDataTypesBingSafetyPhishingURL`
      info	[Changelog] - New struct `MSTIDataConnectorDataTypesMicrosoftEmergingThreatFeed`
      info	[Changelog] - New struct `MSTIDataConnectorProperties`
      info	[Changelog] - New struct `MTPCheckRequirementsProperties`
      info	[Changelog] - New struct `MTPDataConnector`
      info	[Changelog] - New struct `MTPDataConnectorDataTypes`
      info	[Changelog] - New struct `MTPDataConnectorDataTypesIncidents`
      info	[Changelog] - New struct `MTPDataConnectorProperties`
      info	[Changelog] - New struct `MtpCheckRequirements`
      info	[Changelog] - New struct `ThreatIntelligenceAlertRule`
      info	[Changelog] - New struct `ThreatIntelligenceAlertRuleProperties`
      info	[Changelog] - New struct `ThreatIntelligenceAlertRuleTemplate`
      info	[Changelog] - New struct `ThreatIntelligenceAlertRuleTemplateProperties`
      info	[Changelog] - New struct `ThreatIntelligenceExternalReference`
      info	[Changelog] - New struct `ThreatIntelligenceParsedPattern`
      info	[Changelog] - New struct `ThreatIntelligenceParsedPatternTypeValue`
      info	[Changelog] - New struct `WatchlistItemList`
      info	[Changelog] - New struct `WatchlistItemListIterator`
      info	[Changelog] - New struct `WatchlistItemListPage`
      info	[Changelog] - New struct `WatchlistItemsClient`
      info	[Changelog] - New field `Description` in struct `SecurityAlertTimelineItem`
      info	[Changelog] - New field `Edges` in struct `BookmarkExpandResponseValue`
      info	[Changelog] - New field `ConsentID` in struct `OfficeConsentProperties`
      info	[Changelog] - New field `SubmissionDate` in struct `SubmissionMailEntityProperties`
      info	[Changelog] - New field `SubmissionID` in struct `SubmissionMailEntityProperties`
      info	[Changelog] - New field `Submitter` in struct `SubmissionMailEntityProperties`
      info	[Changelog] - New field `EventTime` in struct `BookmarkProperties`
      info	[Changelog] - New field `QueryStartTime` in struct `BookmarkProperties`
      info	[Changelog] - New field `QueryEndTime` in struct `BookmarkProperties`
      info	[Changelog] - New field `ParsedPattern` in struct `ThreatIntelligenceIndicatorProperties`
      info	[Changelog] - New field `PatternVersion` in struct `ThreatIntelligenceIndicatorProperties`
      info	[Changelog] - New field `Extensions` in struct `ThreatIntelligenceIndicatorProperties`
      info	[Changelog] - New field `Language` in struct `ThreatIntelligenceIndicatorProperties`
      info	[Changelog] - New field `ObjectMarkingRefs` in struct `ThreatIntelligenceIndicatorProperties`
      info	[Changelog] - New field `ExternalLastUpdatedTimeUtc` in struct `ThreatIntelligenceIndicatorProperties`
      info	[Changelog] - New field `Defanged` in struct `ThreatIntelligenceIndicatorProperties`
      info	[Changelog] - New field `TaxiiLookbackPeriod` in struct `TiTaxiiDataConnectorProperties`
      info	[Changelog] - New field `PollingFrequency` in struct `TiTaxiiDataConnectorProperties`
      info	[Changelog] - New field `Edges` in struct `EntityExpandResponseValue`
      info	[Changelog] - New field `Origin` in struct `Operation`
      info	[Changelog] - New field `TipLookbackPeriod` in struct `TIDataConnectorProperties`
      info	[Changelog] - New field `ReceiveDate` in struct `MailMessageEntityProperties`
      info	[Changelog]
      info	[Changelog] Total 45 breaking change(s), 285 additive change(s).
      info	[Changelog]
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e6731e9. Azure CLI Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
      cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-teams' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
      cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
      cmderr	[Autorest] --------------------------------------------------------
      cmderr	[Autorest]   test-scenario:
      cmderr	[Autorest]     - name: /Actions/put/Creates or updates an action of alert rule.
      cmderr	[Autorest]     - name: /Actions/get/Get all actions of alert rule.
      cmderr	[Autorest]     - name: /Actions/get/Get an action of alert rule.
      cmderr	[Autorest]     - name: /Actions/delete/Delete an action of alert rule.
      cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
      cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
      cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
      cmderr	[Autorest]     - name: /AlertRules/get/Get a Fusion alert rule.
      cmderr	[Autorest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
      cmderr	[Autorest]     - name: /AlertRules/get/Get a Scheduled alert rule.
      cmderr	[Autorest]     - name: /AlertRules/get/Get all alert rules.
      cmderr	[Autorest]     - name: /AlertRules/delete/Delete an alert rule.
      cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
      cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
      cmderr	[Autorest]     - name: /Bookmarks/put/Creates or updates a bookmark.
      cmderr	[Autorest]     - name: /Bookmarks/get/Get a bookmark.
      cmderr	[Autorest]     - name: /Bookmarks/get/Get all bookmarks.
      cmderr	[Autorest]     - name: /Bookmarks/delete/Delete a bookmark.
      cmderr	[Autorest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
      cmderr	[Autorest]     - name: /DataConnectors/put/Creates or updates an Threat Intelligence Platform data connector.
      cmderr	[Autorest]     - name: /DataConnectors/get/Get a ASC data connector.
      cmderr	[Autorest]     - name: /DataConnectors/get/Get a MCAS data connector.
      cmderr	[Autorest]     - name: /DataConnectors/get/Get a MDATP data connector
      cmderr	[Autorest]     - name: /DataConnectors/get/Get a TI data connector.
      cmderr	[Autorest]     - name: /DataConnectors/get/Get all data connectors.
      cmderr	[Autorest]     - name: /DataConnectors/get/Get an AAD data connector.
      cmderr	[Autorest]     - name: /DataConnectors/get/Get an AATP data connector.
      cmderr	[Autorest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
      cmderr	[Autorest]     - name: /DataConnectors/get/Get an Office365 data connector.
      cmderr	[Autorest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
      cmderr	[Autorest]     - name: /IncidentComments/put/Creates an incident comment.
      cmderr	[Autorest]     - name: /IncidentComments/get/Get all incident comments.
      cmderr	[Autorest]     - name: /IncidentComments/get/Get an incident comment.
      cmderr	[Autorest]     - name: /Incidents/put/Creates or updates an incident.
      cmderr	[Autorest]     - name: /Incidents/get/Get all incidents.
      cmderr	[Autorest]     - name: /Incidents/get/Get an incident.
      cmderr	[Autorest]     - name: /Incidents/delete/Delete an incident.
      cmderr	[Autorest] --------------------------------------------------------
    • ️✔️securityinsight [View full logs]  [Release Azure CLI Changes]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e6731e9. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
    • ️✔️@azure/arm-securityinsight [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/securityInsights.js → ./dist/arm-securityinsight.js...
      cmderr	[npmPack] created ./dist/arm-securityinsight.js in 462ms
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e6731e9. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.SecurityInsights [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e6731e9. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-securityinsight [View full logs]  [Release SDK Changes]
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e6731e9. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
    • ️✔️securityinsights [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager] npm WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @dosegal
    Copy link
    Contributor Author

    dosegal commented Mar 9, 2021

    @qianwens can you please approve?

    @qianwens qianwens added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 11, 2021
    @qianwens qianwens merged commit e6731e9 into Azure:master Mar 11, 2021
    MirzaSikander pushed a commit to MirzaSikander/azure-rest-api-specs that referenced this pull request Mar 22, 2021
    * added missing property
    
    * added missing property
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * added missing property
    
    * added missing property
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go FixS360
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants