-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IotHub] Adding user assigned capability for customer provided endpoints [2021-03-03-preview] #13243
Conversation
Hi, @nimengan Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
"readme":"iothub/resource-manager/readme.md", "tag":"package-preview-2021-03", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"iothub/resource-manager/readme.md", "tag":"package-preview-2021-03", "details":"The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"iothub/resource-manager/readme.md", "tag":"package-preview-2021-03", "details":"The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"iothub/resource-manager/readme.md", "tag":"package-preview-2021-03", "details":"The schema 'TagsResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"iothub/resource-manager/readme.md", "tag":"package-preview-2021-03", "details":"The schema 'TagsResource-tags' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"iothub/resource-manager/readme.md", "tag":"package-preview-2021-03", "details":"The schema 'RoutingTwin-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"iothub/resource-manager/readme.md", "tag":"package-preview-2021-03", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
Hi, @nimengan your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@filizt addressed you comments. could please approve from your side ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing off from ARM side.
@chunyu3 could you please merge this pull request ? |
…nts [2021-03-03-preview] (Azure#13243) * Adds base for updating Microsoft.Devices from version preview/2021-02-01-preview to version 2021-03-03-preview * Updates readme * Updates API version in new specs and examples * Adding identity property for customer provided endpoints * Adding disableLocalAuth property to IothubProperties. * Removing disableLocalAuth prop and adding a example * Prettier fix
…nts [2021-03-03-preview] (Azure#13243) * Adds base for updating Microsoft.Devices from version preview/2021-02-01-preview to version 2021-03-03-preview * Updates readme * Updates API version in new specs and examples * Adding identity property for customer provided endpoints * Adding disableLocalAuth property to IothubProperties. * Removing disableLocalAuth prop and adding a example * Prettier fix
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.