Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api tos license contact parameter schema #13252

Conversation

VitaliyKurokhtin
Copy link
Contributor

@VitaliyKurokhtin VitaliyKurokhtin commented Mar 3, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@solankisamir
Copy link
Member

@josefree can you look into this PR and merge if things look good?

@mikebudzynski
Copy link
Contributor

@josefree, can we have this PR merged to our own branch?

@akning-ms akning-ms merged commit ef4b31a into Azure:Microsoft.ApiManagement-2021-01-01-preview Mar 10, 2021
zhenglaizhang pushed a commit that referenced this pull request Mar 12, 2021
* Adds base for updating Microsoft.ApiManagement from version stable/2020-12-01 to version 2021-01-01-preview

* Updates readme

* Updates API version in new specs and examples

* Bring your Own IP support for vnet injection on API Management (#13102)

* pip support for vnet injection

* fix example

* fix example

* New API and parameter properties added (#13252)

* Changes for websocket entities (#11912)

* add api type and protocol for 2021

* example

* modelAsString

* pretty check

* reference example

* rename file

* Fix enum mismatch

Co-authored-by: Samir Solanki <samirsolanki@outlook.com>

* free tls changes and updated examples (#13347)

* free tls changes and updated examples

* renames

Co-authored-by: VitaliyKurokhtin <vitaliik@microsoft.com>
Co-authored-by: JJ <jijohn@microsoft.com>
MirzaSikander pushed a commit to MirzaSikander/azure-rest-api-specs that referenced this pull request Mar 22, 2021
* Adds base for updating Microsoft.ApiManagement from version stable/2020-12-01 to version 2021-01-01-preview

* Updates readme

* Updates API version in new specs and examples

* Bring your Own IP support for vnet injection on API Management (Azure#13102)

* pip support for vnet injection

* fix example

* fix example

* New API and parameter properties added (Azure#13252)

* Changes for websocket entities (Azure#11912)

* add api type and protocol for 2021

* example

* modelAsString

* pretty check

* reference example

* rename file

* Fix enum mismatch

Co-authored-by: Samir Solanki <samirsolanki@outlook.com>

* free tls changes and updated examples (Azure#13347)

* free tls changes and updated examples

* renames

Co-authored-by: VitaliyKurokhtin <vitaliik@microsoft.com>
Co-authored-by: JJ <jijohn@microsoft.com>
mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
* Adds base for updating Microsoft.ApiManagement from version stable/2020-12-01 to version 2021-01-01-preview

* Updates readme

* Updates API version in new specs and examples

* Bring your Own IP support for vnet injection on API Management (Azure#13102)

* pip support for vnet injection

* fix example

* fix example

* New API and parameter properties added (Azure#13252)

* Changes for websocket entities (Azure#11912)

* add api type and protocol for 2021

* example

* modelAsString

* pretty check

* reference example

* rename file

* Fix enum mismatch

Co-authored-by: Samir Solanki <samirsolanki@outlook.com>

* free tls changes and updated examples (Azure#13347)

* free tls changes and updated examples

* renames

Co-authored-by: VitaliyKurokhtin <vitaliik@microsoft.com>
Co-authored-by: JJ <jijohn@microsoft.com>
@VitaliyKurokhtin VitaliyKurokhtin deleted the api-tos-license-contact-parameter-schema branch September 19, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants