-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api tos license contact parameter schema #13252
Merged
akning-ms
merged 1 commit into
Azure:Microsoft.ApiManagement-2021-01-01-preview
from
VitaliyKurokhtin:api-tos-license-contact-parameter-schema
Mar 10, 2021
Merged
Api tos license contact parameter schema #13252
akning-ms
merged 1 commit into
Azure:Microsoft.ApiManagement-2021-01-01-preview
from
VitaliyKurokhtin:api-tos-license-contact-parameter-schema
Mar 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyKurokhtin
requested review from
ahamad-MS,
AlexGhiondea,
ArcturusZhang,
arv100kri,
bleroy,
blueww,
brjohnstmsft,
ChenTanyi,
dkulkarni-ms,
grizzlytheodore,
haagha,
heaths,
hectorhdzg,
hyonholee,
JasonYang-MSFT,
jlichwa,
jsntcy,
Kishp01,
kjeur,
lmazuel,
lzchen,
madewithsmiles,
MehaKaushik,
MikhailTryakhov,
Mohit-Chakraborty,
MS-syh2qs,
msyyc,
naveedaz,
ofirmanor and
orieldar
as code owners
March 3, 2021 04:09
solankisamir
removed request for
MehaKaushik,
ahamad-MS,
ChenTanyi,
jsntcy,
JasonYang-MSFT,
v-Ajnava,
orieldar,
samedder,
Kishp01,
kjeur,
hectorhdzg,
madewithsmiles,
jlichwa,
qiaozha,
Sandido,
haagha,
MS-syh2qs,
dkulkarni-ms and
msyyc
March 6, 2021 00:36
@josefree can you look into this PR and merge if things look good? |
@josefree, can we have this PR merged to our own branch? |
26 tasks
zhenglaizhang
pushed a commit
that referenced
this pull request
Mar 12, 2021
* Adds base for updating Microsoft.ApiManagement from version stable/2020-12-01 to version 2021-01-01-preview * Updates readme * Updates API version in new specs and examples * Bring your Own IP support for vnet injection on API Management (#13102) * pip support for vnet injection * fix example * fix example * New API and parameter properties added (#13252) * Changes for websocket entities (#11912) * add api type and protocol for 2021 * example * modelAsString * pretty check * reference example * rename file * Fix enum mismatch Co-authored-by: Samir Solanki <samirsolanki@outlook.com> * free tls changes and updated examples (#13347) * free tls changes and updated examples * renames Co-authored-by: VitaliyKurokhtin <vitaliik@microsoft.com> Co-authored-by: JJ <jijohn@microsoft.com>
MirzaSikander
pushed a commit
to MirzaSikander/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2021
* Adds base for updating Microsoft.ApiManagement from version stable/2020-12-01 to version 2021-01-01-preview * Updates readme * Updates API version in new specs and examples * Bring your Own IP support for vnet injection on API Management (Azure#13102) * pip support for vnet injection * fix example * fix example * New API and parameter properties added (Azure#13252) * Changes for websocket entities (Azure#11912) * add api type and protocol for 2021 * example * modelAsString * pretty check * reference example * rename file * Fix enum mismatch Co-authored-by: Samir Solanki <samirsolanki@outlook.com> * free tls changes and updated examples (Azure#13347) * free tls changes and updated examples * renames Co-authored-by: VitaliyKurokhtin <vitaliik@microsoft.com> Co-authored-by: JJ <jijohn@microsoft.com>
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Adds base for updating Microsoft.ApiManagement from version stable/2020-12-01 to version 2021-01-01-preview * Updates readme * Updates API version in new specs and examples * Bring your Own IP support for vnet injection on API Management (Azure#13102) * pip support for vnet injection * fix example * fix example * New API and parameter properties added (Azure#13252) * Changes for websocket entities (Azure#11912) * add api type and protocol for 2021 * example * modelAsString * pretty check * reference example * rename file * Fix enum mismatch Co-authored-by: Samir Solanki <samirsolanki@outlook.com> * free tls changes and updated examples (Azure#13347) * free tls changes and updated examples * renames Co-authored-by: VitaliyKurokhtin <vitaliik@microsoft.com> Co-authored-by: JJ <jijohn@microsoft.com>
VitaliyKurokhtin
deleted the
api-tos-license-contact-parameter-schema
branch
September 19, 2022 16:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.