[text analytics] Updated HealthcareAssertion enum values to be camel cased #13361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhahn
requested review from
deyaaeldeen,
maririos,
suhas92,
iscai-msft and
mssfang
|
Hi, @abhahn Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is adding enum value(s) 'hypothetical, conditional' from the old version. New: TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json#L1870:9 Old: TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json#L1870:9 |
|
The new version is adding enum value(s) 'positive, positivePossible, neutralPossible, negativePossible, negative' from the old version. New: TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json#L1882:9 Old: TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json#L1882:9 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Enum does not match case for: Positive Url: TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json#L1882 JsonUrl: preview/v3.1-preview.4/examples/SuccessfulHealthStatusRequest.json |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"cognitiveservices/data-plane/TextAnalytics/readme.md", "tag":"release_3_1_preview.4", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @abhahn, Your PR has some issues. Please fix the CI sequentially by following the order of
|
deyaaeldeen
approved these changes
Mar 10, 2021
mssfang
approved these changes
Mar 10, 2021
iscai-msft
approved these changes
Mar 10, 2021
ghost
pushed a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Mar 11, 2021
This change is needed to match the current service's response. The swagger is being updated in Azure/azure-rest-api-specs#13361.
tjprescott
approved these changes
Mar 12, 2021
|
@lmazuel can you merge this? Confirmed that this "breaking change" is a bug fix in the Swagger, so it's really a "fixing change" :) |
MirzaSikander
pushed a commit
to MirzaSikander/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2021
…cased (Azure#13361) * Updated HealthcareAssertion enum values to be camel cased * Updated an example Co-authored-by: Abby Hartman <abhahn@microsoft.com>
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
…14246) This change is needed to match the current service's response. The swagger is being updated in Azure/azure-rest-api-specs#13361.
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…cased (Azure#13361) * Updated HealthcareAssertion enum values to be camel cased * Updated an example Co-authored-by: Abby Hartman <abhahn@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.