[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2020-04-01-preview #13389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jiacheng-L Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version has a new property 'systemData' in response that was not found in the old version. New: Microsoft.KeyVault/preview/2020-04-01-preview/keyvault.json#L1508:7 Old: Microsoft.KeyVault/preview/2020-04-01-preview/keyvault.json#L1508:7 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 54 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04-full", "details":"The schema 'Sku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04-full", "details":"The schema 'AccessPolicyEntry' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04-full", "details":"The schema 'Permissions' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04-full", "details":"The schema 'VaultProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04-full", "details":"The schema 'VaultPatchProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04-full", "details":"The schema 'VaultAccessPolicyProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04-full", "details":"The schema 'DeletedVaultProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04-full", "details":"The schema 'VaultCreateOrUpdateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04-full", "details":"The schema 'VaultPatchParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04-full", "details":"The schema 'VaultAccessPolicyParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
Hi @jiacheng-L, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
jiacheng-L
requested review from
heaths,
jlichwa and
RandalliLama
as code owners
heaths
requested changes
Mar 11, 2021
| "Key" | ||
| ], | ||
| "x-ms-enum": { | ||
| "name": "createdByType", |
There was a problem hiding this comment.
This will cause conflicts during generation. Instead, I recommend refactoring out this enum as a separate definition and #ref it in both places (here and createdByType).
There was a problem hiding this comment.
Sorry, there is a copy/paste error. I have refactored out the identity type.
heaths
approved these changes
Mar 15, 2021
|
Hi @jiacheng-L, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
JeffreyRichter
approved these changes
Mar 22, 2021
JeffreyRichter
added
the
Approved-BreakingChange
ArcturusZhang
approved these changes
Mar 26, 2021
This was referenced Mar 26, 2021
akning-ms
added a commit
that referenced
this pull request
Apr 19, 2021
…13987) * Update ChangeAnalysis latest tag to package-2021-04-01 (#13507) * Add the march public preview API version of extended location (#13446) * Add the march public preview API version of extended location * Tweak: remove references to iot * Address comments from Phoenix by removing 500 references and adding back the default version tag * Revert privatepreview changes * Tweak: remove "500" from the swagger itself * Tweak: remove dash from readme * fix python pipeline * Tweak: run prettier against the repo folder * Tweak: remove 404 from customlocations.json and CustomLocationsGet.json * Tweak: csharp README sdk output folder path to fix downstream generation issue Co-authored-by: 00Kai0 <sunkaihuisos@gmail.com> * Cumulative changes to DeviceUpdate (#13457) * Update readme.go.md * Update deviceupdate.json * Update deviceupdate.json * Update deviceupdate.json * [DataFactory] Add privateEndpointConnection apis (#13249) * [DataFactory] Add privateEndpointConnection apis * resolve some style errors * resolve * resolve 1 * commit * resolve 1 comment * Update PIM examples for documentation (#13395) * PIM API Specs * update readme * Update * Update readme * operation id fix * name fix * Name changes * fix * Fix * Changes based on docs generated * Scope fix in example * Updates for documentation * Change operation name * Update examples * Add expanded properties * Fix formatting * Fixes * Fix * fixes * Update the policy specs * Fix the policy objects and pell checks * fix the checks * fix the property * fix syntax * Prettier Co-authored-by: Aman Swaika <amansw@microsoft.com> Co-authored-by: Gaurav Mishra (IDENTITY) <gamish@microsoft.com> * [Hub Generated] Review request for Microsoft.Elastic to add version preview/2020-07-01-preview (#13258) * New Readme Config File * New Go Language Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New AzureResourceSchema Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Addings examples and swagger from prod * removing autogenerated files * added kibana custom word * moving swagger files one directory up * moving custom words to swagger folder * moving custom words to readme directory * removed custom words * changed double preview to preview * added systemdata as part of the spec * fixing prettyness * added systemData for tagrules * moving system data to a level down * added a new type of response definition * changed theget type of montor * reverting swagger to without systemdata * added systemdata in properties * added system data elasticmonitor resource and tags * Added 2 new properties to operation result * fixing go sdk generation * added no name space for track python * Using confluent python.md * dataDog track1 config del (#13512) * DomainServices: Add 2021-03-01 api-version with 2 new properties (#13459) * Add files via upload * Add files via upload Adding new 2021-03-01 api-version * Add files via upload * Add files via upload * Add files via upload * Adding Communication Chat API preview5 (#13464) * Adding chat API preview5 * Fix style issue + adding `Idempotency` to custom-words.txt dictionary * ResourceGuard Proxy related changes for MFA MUA (#13477) * MFA MUA V1 swagger changes * Copying json from 2021-02-01 to 2021-02-01-preview * Moving these details under Preview folder * Fixing Avocado errors * updated version in example json files * ResourceGuardProxy related changes * Resolved spell check errors Co-authored-by: Madhumanti Dey <madhude@microsoft.com> * typo: Semantic and Model Violation Reference file (#13533) * update name for Java SDK (#13466) * reservation readme t2 config (#13516) * [Hub Generated] Review request for Microsoft.DocumentDB to add version preview/2021-04-01-preview (#13357) * Adds base for updating Microsoft.DocumentDB from version preview/2021-03-01-preview to version 2021-04-01-preview * Updates readme * Updates API version in new specs and examples * Adding new API for fetching backup information(such as latest restorable timestmap) for a resource. Also, adding startTime,endTime to restorable.json * Adding new API for fetching backup information(such as latest restorable timestmap) for a resource. Also, adding startTime,endTime to restorable.json * Adding new API for fetching backup information(such as latest restorable timestmap) for a resource. Also, adding startTime,endTime to restorable.json * Update readme.python.md(Datadog) (#13540) * Update readme.python.md * Update readme.python.md * Update CODEOWNERS (#13544) * fix: Resort and dudupe dictionary from bad merge (#13536) * [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (#13194) * Adding tagValue and tagKey to ReportConfigFilter * remove the addition of tagValue * Adding TagValue in the config filter * make filter name property nullable * update the disk.json version for the 2021-03-01 (#13461) Co-authored-by: Meet Shah <meeshah@microsoft.com> * Threis/cv 32 ga (#13297) * Create Base CV 3.2 config * Add language and start updating examples * Add model version, corrct other smaller elements * Tweak language code formatting and description * Correct Read available resource version * Attempt to fix failing build * Ensure parity with ComputerVisionErrors * Add model version for vision * Correct ModelVersion to model-version * Fix JSON formatting error * Update query param name for model version to "model-version" * Remove unused error codes from OCR's supported list * Fix failing tests on OCR operation * Split vision and ocr Model-Version into to separate elements * Fix case sensitivity issue * Add parent "error" object, remove requestId from ComputerVisionError object * Fix the number of returned captions (maxCandidate is set to 1 so API should return only one caption) Co-authored-by: bob <bob@bob.com> Co-authored-by: Ryogo Kanatani <ryogok@microsoft.com> * [DNC] Stable release 03_15_21 (#13545) * stable version release * updated to stable * fixed readme * updated output folder * updated output folder * corrected output dir path * fixed path * added java readme * update privateLinkServiceNetworkPolicies and (#13429) privateEndpointNetworkPolicies * Revert "[Hub Generated] Review request for Microsoft.DocumentDB to add version preview/2021-04-01-preview (#13357)" (#13541) This reverts commit e1b647a015a65d9f6b3b4b7ebe04eb7e04469647. * [Monitor] Fix invalid tags (#13469) * [Monitor] Fix invalid tags * Update readme.md * Update readme.python.md * Update readme.go.md * Remove readonly for keyOps and keySize (#13522) * [Management Plane][Azure Search] Adding new API version 2021-01-04. (#13355) * [Management Plane][Azure Search] Adding new API version for exposing Encryption with CMK. * Fixing prittier and model validation errors * Fixing errors raised by lintdiff and ModelValidations * Update readme for track2 settings. (#13552) * Add AutomationRules api (#13421) * Add automation rules api * Move incident enums to common * fix schema * more fixes * update examples * update examples * remove automation rules OData support * fix typo in LA provider name * Update swagger * Update examples * prepare for PR * fix typos and prettier * fix typos and prettier * fix lint errors * fix lint errors * fix lint errors * fix lint errors * fix lint errors * fix linting error * Remove multiple allOf statements * Remove multiple allOf statements * fixing examples in ARM spec (#13458) * fixing examples in ARM spec * fixing resource ids in the examples * Add expandRegistrationDefintion parameter (#13583) * delete package version (#13577) * delete package version * Update readme.python.md Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> * [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#13327) * add parameter locale to Notification * fix locale description * Add locale parameter to an example * Revert "Add locale parameter to an example" This reverts commit deafd36d79bac0c37e64f8b7751d12b0601fd219. * Fix locale description * Add locale to CreateOrUpdate example * Change CultureCode declaration * Fix culture codes * Revert "Change CultureCode declaration" This reverts commit 3e9b95e0cd40fc59bcc7a6857f887657d25f91fb. * Add description to CultureCode enum * Revert "Add description to CultureCode enum" This reverts commit 9ac5d73d6893ac6e1ba1ebfc3baf5867614e3ed5. * Microsoft.DataProtection Swagger GA stable version (#13542) * manual changes for swagger * changes for long-running operations * changes for validate for backup and restore * removing 204 from operationResults * changes for a monitoring * adding format * removing date-time from duration * changing to readonly * changes for listRPs * fixes swagger * reverting readonly for scheduleTimes * fixes for checkgates * prettier fixes * cahnges for friendlyname checks * fixing gates * removing tracking-via * model validation fixes * powershell changes * adding stable version * changes for PatchResourceRequestInput * change for req fields * changes for description * changes * Updated swagger json for item level restore target info objects * Fixed spelling errors * Added missing required properties * removed auth credentials property * prettier fixes * Prettier fix * pr comments fixes * fixing readme * changes for go readme Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> Co-authored-by: FAREAST\zakinkh <zakinkh@microsoft.com> * extendedlocation add multiapi tag (#13593) Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> * Update comment.yml (#13572) * Revert "[Management Plane][Azure Search] Adding new API version 2021-01-04. (#13355)" (#13595) This reverts commit 5c2185adda8aa915a391ae182c1f02cc587f4f79. * TimeSeriesInsingts t2 config (#13548) * TimeSeriesInsingts t2 config * timeseriesinsights readme.python change * powerbidedicated track2 config (#13539) * add repo python-track2 * delete package version * delete clear-output-folder Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> * Add apurvans as SQL code owner (#13582) * add tag in python.md (#13601) Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> * [NetAppFiles] Update BackupType (#13520) * Update BackupType * Prettier * Update backup status operation * Fix operation id * Revert operation change Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com> * remove externalDocs with empty url (#13596) * Fix CSharp output folder for Azure Health Bot SDK. (#13499) * [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#13402) * Completenese for Credits,Events and Lots * Completenese for Events * Completenese for Events * Prettier updates applied. * Model Validation fix * Correctly document minimumTlsVersion - which is create-only mutable (#12795) * Correctly document minimumTlsVersion - which is really only configurable at create time. * Style fix for empty object * cdn track2 configure (#13592) * cdn track2 configure * cdn only track2 config * fix Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> Co-authored-by: 00Kai0 <sunkaihuisos@gmail.com> * add go sdk config (#13620) * Add storage feb21 (#13550) * Add storage Feb21 duplicated from Jan21 Add storage Feb21 duplicated from Jan21 * Add Key&Sas Policy on Feb21 Add Key&Sas Policy on Feb21 * fixed swagger format fixed swagger format * remove duplicated comma remove duplicated comma * Update storage.json fix prettier check * Add examples for key&sas policy Add examples for key&sas policy * update readme * Update CSharp&Java readme Update CSharp&Java readme Co-authored-by: Zunli Hu <zuh@microsoft.com> * [Cosmos DB] Introduce new api version 2021-03-15 (#13253) * Introduce new api version 2021-03-15 * fix Co-authored-by: Xujin Zhang <xujzhang@microsoft.com> * add packageversion (#13625) Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> * Zy privatedns t2 (#13574) * wrong opr * private track2 configure * delete unexpected modification * reeadme.python version del * privatedns clear output folder del * privatedns readme.python package-version add * Zed timeseriesinsights (#13628) * wrong opr * delete unexpected modification * readme.python package version add * Adding AADProperties query object for CRR (#13447) * Adding AADProperties query object for CRR * Update * Update * Fixing spell check * Update * Update * typo: Azuer Operatoins -> Azure Operations (#13313) * t2-powerbidedicated-2021-03-25 (#13624) * add repo python-track2 * delete package version * delete clear-output-folder * add packageversion Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> * Adding ACS Chat GA Version (#13594) * Adding ACS Chat GA Version * running prettier and fixing header casing * Fixing package name * Removing obsolete header * typo: identifer -> identifier (#13640) * add package version (#13659) Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> * use DelegatedNetwork as service name for java (#13660) * frontdoor readme t2 config (#13575) * wrong opr * delete unexpected modification * frontdoor readme t2 config * readme.python version del * frontdoor clear-output-folder del * forntdoor readme.pythong package-version add * operationalinsights t2 configure (#13630) Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> * new api changes (#1) (#13612) * new api changes * referer url change * changeanalysis only track2 configure (#13627) * changeanalysis only track2 configure * Update readme.python.md * path modification * remodify Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> * fix python track2 generation (#13666) * [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2020-04-01-preview (#13389) * Add systemData to keyVault Vault property * Update to our own systemData definition * Fix copy/paste error and refactor out the identity type * chore: remove name from title (#13642) * [Hub Generated] Review request for Microsoft.AzureActiveDirectory to add version preview/2019-01-01-preview (#13621) * adding australia to possible resources and cleaning up operationslist.json * trying to fix python issue * fixing python issue * Remove csharp track1 readme file (#13553) * [mt][batch][document translator] Update API based on SDK team feedback (#13618) * update API based on SDK team feedback * update based on feedback * manually add ref * try to fix swagger * update swagger based on feedback * update swagger based on feedback. add retry-after * fix status type and datetime example * update examples, added required parameters * make nextlink an urlencoded string * add etag in swagger for these responses * re-add x-ms-enums and schema for status * Update API swagger for Metrics Advisor GA candidate (#13386) * update for MA GA * update * fix LintDiff * Datr/03 09 (#13587) * 03-09-preview * remove ring * test error message * readmes * fix to default * body * bump version * communication only track2 configure (#13662) Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> * add package version (#13690) Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> * Add Guest Configuration VMSS changes to Swagger spec (#13465) * Add Guest Configuration VMSS changes to Swagger spec * Fixed all the review comments from validation tool * Fix PR comments * Fixed the validation errors. Added back the fields in the examples * Added GET Collection APIs and Delete API for VMSS * Fixed delete API return type and other validation failures * add No content response for Delete operation * Fixed the example to have resposne for 204 * Removed the long running operation flag * Reverted readonly field Co-authored-by: Aashish Rajaram Salokhe <aasalokh@microsoft.com> * Dev sql microsoft.sql 2020 11 01 preview minor change (#13689) * Adds base for updating Microsoft.Sql from version preview/2020-08-01-preview to version 2020-11-01-preview * Updates readme * Updates API version in new specs and examples * Add updated 2020-11-01-preview versions of LongTermRetenionBackups.json and Databases.json (#12146) * add updated databases.json swagger * update readme with new package * v4 -> v5 * add missing chunk in readme * add correct swaggeR * add examples * add correct examplese * remove unreferenced examples * update swagger and examples. add 2020-11 pure package * Fix reference to 2020-08-01 reference to ElasticPools.json * update Databases.json name * update examples * remove nonexistant swagger * fixed reference capitals in readme * update package composite and fix ref to ManagedInstances.jsON * make backupstorageredundancy settings consistent * add requestedBackupStorageRedundancy to properties object in example * add LTR swagger and examples * add LTR Policies swagger and examples * make v5 match v4 * add updated Databses.json * merge conflicts in LTR Policies swagger' * take out comments in readme * taking ImportExport.json out from 2020-11 package * remove duplicate 2020-11 tag in readme * modify Databases_legacy.json to exclude ImportExport-related APIs * add servers.json for IE APIS and remove unused databases examples * fix model & prettier errors; add missing server example * add missing servers examples * fix example to exclude property from server obj * change RecommendedActions definitoins * change tag to composite v4 * Add missing properties for api version 2020-02-02-preview of securityAlertPolicies (#13117) * Add missing properties for api version 2020-02-02-preview * fix checks * fix according to prettier check * Add the change to version 2020-08-01-preview and version 2020-11-01-preview * remove changes in package-lock * Add new line at the end of file * update version 2020-11-01-preview * Update the ref to system data in serverdevopsaudit * add missing point * fix the validation errors * Delete ServerDevOpsAudit.json * fix the validation errors * re add ServerDevOpsAudit.json * fix the validation errors (#13325) * fix the validation errors * Delete ServerDevOpsAudit.json * fix the validation errors * re add ServerDevOpsAudit.json * address PrivateEndpointConnections.json validation issues in v3, v2 and v1 * Address Private Endpoint validation issues in V3, V2 and V1 SDK tags (#13404) * fix the validation errors * Delete ServerDevOpsAudit.json * fix the validation errors * re add ServerDevOpsAudit.json * address PrivateEndpointConnections.json validation issues in v3, v2 and v1 * Identity/Key/external Admin API (#13411) * Add examples for sql mi remove maintenance configuration (#13390) * Add missing specs 2020 11 01 (#13488) * fix the validation errors * Delete ServerDevOpsAudit.json * fix the validation errors * re add ServerDevOpsAudit.json * address PrivateEndpointConnections.json validation issues in v3, v2 and v1 * add missing specs in 2020-11-01-preview * update the validation errors * update systemData and sync with global common/v1/types.json * update legacy to match the latest database specs * remove RestorableDroppedManagedInstances due to it should be internal * Updated database extensions (#13584) Co-authored-by: Geetha Athreya <geathrey@microsoft.com> Co-authored-by: xaliciayang <59986952+xaliciayang@users.noreply.github.com> Co-authored-by: ayeletshpigelman <ayshpige@microsoft.com> Co-authored-by: strehan1993 <70013163+strehan1993@users.noreply.github.com> Co-authored-by: Ivan Kulezic <72797230+kukislav@users.noreply.github.com> Co-authored-by: Geetha Athreya <43223869+athreya-geetha@users.noreply.github.com> Co-authored-by: Geetha Athreya <geathrey@microsoft.com> * correct changeanalysis typescript.md (#13687) * Fixing .NET SDK (#13667) Co-authored-by: Ayush <aysharm@microsoft.com> * [Databox] Added mitigate api to resolve errors raised by job (#13597) * updating examples and get job json * fixing checks * removing white spaces from example * ran prettier fix * support readme.python change (#13698) * change acr config location to avoid bereaking change (#13692) Co-authored-by: Peiyuan Zhou <peizhou@microsoft.com> * GA version of the phone number Swagger file (#12446) * GA version of the phone number Swagger file * Fix Release example * Prettier fix * Fix ReadMe * More fixes on examples * Fix more validation errors * Change DELETE LROresponse to 204 * Add delete long running operation def and example file * Fix example file name * Prettier fix * Add purchase date * Try to fix invalid JSON file * . * . * . * Update Swagger to be stable, and with all comments addressed. * Run prettier * Fix file name * Add GetOperation * Fix validation errors * Fix another example file * . * Some clean ups * Change capabilities update to PATCH 200 * . * . * Fix produces / consumes for purchase * . * . * Use the CommunicationError object in common.json * Add produces application/json on DELETE methods * Make AcquiredPhoneNumbers and properties in PhoneNumberOperation required * Update latest Swagger * Remove reocrd controller * Address latest Swagger comments * Add LRO description fixes * PRettier fix * Rename directory name and fix examples * . * . * Update CommunicationError version * Remove configure number API and its example * Prettier + make earch expiry and phone number cost required * . * . * Add LRO properties * Fix more examples * Remove callback URI and application id * Add LROresponse back to release * Change capabilities update and release responses to 202. Also fix examples and typos. * Test Pavel's change to take out produce statement * Revert Pavel's changes plus fix examples * Test with empty produces statement * . * . * . * . * Rename PhoneNumberCapabilityValue to PhoneNumberCapabilityType * Rename Acquired to Purchase * Add suppression to README * . * . * . * . * . * . * . * . * Try adding phone numbers as its own package * . * . * . * . * Remove InkRecognizer REST API specifications (#13071) * EXPORT/RELEASE changes for 7.3-preview (#13448) * EXPORT/RELEASE changes for 7.3-preview * Fix lintdiff errors * Add swagger specification for a new path called /randomnumbers (#13680) * Add swagger specification for a new path called /randomnumbers * Fix the errors got back from the pull request * Update the maximum of bytesLength parameter for /randomnumbers * [Hub Generated] Review request for Microsoft.Resources to add version stable/2021-01-01 (#13178) * Adds base for updating Microsoft.Resources from version stable/2020-10-01 to version 2021-01-01 * Updates readme * Updates API version in new specs and examples * Remove deployment scripts for 2021-01-01 * Update what-if definitions * Fix readme * Rename a property * Fix configurations * Update readme.md (#13691) * correcting the placement constraint of publicnetworkaccess (#13674) Co-authored-by: srinivas thatipamula <srthatip@microsoft.com> * resourcegraph readme t2 config (#13715) * remove custom error (#13656) * parameter name correction (#13554) * parameter name correction * remove custom error * New api-version 2020-12-01 (#13144) * Copying 2020-10-01 to 2020-12-01 for baseline * Swagger generated * Validate tools * 1. Fixing typos 2. App Service enviornment fixes * Fixing commonDefinitions * 1. Fixing Statics Website examples 2. Adding CertificateOrder examples 3. Fixing spellCheck * Fixing WebApp & FunctionApp Stacks * Fix more errors * Fixing more examples & removing PrivateEndpointConnection API from Swagger * Adding Private link specific ones back * Fixing last 2 issues * fix example * Fixing version in examples * Fixing static Site issues * hostingEnvironment/{name}/health does not support List. Skipping it for this release * Removing OperationResults API from swagger * Adding "x-ms-secret": true * PR comments * Fixing prettlier * fixing one more comment * acc: fix a spec error of missing a default value (#13581) * Update pull_request_assignment.yml (#13725) * datamigration readme t2 config (#13494) * datamigration readme t2 config * datamigration readme change * datamigration readme change V2 * dataMigration readme change * Add new rule to oav error document. (#13722) * Add new rule to oav error document. * Update per review feedback. * typo: addtional -> additional (#13672) * QnaMaker v5.0-preview.2 (#13444) * iinitial commit * avacado fix * modelValidationFix * prettier fix * try fix for lintDiff * fix attempt * fix lint diff 2 * swaggerLintfix * minor updates * fix sdk error * Confidential Ledger Data-plane owner on ADP side (#13731) * Semantic Search API Gated Public Preview (#13588) * Semantic Search API Gated Public Preview * Adding missing POST parameters * fixing spelling * Fixing x-ms-client-name on Highlights property for Anserws and Captions and changing modelAsString to true on QueryLanguage and Speller query parameters * Fix spelling + run prettier * Pr comments * Clarify Pipe character + add nullable properties Co-authored-by: Janusz Lembicz <jlembicz@microsoft.com> * FRv2.1 preview3 update (#12997) * Standardized Errors, sample list. * removing from master from now as this is just a proposal * add table bounding box. * Fixing Appearance property for TextLine. * Incorporating review feedback. * Add ID examples. * Add optional ReadingOrder parameter. * Fix layout api to language parameter, other minor fixes. * Incorporating review feedback. * Incorporating review feedback. * Updating fileStream parameter to add .bmp file type. * Incorportating review feedback. * Fixing build errors. * Prettyfied json swagger. * Incorporate review feedback. * Fix swagger verification issues. * Incorporating review feedback. * Incorporating review feedback. Co-authored-by: Sandeep Parab <rparab@ntdev.microsoft.com> * [Resources] Import APIs for subscriptions.json file (#12964) * copy from 2020-01-01/subscriptions.json * add changes for extended location * Add examples copied from 2020-01-01 * add example for getting locations with extended locations * add reference to example file * Add extended location to resource definition. * resolve comments * update readme.md for subscriptions * update error responses in subscriptions spec * revert changes in common types * remove changes in 2020-10-01. add 2021-01-01. * copy subscriptions.json * add changes for extended locations in 2021-01-01 * update version to 2021-01-01 * revert unwanted changes * Fix readme * add x-ms-mutability to extendedLocation property * [Datadog] Update swagger (#13708) * LabServices readme.python t2 config(wave4) (#13699) * chore: Ignore typo "Tera" in specific version (#13703) * Hailiu/bot service web app settings (#12995) * add webAppBotSettings get operation * Revert "add webAppBotSettings get operation" This reverts commit 6fa8467a8e8634d5790ba97d31538da4a9093d69. * add api-version 2021-03-01 with webAppBotSettings * rename sub type from webAppBotSettings to hostSettings * add more descriptive descriptions to HostSettings * update api-version to 2021-03-01 for examples * add new bot kind * Update specification/botservice/resource-manager/Microsoft.BotService/stable/2021-03-01/botservice.json Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> * Update specification/botservice/resource-manager/Microsoft.BotService/stable/2021-03-01/botservice.json Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> * rename check name availability definition names * add azurebot as custom words * fix custom-words.txt file name * put custom words in the right place * rename HostSettings defintion to HostSettingsResponse * revert definition names so SDK back compat is not broken Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> * [Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2021-03-25-preview (#13681) * Adds base for updating Microsoft.HybridCompute from version preview/2021-01-28-preview to version 2021-03-25-preview * Updates readme * Updates API version in new specs and examples * added detectedProperties and parentClusterResourceId * added the parentClusterResourceId in the request * removed the parentClusterResourceId to be null * added the parentClusterResourceId back in both of the request and response * added a tag in the azureresourcesschema file * chore: Resort dictionary from bad merge (#13730) * Merge Dev-containerservice-microsoft.containerservice-2021-03-01 API to master (#13737) * Adds base for updating Microsoft.ContainerService from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range (#13349) Co-authored-by: Charlie Li <charlili@microsoft.com> * Add enableFIPS property to 2021-03-01 API in dev 2021-03-01 branch (#13359) * fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range * Add enableFIPS property to the 2021-03-01 API * Add enableFIPS property to the 2021-03-01 API Co-authored-by: Charlie Li <charlili@microsoft.com> * adding node-image upgrade channel enum (#13375) Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com> * Add httpProxyConfig specs to 2021-03-01 API - dev (#13410) * Add httpProxyConfig specs to 2021-03-01 API - dev * Fix prettier * aks: add `bindingSelector` to managed cluster pod identity profile (#13399) * AKS runCommand new feature (#13420) * runCommand target to 03-01 * fix api-version in examples * Add property disableLocalAccounts to 2021-03-01 API version (#13385) * Add property disableLocalAccounts * Fix indentation * Add OSSKU and GPUInstanceProfile to containerservice/microsoft.container API 2021-03-01 (#13532) * Add OSSKU and GPUInstanceProfile * Add sample for OSSKU and GPUInstanceProfile * Fix custom words * Reference sample files * update custom-words * Update readme for sdks (#13515) * update readme for sdks * update readme for sdks Co-authored-by: Charlie Li <charlili@microsoft.com> * Add example to create agent pool with FIPS enabled (#13557) * add example to create agent pool with FIPS enabled * change a property name in the example file Co-authored-by: Charlie Li <charlili@microsoft.com> * Added extended location parameter to managed cluster which will target all agent pools to that extended location. (#13560) * Add data model for get OS options. (#13619) * Add data model for get OS options. * Add default resource name in API path. * Fix container service tags. (#13739) Co-authored-by: Tongyao Si <tosi@microsoft.com> Co-authored-by: Charlie Li <charlili@microsoft.com> Co-authored-by: Charlie McBride <33269602+charliedmcb@users.noreply.github.com> Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com> Co-authored-by: Bo Wang <61758179+bowang-666@users.noreply.github.com> Co-authored-by: hbc <bcxxxxxx@gmail.com> Co-authored-by: Haitao Chen <haitch@users.noreply.github.com> Co-authored-by: Tony Xu <tonyxu@microsoft.com> Co-authored-by: Mirza Sikander <mirsik@microsoft.com> Co-authored-by: Jun Sun <33297523+JunSun17@users.noreply.github.com> * New Partner APIs for ordering service (#13576) * Adding initial files for edge order parther APIs * Fixes for spec and example validations. * Fixes for example and spec validations. * Fixed autorest validation issues. * Changes for order to order otem and actiontype removal for operationsList API. * Some fixes from pull request errors * Fixed tag issue * Removing swagger file temporarily to fix filename issue * Adding swagger file with changed name * Added multiple examples in swagger json for search inventories. * Fixed some descriptions. * Changes in the specs and examples as per discussion with Chris. * fixing secret validation error Co-authored-by: Pramila Dhaka <prdhaka@microsoft.com> * Update readme.python.md (#13759) * add some missing tags for go (#13758) * add sql always encrypted settings (#13724) * chore: Ignore Ruleproperties in specific version (#13673) * User/wmbt96/azsadmin apiconsistency features quotas (#13559) * Adding API spec for 2021-01-01 Quotas for GPU VMs * Adding API spec for 2020-11-01 Features * Fixing path parameter 'location' * Fixing 'locationName' in Quotas spec * Fixing 'location' in Features * Fixing Features oav validate-spec errors * Updating readme.md and fixing validator warnings * Fixing 'locationName' in Quota examples * Added missing newline at end of files * Adding ddagpu to custom words * Fixing Enum Mismatch * Fixing ModelValidation Errors * Fixing LintDiff by adding default error responses * Fixed 'partitionedGpuCount' in Create example * Amending default error schema * Adhering to default error response schema * Adding 2020-11-01 Features to stable folder and updating readme * Copying Compute.json and updating Features' references * Moving Quotas 2021-01-01 to stable and making copy of Compute.json * Updating readme with stable paths * Adding references to Compute.json copies in readme * Using single Compute.json copy * Adding param & definition references within specs Co-authored-by: Miguel Concha Vazquez <miconcha@microsoft.com> * Issues/communicationautorest (#13363) * [Communication] WIP testing new location readme * [Identity] WIP new read me * [WIP] read me update * [communication] identity remove duplicate files * [communication] adding phonenumber tag * [readme] moving new read me into identity * [autorest] adding read me to packages * [autorest] fixing chat path * [readme.csharp] removing some properties of the yaml * [autorest] removing the readme from the shared folder * [readme] updating read from upstream master * [readme] fixing the tag * [readme] clean up * [readme] clean up * [readme] clean up for identity * [readme] clean up phonenumbers * [readme] clean up identity * [readme] clean up sms * [readme] clean up admin * [readme] adding stable version * [readme] update the tag * [readme] remove the admin readme * [readme] delete root read me * [Admin] Readding the admin package * [readme] adding read me to admin and turn packages * [Synapse] change DaysOfWeek to DayOfWeek (#13745) * [Synapse] change DaysOfWeek to DayOfWeek * Fix CI pipeline errors Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> * Adding swagger to Microsoft.Billing 2020-05-01 for list billing account and billing profile reservations (#13735) * Adding swagger to Microsoft.Billing 2020-05-01 for list billing account and billing profile reservations * Update style * [resources] Fix resource multiapi submodule (#12941) * Updated properties for supporting private link (#13604) * added private link scope id property * fixed update example * updated private link properties * added separate examples for private link * updated example * removed default value in patch * changed boolean property to enum Co-authored-by: Akash Keshari <akkeshar@microsoft.com> * [mt][translator][document][batch] Update to release version v1.0 (#13707) * update API based on SDK team feedback * update based on feedback * manually add ref * try to fix swagger * update swagger based on feedback * update swagger based on feedback. add retry-after * fix status type and datetime example * update examples, added required parameters * make nextlink an urlencoded string * add etag in swagger for these responses * re-add x-ms-enums and schema for status * add new stable/v1.0 for batch translator * Update version of swagger file and examples * update example with correct api version * fix version in README * Add event schemas for Microsoft.PolicyInsights (#13590) * Add event schemas for Microsoft.PolicyInsights * Fix bad indentation * Specify the datetime format used by timestamp. * Use format: "date-time" to enable automatic parsing by the SDK * Pprp (#13661) * Update to use common type * Change to use common types. * Change to use common types. * Change to use common types. * Change to use common types. * Change to use common types. * Update to use common type. * Update .gitignore * Update .gitignore * Revert "Update to use common type." This reverts commit ad02e0631776f2e016300a02c56ab0bd85f4c97c. * Delete .gitignore * Updating the models. * Use common types * Use common types * Use common types * Use common types * Use common types * Use common types * Use common types * Use common types * Use common types * Use common types * Use common types * Use common types * Use common types * Use common types * Use common types * Use common types * Use common types * Use common types * Updates for network injection. * Updates for network injection. * Updates for network injection. * Updates for network injection. * Updates for network injection. * Updates for network injection. * Enterprise Policies update * Support Inplace phase 2 API's for AzureDataShare (#13647) Co-authored-by: Aditya Vutukuri <advutuku@microsoft.com> * Communication cli directive config checkin (#13770) * communication-cli-directive-config-checkin * typo * typo * fixing the URL for Authorization (#13767) * [NetAppFiles] Fix protocolType example (#13729) * Fix protocolType example * Pretty Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com> * [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2021-03-03-preview (#13256) * Adds base for updating Microsoft.AppPlatform from version preview/2020-11-01-preview to version 2021-03-03-preview * Updates readme * Updates API version in new specs and examples * add ResourceRequest property in deploymentsettings * fix typo * fix typo * add descriptions for field resourceRequests * Adding space between Identities in Enum (#13561) * Updated the models to include systemData and removed the supression f… (#13354) * Updated the models to include systemData and removed the supression for systemData * removed the deleted account examples and the package-lock.json * ran prettier locally to try and fix prettier validation error when making a PR * removing unecessary changes from last commit * Revert "removed the deleted account examples and the package-lock.json" This reverts commit 9a0b368a7aad1fc43460b329fcb4de32c1670606. * Revert "ran prettier locally to try and fix prettier validation error when making a PR" This reverts commit 3f11b97fdeef719f622120ba68e5d9cf68d89102. * Revert "ran prettier locally to try and fix prettier validation error when making a PR" This reverts commit 3f11b97fdeef719f622120ba68e5d9cf68d89102. * reverted the package-lock.json and .vscode/launch.json * reverted older commit * Removed unecessary files This reverts commit 708bc8700c8a13c408a232903e14cae57fd136ee. * Revert "Removed unecessary files" This reverts commit a27ce012bf115a486d87d6d2b1d7e8416f6473a3. * Removed deleted account examples and package-lock.json * Ran prettier to format the json files Co-authored-by: Melvin Bosnjak <mbosnjak@microsoft.com> * t2 synapse readme config (#13790) * update OperationalInsights package for SDK release (#13782) * added3 new properties to TableProperties: IsTroubleshootingAllowed, IsTroubleshootingEnabled, IsTroubleshootingEnabledLastActivation. * added Tables new api version * changed bool to boolean types * prettified jsons * fix erroes in swagger * undo changes to 2020-03-01-preview version * pr fixes * updated TableUpdate example * changed lastTroubleshootDate from date format to string, removed isTroubleshootingAllowed from body of example * changed v1 to v2 * changed WorkspaceNameParameter back to V1 * changed ErrorResponse to default ErrorResponse without ref to local definition * added systemData * removed systemData * added systemData to Patch and Get * moved systemData to Table properties * deleted systemData from Table.json, added to Get and Put examles * changed location of systemData in Tables.json * moved systemData to inside Table definition * moved systemData inside Table properties * removed SystemData * creatted a new package containing all latest swagger files for publishing new SDK * removed package 2021_02 and set default packate to 2020_10 * removed 2 packages * removed DataCollectorLogs.json from readme.md 20202.10 * added empty line to try invoke pipeline validations that havent run * Delete Tables.json * added3 new properties to TableProperties: IsTroubleshootingAllowed, IsTroubleshootingEnabled, IsTroubleshootingEnabledLastActivation. * merge * prettified jsons * undo changes to 2020-03-01-preview version * updated TableUpdate example * changed lastTroubleshootDate from date format to string, removed isTroubleshootingAllowed from body of example * changed v1 to v2 * changed WorkspaceNameParameter back to V1 * added systemData * removed systemData * added systemData to Patch and Get * moved systemData to Table properties * deleted systemData from Table.json, added to Get and Put examles * changed location of systemData in Tables.json * moved systemData to inside Table definition * moved systemData inside Table properties * removed whitespaces * changed DataExportErrorResponse to common .../v2/types.json#/definitions/ErrorResponse * changed all Error response of 2020-08 to common definition * reference old versions of other apis (#13786) * reference old versions of other apis * remove old files * Eiot sensors type alignment for new provider (#13780) * change boolean to enum * align new provider with new sensor field * eiot-sensor-type-align Co-authored-by: Gal Moshe <gamoshe@microsoft.com> * Add SQL DB v5 SDK (#12107) * add v5 sdk * change recommendedAction. * update a min sdk * replace RecommendedAction defs with common type * remove redundant defs in the 2014-04-01 legacy files. * add RestorableDroppedDatabase json file. * update RecommendedAction * update update swagger to use 2020-11-01 preview spec * revert int format change * Dev weather microsoft.maps 1.0 (#13791) * Remove preview from Weather API, remove X-Publish, and convert X-ms-enum ModelAsString to true * Revert changes to package-lock.json * [Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2020-09-01 (#13505) * Adds base for updating Microsoft.InstanceMetadataService from version stable/2020-07-15 to version 2020-09-01 * Updates readme * Updates API version in new specs and examples * New changes for 2020-09-01 * Prettier Co-authored-by: Joshua McCarthy <jmccarthy@microsoft.com> * Iot new device (#13503) * new device model for iot swcurity * spelling * fixed lint error * changed readme and added "x-ms-pageable" to device list * moved the "x-ms-pageable" from get to list * prettier * PR comments * Cplat sharedgallery2020 09 30 (#13655) * [Hub Generated] Review request for Microsoft.CostManagement to add version preview/2020-12-01-preview (#13609) * Latest * Latest * Latest * Latest * Latest * Latest * Latest * Latest * Latest * Latest * Latest * FixS360 | Microsoft.Billing (#13771) * fixing billing accounts and operations * adding total count. * typo fix * fixing spell check and prettier * Vakuncha changingcsharpreadme (#13806) * Update readme.csharp.md * Update readme.csharp.md * [aks] fix vm size model and osDiskType description (#13763) * fix: agent pool vm size should be string, not enum * fix: osDiskType default description for >= 2020-11-01 * [Hub Generated] Review request for Microsoft.DocumentDB to add version preview/2021-03-01-preview (#13267) * init * fix format * sync * read only * fix sample * fix Co-authored-by: Teng Pan <tepa@microsoft.com> * storagesync readme t2 config (#13810) * storagesync readme t2 config * storagesync readme.python t2 config * Updated SAS swagger with latest changes. (#13439) * Fixed hostname in the Offazure swaggers. * added newest swagger from service repo. This contains PE changes too. * rewritten swagger changes on existing swagger * some fixes to swagger * added examples. * fixes * edit * edit. * fixes * minor fix * edit * edit * edited default api version tag * Dev weather microsoft.maps 1.0 (#13796) * Remove preview from Weather API, remove X-Publish, and convert X-ms-enum ModelAsString to true * Revert changes to package-lock.json * Fix spelling error * Adding Azure Object Anchors error codes for IngestionProperties (#13787) * Added Azure Object Anchors error code field to IngestionProperties * Fixed spacing in example * Moved changes to new version * Addressed version mismatch, spacing * Fixed versions on examples * Readonly error code * Seeing if readonly error code is breaking * Revert "Seeing if readonly error code is breaking" This reverts commit c0b16f07c4a46a07fc7831a1735bb290804242ea. * Model error code as string * Renamed examples to asset conversion nomenclature * Fixed rename issues * Fixed issue #9593 (#13262) * Fixed issue #9593 * Removed redundant PrivateEndpointConnectionProperties attribute * [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-05-01 (#13800) * Fixed Swagger Validation Errors * Fixed Model Validation * [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (#13788) * Fixed Swagger Validation Errors * Fixed Type * Fixed Type * Fixed Setting Properties * Fixed Punctuation * Removed Item * Added Items Properties * Fixed Required Property * azurestack wave4 t2 config (#13813) * Added Microsoft.AppConfiguration 2021-03-01-preview API version. (#13490) * Added Microsoft.AppConfiguration 2021-03-01-preview API version. * Add system metadata to tracked resources in "Microsoft.AppConfiguration". Updated ConfigurationStore to reference the common tracked resource type definition. * Added disableLocalAuth property. * Add new api version swagger to readme. * Added/updated examples and added suppressions for standardized APIs. * Fixed prettier. * Add missing property fileStorageSkuName into MySQL Flexible Server spec (#13693) * appplatform t2 readme config (#13829) * customproviders t2 readme config (#13831) * Update readme.csharp.md (#13807) * [Sentine][Data connectors][Fix correctness bug] (#13175) * update required fields * update required fields * Explicitly define KeyCreationTime in Feb21 (#13757) * Explicitly define KeyCreationTime Explicitly define KeyCreationTime * Fix KeyCreationTime Example Fix KeyCreationTime Example * Add Microsoft.M365SecurityAndCompliance RP (#13646) * Add Microsoft.M365SecurityAndCompliance RP * fix datetime and common-types file path * update common-types file path * add preview path in readmego * replace stable with preview * remove duplicate tags * refer MIPPolicySync json in readme * service name for java (#13837) * Dev keyvault microsoft.key vault 2021 04 01 preview (#13585) * Adds base for updating Microsoft.KeyVault from version preview/2020-04-01-preview to version 2021-04-01-preview * Updates readme * Updates API version in new specs and examples * Open API change for Managed Hsm private endpoints feature (#12938) * Open API change for Managed Hsm private endpoints feature * Fixing spell check errors * Fixing spell check errors * Prettier fixes * Fixing swagger validation errors * Fixing systemData property reference * Adding publicNetworkAccess property based on private endpoint requirement. * GET responses following a successful DELETE should be returning 404. … (#13054) * GET responses following a successful DELETE should be returning 404. Only the DELETE response is to return 204 if the resource didn't exist (it allows idempotent deletes). (cherry picked from commit b752a19c6cc1f8a8eed9f106e2c77b8d5b5db19f) * Removing 404 as it is taken care by default response. * Added new routes for Deleted ManagedHsm for Soft Delete Feature (#13282) * Added new routes for Deleted ManagedHsm and examples, updated ManagedHsm definition to include PurgeDateTimeUTC * Fixing validation issues. * Fixing errors in properties in example jsons * Delete keyvault.json Deleted an errant json file * Fixed misspelling of property in examples * Fixed x-ms-examples naming, fixed camelcasing * Addressing comments in PR to make 204s 404s and also changing PurgeDateTimeUTC to scheduledPurgeDate * Added schema definitions for 404 * Removed 200 for purge Co-authored-by: Soohwan Kim <sookim@microsoft.com> * Addressing Comments for PR 13585 (#13586) * Removed 404s to allow requests to fall through to default * Removing 404s from examples Co-authored-by: Soohwan Kim <sookim@microsoft.com> * Added deletedmanagedhsm object to examples and managedhsm.json (#13591) * Added deletedmanagedhsm object to examples and managedhsm.json * Fixing error in references to correct values * Changed vaultId to mhsmId in exmaples Co-authored-by: Soohwan Kim <sookim@microsoft.com> * Try to use the common type for SystemData (#13723) * Add SystemData property for KeyVault * 04012021 fix schema (#13749) * Resolving conflict with custom-words.txt * Add 2021 preview to azureresourcechema, add suppression to readme * Add 2021 preview to azureresourcechema * Merging custom-words.txt Co-authored-by: Soohwan Kim <sookim@microsoft.com> * Add missing default error response (#13762) * Fix Lint error (#13765) * Add missing default error response * Update the integer format to fix Lint error * Add securityDefinitions * Added python tag for 2021 preview (#13805) Co-authored-by: Soohwan Kim <sookim@microsoft.com> * Fixing linting errors for MHSM R4036 - ImplementPrivateEndpointAPIs (#13822) * Fixing linting errors for MHSM R4036 - ImplementPrivateEndpointAPIs (cherry picked from commit c1c5aebfb98cacd0a4ee5596fb7b0d9f782a9a3e) * prettier fix * Add suppression for SystemData (#13835) * Add suppression for SystemData * Fix linting error R4036 - ImplementPrivateEndpointAPIs * specify the suppression for SystemData * Revert "specify the suppression for SystemData" This reverts commit cbebab81ab08ec1a29b41c891c58cf08ff2eb3c4. Co-authored-by: jiacheng-L <71623842+jiacheng-L@users.noreply.github.com> Co-authored-by: kim-soohwan <40476315+kim-soohwan@users.noreply.github.com> Co-authored-by: Soohwan Kim <sookim@microsoft.com> Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com> * hybridnetwork only track2 configure (#13832) * hybridnetwork only track2 configure * remodify * namespace del Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> * terraform readme for alertsmanagement (#13744) Co-authored-by: Your Name <you@example.com> * add tags back in the adp readme (#13850) * Add device principal type (#13799) * copy files from previous version * add device principal type, update versions * fix * system data requirement * Added CheckNameAvailability, Identity, systemData, used ErrorResponse v2 in DeviceUpdate (#13750) * Update deviceupdate.json * Update deviceupdate.json * Add files via upload * Update deviceupdate.json * Update deviceupdate.json * Update Accounts_Update.json * Update Accounts_Create.json * Update Instances_Create.json * Update deviceupdate.json * Linux line ending * Update CheckNameAvailability_AlreadyExists.json * Update CheckNameAvailability_Available.json * Update CheckNameAvailability_AlreadyExists.json * Update CheckNameAvailability_Available.json * Update CheckNameAvailability_AlreadyExists.json * Update CheckNameAvailability_Available.json * Update deviceupdate.json * Update deviceupdate.json * fixed typo in the example files (#13764) * Update CODEOWNERS (#13795) Updating list of Azure Cognitive Search team members * Update GenerateDetailedCostReportBySubscriptionAndTimePeriod.json (#13772) Update example data * [Hub Generated] Public private branch 'stuartko/Mar21_NewTSVersion' (#13811) * Adding version 2021-03-01-preview (copy of previous version) * Adding new metadata property * Adding uiDefinition property. * Update uiDefinition name to uiFormDefinition (per a change by the service feature author). No change to functionality. * Template Specs: Renaming template to "mainTemplate" and changing "artifacts" to be more specific "linkedTemplates". * Swagger changes for 2021-02-01-preview api version (#13794) * Copy existing preview version * Changes to databoxedge json file * Update readme files * Correct Spell Check * Fix Readme.go error * Update examples * Update all schemas.md files (#13862) * typo: implmentation -> implementation (#13644) * Add MongoDB/MongoDBAtlas sink (#13669) * Add MongoDB/MongoDBAtlas sink, add disableMetricsCollection in read/wirte properties * Revert disableMetricsCollection related changes * Azure ML new API version 20210401 (#12981) * Add Identity to createWorkpace example * change for getTransitivePEUsages * update * prettier code * add another new endpoint * address comments * change for getTransitivePEUsages * update * prettier code * add another new endpoint * address comments * revert change on transitivePE and notebookKeys * revert change on transitivePE and notebookKeys * add new stable version 2021-01-01 * add ListNotebookAccessToken * add primaryUserAssignedIdentity * fix missing properties and apis * fix one more missing property * 202 status for start and stop CI * make resync keys long runnin operation in version Jan2021 * resync keys 204 * update resync keys example * Dont throw 204 for resync * update resync keys * Formatting * revert Jan2021changes and add new version * start apr2021 version for azure ml rp * undo remove new line in jan2021 * use systemData definition in common * removed old files * fix small swagger bugs * run prettier * remove reference to sku * update readme * minimum agentCount should be 0 * add createdOn and ModifiedOn to compute properties * add LoadBalancerType to aks compute * add isNotebookInstanceCompute to virtualMachine * add leafDomainLabel to SslConfiguration * add overwriteExistingDomain to SslConfiguration * add synapseSpark as supported compute-type * update patch compute response to 202 * remove location from example responses * Revert "remove location from example responses" This reverts commit 048bf2551513afae842a9c4fbb5861aeddc6c33a. * MachineLearningCompute_Update should have a 200 response * sys data to use local def due to naming conflicts. * Fix enum casing * Fix operationId PR comment. * Change opId in apr version * remove 20210401 for easy review * only change api version * merge changes for 20210401 version * Add x-ms-discriminator-value for Synapse spark * camelcase loadbalancer properties * add createdOn and Modified on to examples * address AvoidAnonymousTypes error for SynapseSpark * Minor fixes + new property * Remove subscription state. Co-authored-by: zhaomuzhi <zhaoweixiong521@gmail.com> Co-authored-by: Vinay Rajmal Soni <vison@microsoft.com> Co-authored-by: jopet@microsoft.com <jopet@microsoft.com> Co-authored-by: Josh Peterson <15050193+joshanator@users.noreply.github.com> * datashare readme t2 config (#13833) * add readme terraform (#13717) * adding a new API version for Restore API and adding targetVirtualMachineId field for AzureWorkloadRestoreRequest (#13638) * copying previous change * Adding targetVirtualMachineId field for Azure Workload Restore requests * updating crr version and examples * removing new api-version * adding back the new api-version * removing Snapshot related fields * updating readme.md * corrected the path Co-authored-by: Chandrika Gonuguntla <chgonugu@microsoft.com> * chore: resort custom-words.txt from bad merge (#13868) * [ApplicationInsights] Fix failure for python SDK (#13875) * [Hub Generated] Review request for Microsoft.Insights to add version preview/2020-10-05-preview (#13712) * Adjustments to API to include validation grouping and updated text. * Fixed missing curly brace * adjusted name * Added basic and standard examples * adjusted type. * corrected case for key value * [Hub Generated] Review request for Microsoft.Insights to add version preview/2021-03-03-preview (#13269) * Adds base for updating Microsoft.Insights from version preview/2020-10-05-preview to version 2021-03-03-preview * Updates readme * Updates API version in new specs and examples * Add DiagnosticServiceToken API * Update examples to split tokens for readonly vs readwrite * Fix accoding to code review feedback * Update examples due to review feedback from ARM * add configuration for vmware (#13879) Co-authored-by: Your Name <you@example.com> * keyvault t2 config (#13863) * keyvault t2 config * keyvault multi-api config * multi api config * config reset * add package version * hanaonazure t2 readme config (#13880) * Remove x-ms-azure-resource (#13500) Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> * Juniwang/sr202010401preview (#13664) * prepare to add new api-version: copy everything from 2020-07-01-preview * Adding new api-version * Fix required body and annotate ms secrets * remove secrets example from swagger * fix prettier * add datashare terraform configuration (#13876) Co-authored-by: Your Name <you@example.com> * storage readme t2 config (#13881) * storage readme t2 config * storage t2 config * healthcareapis t2 config (#13884) * typo: APIkeys -> APIKeys (#13641) * Allow release_policy to be nullable (#13826) * Fix type of Anserws and Captions (#13872) * change the value of license header (#13886) * [Synapse] - library_append API adds comp parameter (#13841) * [Synapse] - add comp parameter * Update example files Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> * Remove 200 response from async operation (#13190) * Async operation always returns 202 on initial call * Address review feedback * Revert "Address review feedback" This reverts commit 9ae550b95c1082c8383595a943a9abe5990fd4ef. * add minimal tls version for mariadb (#11779) * [Synapse] - add Swagger code owner (#13882) Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> * add con figuration for databoxedge (#13877) Co-authored-by: Your Name <you@example.com> * add configuration for resourcemover (#13878) Co-authored-by: Your Name <you@example.com> * Reduce code owner scope for Monitor.Exporters team (#13898) * [portal]Update readme.python.md (#13907) * Update readme.python.md * Update readme.md * Update readme.python.md * Update readme.python.md * Dev dfp microsoft.dfp 2021 02 01 privatepreview (#13305) * New Readme Config File * New Go Language Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New AzureResourceSchema Readme Config File * New Swagger Spec File * New Swagger Example Spec File * DFP API specs. Copied from Azure-PPE * Spelling fix. instnace => instance * Fix resource provider name to pascal case * Added '/providers/Microsoft.Dfp/operations' * Added SystemData (fix R4009 error) * Fix validation errors * Prettier fixes * Removed non-existend parameter sku * Style fixes in DFP API specs * Swagger ModelValidation failures fix * Fix operations API * Fix operations API validation failure * 1. Added example for lists operations. 2. made the API preview instead of privatepreview * Fix path in readme's * Fix in readme * Added readonly attribute to systemdata * Added readonly attribute to systemdata * Fix in python SDK readme * Fixes in ListOperations.json examples * Fixed API version * Added type to response bodies * Fix typos in examples (urls) * Added 201 response into createInstance example * Renamed RP name from Microsoft.Dfp to Microsoft.Dynamics365Fraudprotection * Added long-running result for creation instance * Added nextlink * Fix in checkNameAvailability definition URL * Next link parameter * Using references to common types instead of re-declaring them * Reused common type. Fixed provisioning state * Nesting error fix * Fixed examples * Fix * Fix in error response definition * Rename RP. Fix examples in readme's * Added http 202 * Added http 202 to examples * [Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2020-10-01 (#13818) * Adds base for updating Microsoft.InstanceMetadataService from version stable/2020-09-01 to version 2020-10-01 * Updates readme * Updates API version in new specs and examples * Adding new fields for 2020-10-01 * Updating wording for disablePasswordAuthentication' Co-authored-by: jmccarthy <jmccarthy@microsoft.com> * Remove name check from client side (#13492) * remove name validation from client side * remove name check from deploymentScripts swagger * remove name check from previous swagger versions * remove pattern from resourcegroupname parameter * Update deviceupdate.json (#13900) * [Hub Generated] Review request for Microsoft.ResourceHealth to add version stable/2018-07-01 (#13817) * Updated api-version * Removed systemData * Updated api-version * Updated the example * Add EligibleChildResources resource for PIM + update examples (#13803) * PIM API Specs * update readme * Update * Update readme * operation id fix * name fix * Name changes * fix * Fix * Changes based on docs generated * Scope fix …
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…preview/2020-04-01-preview (Azure#13389) * Add systemData to keyVault Vault property * Update to our own systemData definition * Fix copy/paste error and refactor out the identity type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.