Adding "assignmentState" property to scope model in access review APIs #13802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update api version tag for all files Update readme files
kaiwenfeng4086
requested review from
00Kai0,
jsntcy,
msyyc,
RAY-316,
stankovski and
zhangyan133
as code owners
|
Hi, @kaiwenfeng4086 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'PUT' operation 'AccessReviewDefaultSettings_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/preview/2021-04-06-preview/authorization-AccessReviewCalls.json#L664 |
|
| 'PATCH' operation 'AccessReviewInstanceMyDecisions_Patch' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/preview/2021-04-06-preview/authorization-AccessReviewCalls.json#L990 |
|
| A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'AccessReviewScheduleDefinitions_CreateOrUpdateById' Request Model: 'AccessReviewScheduleDefinitionProperties' Response Model: 'AccessReviewScheduleDefinition' Location: Microsoft.Authorization/preview/2021-04-06-preview/authorization-AccessReviewCalls.json#L191 |
|
| A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'AccessReviewDefaultSettings_Put' Request Model: 'AccessReviewScheduleSettings' Response Model: 'AccessReviewDefaultSettings' Location: Microsoft.Authorization/preview/2021-04-06-preview/authorization-AccessReviewCalls.json#L660 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AccessReviewInstanceModel'. Consider using the plural form of 'AccessReviewInstance' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/preview/2021-04-06-preview/authorization-AccessReviewCalls.json#L386 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AccessReviewInstanceModel'. Consider using the plural form of 'AccessReviewInstance' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/preview/2021-04-06-preview/authorization-AccessReviewCalls.json#L433 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AccessReviewInstanceModel'. Consider using the plural form of 'AccessReviewInstance' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/preview/2021-04-06-preview/authorization-AccessReviewCalls.json#L480 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AccessReviewInstanceModel'. Consider using the plural form of 'AccessReviewInstance' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/preview/2021-04-06-preview/authorization-AccessReviewCalls.json#L527 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AccessReviewDefaultSettingsModel'. Consider using the plural form of 'AccessReviewDefaultSettings' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/preview/2021-04-06-preview/authorization-AccessReviewCalls.json#L630 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AccessReviewDefaultSettingsModel'. Consider using the plural form of 'AccessReviewDefaultSettings' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/preview/2021-04-06-preview/authorization-AccessReviewCalls.json#L664 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.9)
️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 2 Warnings warning [Detail]
- The following tags are being changed in this PR
- authorization/resource-manager/readme.md#package-2021-03-01-preview-only
- authorization/resource-manager/readme.md#package-2020-10-01-preview
- authorization/resource-manager/readme.md#package-2020-08-01-preview
- authorization/resource-manager/readme.md#package-2020-04-01-preview
- authorization/resource-manager/readme.md#package-2020-04-01-preview-only
- authorization/resource-manager/readme.md#package-2020-03-01-preview
- authorization/resource-manager/readme.md#package-2018-09-01-preview
- authorization/resource-manager/readme.md#package-2018-09-01-preview-only
- authorization/resource-manager/readme.md#package-2018-07-01-preview
- authorization/resource-manager/readme.md#package-2018-07-01-preview-only
- authorization/resource-manager/readme.md#package-2018-05-01-preview
- authorization/resource-manager/readme.md#package-2018-01-01-preview
- authorization/resource-manager/readme.md#package-2018-01-01-preview-only
- authorization/resource-manager/readme.md#package-2017-10-01-preview
- authorization/resource-manager/readme.md#package-2017-10-01-preview-only
- authorization/resource-manager/readme.md#package-2015-07-01
- authorization/resource-manager/readme.md#package-2015-06-01-preview
- authorization/resource-manager/readme.md#profile-hybrid-2020-09-01
- authorization/resource-manager/readme.md#profile-hybrid-2019-03-01
- authorization/resource-manager/readme.md#package-2021-01-01-preview-only
- authorization/resource-manager/readme.md#package-2021-04-06-preview-only
| Rule | Message |
|---|---|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-04-06-preview-only", "details":"Schema 'AccessReviewDecisionUserIdentity' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-04-06-preview-only", "details":"Schema 'AccessReviewDecisionServicePrincipalIdentity' has an allOf list with an empty object schema as a parent, removing it." |
|
| 💬 AutorestCore/Exception | "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-03-01-preview-only", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-03-01-preview-only", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-04-06-preview-only", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-04-06-preview-only", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-03-01-preview-only", "details":"Schema 'AccessReviewDecisionUserIdentity' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-03-01-preview-only", "details":"Schema 'AccessReviewDecisionServicePrincipalIdentity' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2018-05-01-preview", "details":"Schema 'UserDecisionTarget' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2018-05-01-preview", "details":"Schema 'ServicePrincipalDecisionTarget' has an allOf list with an empty object schema as a parent, removing it." |
|
| 💬 AutorestCore/Exception | "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-03-01-preview-only", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
| 💬 AutorestCore/Exception | "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
| 💬 AutorestCore/Exception | "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-08-01-preview", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-08-01-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
| 💬 AutorestCore/Exception | "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-04-01-preview", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
ghost
added
the
customer-reported
Swagger Generation Artifacts
|
|
Thank you for your contribution kaiwenfeng4086! We will review the pull request and get back to you soon. |
|
|
|
Hi @kaiwenfeng4086, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Apr 6, 2021
This was referenced Apr 6, 2021
varunkumta
added
the
ARMSignedOff
kaiwenfeng4086
changed the title
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
Hi, @kaiwenfeng4086. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Adding "assignmentState" property to scope model in access review APIs
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.