Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger Update API Changes #13870

Closed
wants to merge 41 commits into from
Closed

Ledger Update API Changes #13870

wants to merge 41 commits into from

Conversation

rewongmicrosoft
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

joshdmcc and others added 30 commits April 6, 2021 13:45
…to add version stable/2020-09-01 (#13505)

* Adds base for updating Microsoft.InstanceMetadataService from version stable/2020-07-15 to version 2020-09-01

* Updates readme

* Updates API version in new specs and examples

* New changes for 2020-09-01

* Prettier

Co-authored-by: Joshua McCarthy <jmccarthy@microsoft.com>
* new device model for iot swcurity

* spelling

* fixed lint error

* changed readme and added "x-ms-pageable" to device list

* moved the "x-ms-pageable" from get to list

* prettier

* PR comments
…rsion preview/2020-12-01-preview (#13609)

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest
* fixing billing accounts and operations

* adding total count.

* typo fix

* fixing spell check and prettier
* Update readme.csharp.md

* Update readme.csharp.md
* fix: agent pool vm size should be string, not enum

* fix: osDiskType default description for >= 2020-11-01
…n preview/2021-03-01-preview (#13267)

* init

* fix format

* sync

* read only

* fix sample

* fix

Co-authored-by: Teng Pan <tepa@microsoft.com>
* storagesync readme t2 config

* storagesync readme.python t2 config
* Fixed hostname in the Offazure swaggers.

* added newest swagger from service repo. This contains PE changes too.

* rewritten swagger changes on existing swagger

* some fixes to swagger

* added examples.

* fixes

* edit

* edit.

* fixes

* minor fix

* edit

* edit

* edited default api version tag
* Remove preview from Weather API, remove X-Publish, and convert X-ms-enum ModelAsString to true

* Revert changes to package-lock.json

* Fix spelling error
* Added Azure Object Anchors error code field to IngestionProperties

* Fixed spacing in example

* Moved changes to new version

* Addressed version mismatch, spacing

* Fixed versions on examples

* Readonly error code

* Seeing if readonly error code is breaking

* Revert "Seeing if readonly error code is breaking"

This reverts commit c0b16f0.

* Model error code as string

* Renamed examples to asset conversion nomenclature

* Fixed rename issues
* Fixed issue #9593

* Removed redundant PrivateEndpointConnectionProperties attribute
…on stable/2019-05-01 (#13800)

* Fixed Swagger Validation Errors

* Fixed Model Validation
…rsion stable/2019-11-01 (#13788)

* Fixed Swagger Validation Errors

* Fixed Type

* Fixed Type

* Fixed Setting Properties

* Fixed Punctuation

* Removed Item

* Added Items Properties

* Fixed Required Property
)

* Added Microsoft.AppConfiguration 2021-03-01-preview API version.

* Add system metadata to tracked resources in "Microsoft.AppConfiguration".
Updated ConfigurationStore to reference the common tracked resource type definition.

* Added disableLocalAuth property.

* Add new api version swagger to readme.

* Added/updated examples and added suppressions for standardized APIs.

* Fixed prettier.
* update required fields

* update required fields
* Explicitly define KeyCreationTime

Explicitly define KeyCreationTime

* Fix KeyCreationTime Example

Fix KeyCreationTime Example
* Add Microsoft.M365SecurityAndCompliance RP

* fix datetime and common-types file path

* update common-types file path

* add preview path in readmego

* replace stable with preview

* remove duplicate tags

* refer MIPPolicySync json in readme
* Adds base for updating Microsoft.KeyVault from version preview/2020-04-01-preview to version 2021-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Open API change for Managed Hsm private endpoints feature (#12938)

* Open API change for Managed Hsm private endpoints feature

* Fixing spell check errors

* Fixing spell check errors

* Prettier fixes

* Fixing swagger validation errors

* Fixing systemData property reference

* Adding publicNetworkAccess property based on private endpoint requirement.

* GET responses following a successful DELETE should be returning 404. … (#13054)

* GET responses following a successful DELETE should be returning 404. Only the DELETE response is to return 204 if the resource didn't exist (it allows idempotent deletes).

(cherry picked from commit b752a19)

* Removing 404 as it is taken care by default response.

* Added new routes for Deleted ManagedHsm for Soft Delete Feature (#13282)

* Added new routes for Deleted ManagedHsm and examples, updated ManagedHsm definition to include PurgeDateTimeUTC

* Fixing validation issues.

* Fixing errors in properties in example jsons

* Delete keyvault.json

Deleted an errant json file

* Fixed misspelling of property in examples

* Fixed x-ms-examples naming, fixed camelcasing

* Addressing comments in PR to make 204s 404s and also changing PurgeDateTimeUTC to scheduledPurgeDate

* Added schema definitions for 404

* Removed 200 for purge

Co-authored-by: Soohwan Kim <sookim@microsoft.com>

* Addressing Comments for PR 13585 (#13586)

* Removed 404s to allow requests to fall through to default

* Removing 404s from examples

Co-authored-by: Soohwan Kim <sookim@microsoft.com>

* Added deletedmanagedhsm object to examples and managedhsm.json (#13591)

* Added deletedmanagedhsm object to examples and managedhsm.json

* Fixing error in references to correct values

* Changed vaultId to mhsmId in exmaples

Co-authored-by: Soohwan Kim <sookim@microsoft.com>

* Try to use the common type for SystemData (#13723)

* Add SystemData property for KeyVault

* 04012021 fix schema (#13749)

* Resolving conflict with custom-words.txt

* Add 2021 preview to azureresourcechema, add suppression to readme

* Add 2021 preview to azureresourcechema

* Merging custom-words.txt

Co-authored-by: Soohwan Kim <sookim@microsoft.com>

* Add missing default error response (#13762)

* Fix Lint error (#13765)

* Add missing default error response

* Update the integer format to fix Lint error

* Add securityDefinitions

* Added python tag for 2021 preview (#13805)

Co-authored-by: Soohwan Kim <sookim@microsoft.com>

* Fixing linting errors for MHSM R4036 - ImplementPrivateEndpointAPIs (#13822)

* Fixing linting errors for MHSM R4036 - ImplementPrivateEndpointAPIs

(cherry picked from commit c1c5aeb)

* prettier fix

* Add suppression for SystemData (#13835)

* Add suppression for SystemData

* Fix linting error R4036 - ImplementPrivateEndpointAPIs

* specify the suppression for SystemData

* Revert "specify the suppression for SystemData"

This reverts commit cbebab8.

Co-authored-by: jiacheng-L <71623842+jiacheng-L@users.noreply.github.com>
Co-authored-by: kim-soohwan <40476315+kim-soohwan@users.noreply.github.com>
Co-authored-by: Soohwan Kim <sookim@microsoft.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
* hybridnetwork only track2 configure

* remodify

* namespace del

Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>
Co-authored-by: Your Name <you@example.com>
* copy files from previous version

* add device principal type, update versions

* fix

* system data requirement
This was referenced Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.