New version apis documentation #13928

MiriBerezin · 2021-04-14T11:23:30Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- [V] new API version
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
during June 2021
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
During June 2021
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- [V ] SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell ??
- [V] CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

[V] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- [V] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API. This API was never in use in this version.
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2021-04-14T11:23:33Z

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.9)
- current:Microsoft.Marketplace/stable/2019-12-01 compared with base:Microsoft.Marketplace/stable/2019-12-01
- current:stable/2020-01-01/Marketplace.json compared with base:stable/2020-01-01/Marketplace.json
- current:stable/2020-12-01/Marketplace.json compared with base:stable/2020-12-01/Marketplace.json

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Marketplace/privateStoreClient/isPrivateClient' removed or restructured? Old: Microsoft.Marketplace/stable/2019-12-01/Marketplace.json#L18:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Marketplace/operations' removed or restructured? Old: Microsoft.Marketplace/stable/2019-12-01/Marketplace.json#L51:5
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ApiVersionParameter' removed or renamed? New: Microsoft.Marketplace/stable/2019-12-01/Marketplace.json#L18:3 Old: Microsoft.Marketplace/stable/2019-12-01/Marketplace.json#L80:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'subscriptionIdParameter' removed or renamed? New: Microsoft.Marketplace/stable/2019-12-01/Marketplace.json#L18:3 Old: Microsoft.Marketplace/stable/2019-12-01/Marketplace.json#L80:3

️⚠️LintDiff: 23 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- marketplace/resource-manager/readme.md tag:package-2021-06-01
- marketplace/resource-manager/readme.md tag:package-composite-v1
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- marketplace/resource-manager/readme.md tag:package-composite-v1

The following errors/warnings are introduced by current PR:

Only 10 items are listed, please refer to log for more details.

Rule	Message
⚠️ R1003 - ListInOperationName	Since operation 'PrivateStore_QueryOffers' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L165
⚠️ R1003 - ListInOperationName	Since operation 'PrivateStore_BillingAccounts' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L201
⚠️ R1003 - ListInOperationName	Since operation 'PrivateStoreCollection_TransferOffers' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L453
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L2084
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L2209
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'PrivateStoreCollection_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L278
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'PrivateStoreModel'. Consider using the plural form of 'PrivateStore' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L165
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'PrivateStoreModel'. Consider using the plural form of 'PrivateStore' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L201
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'PrivateStoreModel'. Consider using the plural form of 'PrivateStore' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L237
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: '{collectionid}' in:'PrivateStoreCollection_Post'. Consider updating the operationId Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L408

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Marketplace/stable/2020-01-01/Marketplace.json#L118
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Marketplace/stable/2020-01-01/Marketplace.json#L386
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Marketplace/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Marketplace/stable/2020-01-01/Marketplace.json#L436
⚠️ R1003 - ListInOperationName	Since operation 'PrivateStore_GetApprovalRequestsList' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L675
⚠️ R1003 - ListInOperationName	Since operation 'PrivateStore_AdminRequestApprovalsList' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L833
⚠️ R1003 - ListInOperationName	Since operation 'PrivateStore_GetApprovalRequestsList' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Marketplace/stable/2020-12-01/Marketplace.json#L113
⚠️ R1003 - ListInOperationName	Since operation 'PrivateStore_AdminRequestApprovalsList' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Marketplace/stable/2020-12-01/Marketplace.json#L316
⚠️ R1005 - GetInOperationName	'GET' operation 'PrivateStore_AdminRequestApprovalsList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L833
⚠️ R1005 - GetInOperationName	'GET' operation 'PrivateStore_AdminRequestApprovalsList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Marketplace/stable/2020-12-01/Marketplace.json#L316
⚠️ R1006 - PutInOperationName	'PUT' operation 'PrivateStore_UpdateAdminRequestApproval' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#L903

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.9)
- current:stable/2021-06-01/Marketplace.json compared with base:stable/2020-12-01/Marketplace.json

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 3 Warnings warning [Detail]

The following tags are being changed in this PR

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ Modeler/MissingType	"readme":"marketplace/resource-manager/readme.md", "tag":"package-composite-v2", "details":"The schema 'planDetails-requestDate' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/marketplace/resource-manager/Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#/components/schemas/planDetails-requestDate"
⚠️ Modeler/MissingType	"readme":"marketplace/resource-manager/readme.md", "tag":"package-2020-12-01", "details":"The schema 'planDetails-requestDate' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/marketplace/resource-manager/Microsoft.Marketplace/stable/2020-12-01/Marketplace.json#/components/schemas/planDetails-requestDate"
⚠️ Modeler/MissingType	"readme":"marketplace/resource-manager/readme.md", "tag":"package-2021-06-01", "details":"The schema 'planDetails-requestDate' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/marketplace/resource-manager/Microsoft.Marketplace/stable/2021-06-01/Marketplace.json#/components/schemas/planDetails-requestDate"
💬 AutorestCore/Exception	"readme":"marketplace/resource-manager/readme.md", "tag":"package-composite-v1", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
💬 AutorestCore/Exception	"readme":"marketplace/resource-manager/readme.md", "tag":"package-composite-v1", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
💬 AutorestCore/Exception	"readme":"marketplace/resource-manager/readme.md", "tag":"package-composite-v2", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
💬 AutorestCore/Exception	"readme":"marketplace/resource-manager/readme.md", "tag":"package-composite-v2", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
💬 AutorestCore/Exception	"readme":"marketplace/resource-manager/readme.md", "tag":"package-2020-12-01", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
💬 AutorestCore/Exception	"readme":"marketplace/resource-manager/readme.md", "tag":"package-2020-12-01", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
💬 AutorestCore/Exception	"readme":"marketplace/resource-manager/readme.md", "tag":"package-2021-06-01", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` PreCheck/DuplicateSchema	"readme":"marketplace/resource-manager/readme.md", "tag":"package-composite-v1", "details":"Duplicate Schema named Resource -- properties.systemData: undefined => "$ref":"#/components/schemas/schemas:157", "readOnly":true, "description":"Metadata pertaining to creation and last modification of the resource" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` AutorestCore/Exception	"readme":"marketplace/resource-manager/readme.md", "tag":"package-composite-v1", "details":"Error: Plugin prechecker reported failure."
💬 AutorestCore/Exception	"readme":"marketplace/resource-manager/readme.md", "tag":"package-composite-v1", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
💬 AutorestCore/Exception	"readme":"marketplace/resource-manager/readme.md", "tag":"package-2020-01-01", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
💬 AutorestCore/Exception	"readme":"marketplace/resource-manager/readme.md", "tag":"package-2020-01-01", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-04-14T11:23:34Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from ee73dbe. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/marketplace/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.Marketplace [View full logs] [Release SDK Changes]

cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/marketplace/Microsoft.Azure.Management.Marketplace/tests/ScenarioTests/PrivateStoreTests.cs(19,62): error CS0246: The type or namespace name 'MarketplaceManagementClient' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/marketplace/Microsoft.Azure.Management.Marketplace/tests/Microsoft.Azure.Management.Marketplace.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/marketplace/Microsoft.Azure.Management.Marketplace/tests/ScenarioTests/PrivateStoreTests.cs(61,62): error CS0246: The type or namespace name 'MarketplaceManagementClient' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/marketplace/Microsoft.Azure.Management.Marketplace/tests/Microsoft.Azure.Management.Marketplace.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/marketplace/Microsoft.Azure.Management.Marketplace/tests/ScenarioTests/PrivateStoreTests.cs(106,62): error CS0246: The type or namespace name 'MarketplaceManagementClient' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/marketplace/Microsoft.Azure.Management.Marketplace/tests/Microsoft.Azure.Management.Marketplace.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/marketplace/Microsoft.Azure.Management.Marketplace/tests/ScenarioTests/PrivateStoreTests.cs(19,62): error CS0246: The type or namespace name 'MarketplaceManagementClient' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/marketplace/Microsoft.Azure.Management.Marketplace/tests/Microsoft.Azure.Management.Marketplace.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/marketplace/Microsoft.Azure.Management.Marketplace/tests/ScenarioTests/PrivateStoreTests.cs(61,62): error CS0246: The type or namespace name 'MarketplaceManagementClient' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/marketplace/Microsoft.Azure.Management.Marketplace/tests/Microsoft.Azure.Management.Marketplace.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/marketplace/Microsoft.Azure.Management.Marketplace/tests/ScenarioTests/PrivateStoreTests.cs(106,62): error CS0246: The type or namespace name 'MarketplaceManagementClient' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/marketplace/Microsoft.Azure.Management.Marketplace/tests/Microsoft.Azure.Management.Marketplace.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from ee73dbe. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] (node:2386) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2020-01-01/Microsoft.Marketplace.json'
cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr	[generateScript.sh] (node:2386) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr	[generateScript.sh] (node:2386) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

️✔️marketplace [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-04-14T11:23:35Z

Hi, @MiriBerezin Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-04-14T11:23:36Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-workflow-bot · 2021-04-14T11:25:07Z

Hi @MiriBerezin, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

… v2019-12-01

MiriBerezin · 2021-05-02T06:17:30Z

/azp run

azure-pipelines · 2021-05-02T06:17:35Z

Pull request contains merge conflicts.

MiriBerezin · 2021-05-02T10:03:04Z

/azp run

azure-pipelines · 2021-05-02T10:03:16Z

Azure Pipelines successfully started running 1 pipeline(s).

ArcturusZhang · 2021-05-06T03:48:50Z

This RP only enables the generation for dot net SDK and ARM template.

@allenjzhang for dot net
@leni-msft for ARM template generation

leni-msft

Schemas generation looks good.

MiriBerezin · 2021-05-23T09:37:05Z

@ArcturusZhang I added new APIs in the last commit.
The Breaking Changes fails now for the API that was removed in the previous PR that you already signed off (we were wondering why the breaking changes did not fail before, and I clarified that this API was never in use, so it was just a cleanup).
Please review again. Thanks!

ArcturusZhang · 2021-05-24T05:43:08Z

Hey @MiriBerezin now that the breaking change CI is failing, it is mandatory that we have to get sign off from the breaking change review board, otherwise we cannot merge this PR.
Could you please follow the guidance here to initiate a breaking change review?

…the operation succeeded or failed

* New version apis documentation * Fix Tests * fix tests * remove tag to v2019-12-01 as it is not in use * Fix tests * Fix version and readme.md * Align the title to Marketplace RP Service and add default response to v2019-12-01 * remove the default response on version 2019-12-01 * Fix Errors * Fix errors * remove 2019 api version * Revert "remove 2019 api version" This reverts commit effa0cc. * Adding v2019 back * remove v2019 * align with master latest changes * Fix conflict * fix conflict * Fix tests * adding more apis * Add API: collectionsSubscriptionsMapping * Adding api: query offers * Change transferOffers response body to retrieve which on collections the operation succeeded or failed

New version apis documentation

98dded2

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Apr 14, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Apr 14, 2021

openapi-sdkautomation bot mentioned this pull request Apr 14, 2021

[AutoPR marketplace/resource-manager] New version apis documentation AzureSDKAutomation/azure-resource-manager-schemas#2464

Draft

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Apr 14, 2021

Fix Tests

2cc7dc4

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Apr 14, 2021

This was referenced Apr 14, 2021

[AutoPR marketplace] New version apis documentation AzureSDKAutomation/azure-resource-manager-schemas#2465

Closed

[AutoPR Microsoft.Azure.Management.Marketplace] New version apis documentation AzureSDKAutomation/azure-sdk-for-net#3899

Closed

fix tests

af51bc2

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Apr 14, 2021

remove tag to v2019-12-01 as it is not in use

1662e8c

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Apr 14, 2021

Fix tests

0138dff

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Apr 14, 2021

Fix version and readme.md

48e5a08

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Apr 18, 2021

Align the title to Marketplace RP Service and add default response to…

0219890

… v2019-12-01

openapi-pipeline-app bot added BreakingChangeReviewRequired and removed CI-FixRequiredOnFailure labels Apr 18, 2021

chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 29, 2021

align with master latest changes

8a03f2b

MiriBerezin added 2 commits May 2, 2021 09:30

Fix conflict

af8b5c5

fix conflict

8713aa9

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label May 2, 2021

Fix tests

234c1de

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label May 2, 2021

leni-msft approved these changes May 6, 2021

View reviewed changes

adding more apis

608fee0

openapi-pipeline-app bot added the BreakingChangeReviewRequired label May 23, 2021

MiriBerezin added 3 commits May 25, 2021 15:55

Add API: collectionsSubscriptionsMapping

a311118

Adding api: query offers

a9bf3bb

Change transferOffers response body to retrieve which on collections …

297188e

…the operation succeeded or failed

JeffreyRichter approved these changes Jun 7, 2021

View reviewed changes

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 7, 2021

ArcturusZhang merged commit ee73dbe into Azure:master Jun 8, 2021

This was referenced Jun 8, 2021

[ReleasePR marketplace] Adding new apis Azure/azure-resource-manager-schemas#1679

Closed

[ReleasePR Microsoft.Azure.Management.Marketplace] New version apis documentation Azure/azure-sdk-for-net#16944

Closed

heaths mentioned this pull request Jun 16, 2021

Initial 2021-05-01-preview version #14855

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New version apis documentation #13928

New version apis documentation #13928

MiriBerezin commented Apr 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 14, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Apr 14, 2021

openapi-workflow-bot bot commented Apr 14, 2021

openapi-workflow-bot bot commented Apr 14, 2021

MiriBerezin commented May 2, 2021

azure-pipelines bot commented May 2, 2021

MiriBerezin commented May 2, 2021

azure-pipelines bot commented May 2, 2021

ArcturusZhang commented May 6, 2021

leni-msft left a comment

MiriBerezin commented May 23, 2021

ArcturusZhang commented May 24, 2021

New version apis documentation #13928

New version apis documentation #13928

Conversation

MiriBerezin commented Apr 14, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Apr 14, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 14, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Apr 14, 2021

openapi-workflow-bot bot commented Apr 14, 2021

openapi-workflow-bot bot commented Apr 14, 2021

MiriBerezin commented May 2, 2021

azure-pipelines bot commented May 2, 2021

MiriBerezin commented May 2, 2021

azure-pipelines bot commented May 2, 2021

ArcturusZhang commented May 6, 2021

leni-msft left a comment

Choose a reason for hiding this comment

MiriBerezin commented May 23, 2021

ArcturusZhang commented May 24, 2021

MiriBerezin commented Apr 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 14, 2021 •

edited

Loading