-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-01-01 #14009
[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-01-01 #14009
Conversation
Shows additional metric properties like category.
Fix swagger correctness issues with 2018-01-01 metricDefinitions API Also add an extra example
Hi, @ToddKingMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Hi @ToddKingMSFT, Your PR has some issues. Please fix the CI sequentially by following the order of
|
NewApiVersionRequired reason: |
Hi @ToddKingMSFT, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
I've filled out the breaking change intake form here: https://msazure.visualstudio.com/One/_workitems/edit/9767874 |
@kairu-ms Can you help me understand what more I need to do to complete this PR? It looks like the SDK gated checks for the monitor folder have been failing for a while. I am in talks with the track2 folks around the SDK generation for these swaggers but these are pre-existing failures and I'm trying to update our swagger documentation to reflect the reality of what our service is doing today. |
@jianyexi to confirm whether sdk track 2 validation is false alarm or not |
It's false alarm , the errors are existing before this PR, but there is a little difference in this PR so they can not be filtered. |
/azp run |
…stable/2018-01-01 (Azure#14009) * Fix swagger correctness issues with 2017-05-01-preview metricdefinitions * Fix swagger correctness issues with 2017-05-01-preview metrics API * Fix swagger correctness issues with 2017-12-01-preview metricNamespaces API * Update 2017-12-01-preview metricNamespaces example * Fix swagger correctness issues with 2016-09-01 metricDefinitions API * Fix swagger correctness issues with 2016-09-01 metrics API * Add additional 2018-01-01 metricDefinitions API example Shows additional metric properties like category. * Fix swagger correctness issues with 2018-01-01 metricDefinitions API Fix swagger correctness issues with 2018-01-01 metricDefinitions API Also add an extra example * Fix swagger correctness issues with 2018-01-01 metrics API * Remove extra forward slash from 2016-03-01 metricDefinitions example * Remove extra forward slash from 2016-03-01 metricDefinitions filtered example * Remove forward slash from 2016-09-01 metrics example * Remove forward slash from 2016-09-01 metrics filtered example * Update 2017-05-01-preview example with current values * Update 2017-05-01-preview metric metadata example * Remove isMetadataCustom property from example * Clarified some comments in 2018-01-01 metrics API * Fix example in 2018-01-01 metrics metadata API * Fix example and comments in 2017-05-01-preview metrics API * Update 2017-05-01-preview get metric metradata example * Fix formatting issues with 2017-05-01-preview metrics API * Fix formatting issues with 2017-12-01-preview metricNamespaces API * Fix formatting issues with 2018-01-01 metrics API * Add displayDescription to 2018-01-01 metrics API example
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.