Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added stable version of synapse dataplane APIs #14033

Merged
merged 21 commits into from
Jun 8, 2021
Merged

Added stable version of synapse dataplane APIs #14033

merged 21 commits into from
Jun 8, 2021

Conversation

xolve
Copy link
Contributor

@xolve xolve commented Apr 20, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @xolve Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 111 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Synapse/stable/2020-12-01/artifacts.json#L3450
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Synapse/stable/2020-12-01/artifacts.json#L3571
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Synapse/stable/2020-12-01/artifacts.json#L3589
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Synapse/stable/2020-12-01/artifacts.json#L3636
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Synapse/stable/2020-12-01/artifacts.json#L3654
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Synapse/stable/2020-12-01/artifacts.json#L3706
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Synapse/stable/2020-12-01/artifacts.json#L3745
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Synapse/stable/2020-12-01/artifacts.json#L3797
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Synapse/stable/2020-12-01/artifacts.json#L3816
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Synapse/stable/2020-12-01/artifacts.json#L3953
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ CIRCULAR_REFERENCE The JSON file has a circular reference.
    readme: specification/synapse/data-plane/readme.md
    json: stable/2020-12-01/entityTypes/Pipeline.json
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 41 Errors, 0 Warnings failed [Detail]
    The following breaking changes are detected by comparison with latest preview version:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/notebooks/summary' removed or restructured?
    Old: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L2429:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/batches' removed or restructured?
    Old: Microsoft.Synapse/preview/2019-11-01-preview/sparkJob.json#L35:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/batches/{batchId}' removed or restructured?
    Old: Microsoft.Synapse/preview/2019-11-01-preview/sparkJob.json#L132:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/sessions' removed or restructured?
    Old: Microsoft.Synapse/preview/2019-11-01-preview/sparkJob.json#L210:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/sessions/{sessionId}' removed or restructured?
    Old: Microsoft.Synapse/preview/2019-11-01-preview/sparkJob.json#L307:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/sessions/{sessionId}/reset-timeout' removed or restructured?
    Old: Microsoft.Synapse/preview/2019-11-01-preview/sparkJob.json#L385:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/sessions/{sessionId}/statements' removed or restructured?
    Old: Microsoft.Synapse/preview/2019-11-01-preview/sparkJob.json#L420:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/sessions/{sessionId}/statements/{statementId}' removed or restructured?
    Old: Microsoft.Synapse/preview/2019-11-01-preview/sparkJob.json#L503:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/sessions/{sessionId}/statements/{statementId}/cancel' removed or restructured?
    Old: Microsoft.Synapse/preview/2019-11-01-preview/sparkJob.json#L549:5
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'RoleIdParameter' removed or renamed?
    New: Microsoft.Synapse/stable/2020-12-01/roleAssignments.json#L288:3
    Old: Microsoft.Synapse/preview/2020-08-01-preview/roleAssignments.json#L341:3
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ Modeler/MissingType "readme":"synapse/data-plane/readme.md",
    "tag":"package-artifacts-2020-12-01",
    "details":"The schema 'NotebookCellOutputItem-text' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Notebook.json#/components/schemas/NotebookCellOutputItem-text"
    💬 AutorestCore/Exception "readme":"synapse/data-plane/readme.md",
    "tag":"package-artifacts-2020-12-01",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
    💬 AutorestCore/Exception "readme":"synapse/data-plane/readme.md",
    "tag":"package-artifacts-2020-12-01",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"synapse/data-plane/readme.md",
    "tag":"package-artifacts-2020-12-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"synapse/data-plane/readme.md",
    "tag":"package-monitoring-2020-12-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"synapse/data-plane/readme.md",
    "tag":"package-monitoring-2020-12-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"synapse/data-plane/readme.md",
    "tag":"package-access-control-2020-12-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"synapse/data-plane/readme.md",
    "tag":"package-access-control-2020-12-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"synapse/data-plane/readme.md",
    "tag":"package-vnet-2020-12-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"synapse/data-plane/readme.md",
    "tag":"package-vnet-2020-12-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2021 •
    edited
    Loading

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-workflow-bot
    Copy link

    Hi @xolve, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-workflow-bot
    Copy link

    Hi @xolve, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @xolve xolve requested a review from ruowan May 13, 2021 17:34
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 13, 2021
    @ruowan
    Copy link
    Member

    ruowan commented May 14, 2021

    @jianyexi Could you help to take a look at this PR? look autorest failed due to the model conflict.

    jianyexi
    jianyexi reviewed May 14, 2021
    View reviewed changes
    specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/roleAssignments.json Outdated
    }
    }
    },
    "ErrorResponse": {
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This has conflict with "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse", please use the latter one .

    Copy link
    Contributor Author

    @xolve xolve May 14, 2021 •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks @jianyexi for relative path to exact type. I get the error:

    UnhandledPromiseRejectionWarning: Error: '$.definitions.ErrorResponse.title' has incompatible values

    The exception trace around it isn't very helpful. Can you please check on it.

    @idear1203
    Copy link
    Contributor

    This is data plane API. @lmazuel , could you please help with a review?

    idear1203
    idear1203 reviewed May 20, 2021
    View reviewed changes
    specification/synapse/data-plane/readme.md Outdated
    Comment on lines 121 to 151
    ### Tag: package-monitoring-2020-12-01

    These settings apply only when `--tag=package-monitoring-2020-12-01` is specified on the command line.

    ``` yaml $(tag) == 'package-artifacts-2020-12-01'
    input-file:
    - Microsoft.Synapse/stable/2020-12-01/artifacts.json
    - Microsoft.Synapse/stable/2020-12-01/bigDataPools.json
    - Microsoft.Synapse/stable/2020-12-01/checkAccessSynapseRbac.json
    - Microsoft.Synapse/stable/2020-12-01/gitintegration.json
    - Microsoft.Synapse/stable/2020-12-01/integrationRuntimes.json
    - Microsoft.Synapse/stable/2020-12-01/library.json
    - Microsoft.Synapse/stable/2020-12-01/managedPrivateEndpoints.json
    - Microsoft.Synapse/stable/2020-12-01/monitoring.json
    - Microsoft.Synapse/stable/2020-12-01/operations.json
    - Microsoft.Synapse/stable/2020-12-01/roleAssignments.json
    - Microsoft.Synapse/stable/2020-12-01/roleDefinitions.json
    - Microsoft.Synapse/stable/2020-12-01/roles.json
    - Microsoft.Synapse/stable/2020-12-01/sparkJob.json
    - Microsoft.Synapse/stable/2020-12-01/sqlPools.json
    - Microsoft.Synapse/stable/2020-12-01/workspace.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/DataFlow.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/Dataset.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/LinkedService.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/Notebook.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/SparkJobDefinition.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/SqlScript.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/Trigger.json
    ```

    Copy link
    Contributor

    @idear1203 idear1203 May 20, 2021 •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    ### Tag: package-monitoring-2020-12-01
    These settings apply only when `--tag=package-monitoring-2020-12-01` is specified on the command line.
    ``` yaml $(tag) == 'package-artifacts-2020-12-01'
    input-file:
    - Microsoft.Synapse/stable/2020-12-01/artifacts.json
    - Microsoft.Synapse/stable/2020-12-01/bigDataPools.json
    - Microsoft.Synapse/stable/2020-12-01/checkAccessSynapseRbac.json
    - Microsoft.Synapse/stable/2020-12-01/gitintegration.json
    - Microsoft.Synapse/stable/2020-12-01/integrationRuntimes.json
    - Microsoft.Synapse/stable/2020-12-01/library.json
    - Microsoft.Synapse/stable/2020-12-01/managedPrivateEndpoints.json
    - Microsoft.Synapse/stable/2020-12-01/monitoring.json
    - Microsoft.Synapse/stable/2020-12-01/operations.json
    - Microsoft.Synapse/stable/2020-12-01/roleAssignments.json
    - Microsoft.Synapse/stable/2020-12-01/roleDefinitions.json
    - Microsoft.Synapse/stable/2020-12-01/roles.json
    - Microsoft.Synapse/stable/2020-12-01/sparkJob.json
    - Microsoft.Synapse/stable/2020-12-01/sqlPools.json
    - Microsoft.Synapse/stable/2020-12-01/workspace.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/DataFlow.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/Dataset.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/LinkedService.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/Notebook.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/SparkJobDefinition.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/SqlScript.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/Trigger.json
    ```
    ### Tag: package-monitoring-2020-12-01
    These settings apply only when `--tag=package-monitoring-2020-12-01` is specified on the command line.
    ``` yaml $(tag) == 'package-artifacts-2020-12-01'
    input-file:
    - Microsoft.Synapse/stable/2020-12-01/artifacts.json
    - Microsoft.Synapse/stable/2020-12-01/bigDataPools.json
    - Microsoft.Synapse/stable/2020-12-01/checkAccessSynapseRbac.json
    - Microsoft.Synapse/stable/2020-12-01/gitintegration.json
    - Microsoft.Synapse/stable/2020-12-01/integrationRuntimes.json
    - Microsoft.Synapse/stable/2020-12-01/library.json
    - Microsoft.Synapse/stable/2020-12-01/managedPrivateEndpoints.json
    - Microsoft.Synapse/stable/2020-12-01/monitoring.json
    - Microsoft.Synapse/stable/2020-12-01/operations.json
    - Microsoft.Synapse/stable/2020-12-01/roleAssignments.json
    - Microsoft.Synapse/stable/2020-12-01/roleDefinitions.json
    - Microsoft.Synapse/stable/2020-12-01/roles.json
    - Microsoft.Synapse/stable/2020-12-01/sparkJob.json
    - Microsoft.Synapse/stable/2020-12-01/sqlPools.json
    - Microsoft.Synapse/stable/2020-12-01/workspace.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/DataFlow.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/Dataset.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/LinkedService.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/Notebook.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/SparkJobDefinition.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/SqlScript.json
    - Microsoft.Synapse/stable/2020-12-01/entityTypes/Trigger.json

    Tag: package-artifacts-2020-12-01

    These settings apply only when --tag=package-artifacts-2020-12-01 is specified on the command line.

    input-file:
- Microsoft.Synapse/stable/2020-12-01/artifacts.json
- Microsoft.Synapse/stable/2020-12-01/bigDataPools.json
- Microsoft.Synapse/stable/2020-12-01/gitintegration.json
- Microsoft.Synapse/stable/2020-12-01/integrationRuntimes.json
- Microsoft.Synapse/stable/2020-12-01/library.json
- Microsoft.Synapse/stable/2020-12-01/operations.json
- Microsoft.Synapse/stable/2020-12-01/sparkJob.json
- Microsoft.Synapse/stable/2020-12-01/sqlPools.json
- Microsoft.Synapse/stable/2020-12-01/workspace.json
- Microsoft.Synapse/stable/2020-12-01/entityTypes/DataFlow.json
- Microsoft.Synapse/stable/2020-12-01/entityTypes/Dataset.json
- Microsoft.Synapse/stable/2020-12-01/entityTypes/LinkedService.json
- Microsoft.Synapse/stable/2020-12-01/entityTypes/Notebook.json
- Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json
- Microsoft.Synapse/stable/2020-12-01/entityTypes/SparkJobDefinition.json
- Microsoft.Synapse/stable/2020-12-01/entityTypes/SqlScript.json
- Microsoft.Synapse/stable/2020-12-01/entityTypes/Trigger.json

    Tag: package-access-control-2020-12-01

    These settings apply only when --tag=package-access-control-2020-12-01 is specified on the command line.

    - Microsoft.Synapse/stable/2020-12-01/checkAccessSynapseRbac.json
- Microsoft.Synapse/stable/2020-12-01/roleAssignments.json
- Microsoft.Synapse/stable/2020-12-01/roleDefinitions.json

    Tag: package-vnet-2020-12-01

    These settings apply only when --tag=package-vnet-2020-12-01 is specified on the command line.

    - Microsoft.Synapse/stable/2020-12-01/managedPrivateEndpoints.json

    Tag: package-monitoring-2020-12-01

    These settings apply only when --tag=package-monitoring-2020-12-01 is specified on the command line.

    - Microsoft.Synapse/stable/2020-12-01/monitoring.json

    idear1203
    idear1203 approved these changes May 25, 2021
    View reviewed changes
    Copy link
    Contributor

    @idear1203 idear1203 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Approved.

    @idear1203
    Copy link
    Contributor

    I have two questions:

    1. Has the new API version 2020-12-01 already been deployed worldwide?
    2. Despite the API version change, is there any other change between these files and original ones?

    @xolve
    Copy link
    Contributor Author

    xolve commented May 25, 2021 •
    edited
    Loading

    1. Has the new API version 2020-12-01 already been deployed worldwide?

    Yes.

    1. Despite the API version change, is there any other change between these files and original ones?

    No.

    @lmazuel lmazuel merged commit 01f98f0 into Azure:master Jun 8, 2021
    @heaths heaths mentioned this pull request Jun 16, 2021
    Merged
    asager pushed a commit to asager/azure-rest-api-specs that referenced this pull request Jun 24, 2021
    @xolve
    Added stable version of synapse dataplane APIs (Azure#14033)
    d8ff5c3 
    * Added stable version of dataplane APIs

* Added spec files to readme config.

* Remove unused example files.

* Fixes for checks.

* Fixes for checks.

* Fixes for checks.

* Remove duplicate schema.

* Fix formatting.

* Use ErrorResponse from common types.

* Remove redundant type ErrorContract.

* Added back ErrorContract with correct defintion, refering to common type in synapse commons.

* Fixed duplicate of libraryOperationResults, fix file placment of notebookOperationResults.

* Remove unused file.

* Use ErrorContract for error types.

* Renamed RoleIdParameter to RoleIdQueryParameter to avoid conflict.

* Use common hostname as other swagger files.

* Add missing API path parameters defintiions.

* Fix schema type for errors.

* Use ErrorContract from synapse common types.

* Use diff tags and titles for different packages.

* Remove deprecated roles.json spec.

Co-authored-by: Ravi Arora <raviarora@microsoft.com>
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @xolve @mkarmark
    Added stable version of synapse dataplane APIs (Azure#14033)
    c407127 
    * Added stable version of dataplane APIs

* Added spec files to readme config.

* Remove unused example files.

* Fixes for checks.

* Fixes for checks.

* Fixes for checks.

* Remove duplicate schema.

* Fix formatting.

* Use ErrorResponse from common types.

* Remove redundant type ErrorContract.

* Added back ErrorContract with correct defintion, refering to common type in synapse commons.

* Fixed duplicate of libraryOperationResults, fix file placment of notebookOperationResults.

* Remove unused file.

* Use ErrorContract for error types.

* Renamed RoleIdParameter to RoleIdQueryParameter to avoid conflict.

* Use common hostname as other swagger files.

* Add missing API path parameters defintiions.

* Fix schema type for errors.

* Use ErrorContract from synapse common types.

* Use diff tags and titles for different packages.

* Remove deprecated roles.json spec.

Co-authored-by: Ravi Arora <raviarora@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jianyexi jianyexi jianyexi left review comments

    @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

    @idear1203 idear1203 idear1203 approved these changes

    @ruowan ruowan Awaiting requested review from ruowan

    Assignees

    @lmazuel lmazuel

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-FixRequiredOnFailure
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @xolve @ruowan @idear1203 @JeffreyRichter @jianyexi @lmazuel