Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory] Improve enum with object type in LS and DS swagger #14160

Merged
merged 7 commits into from
May 12, 2021
Merged

[DataFactory] Improve enum with object type in LS and DS swagger #14160

merged 7 commits into from
May 12, 2021

Conversation

Jingshu923
Copy link
Contributor

@Jingshu923 Jingshu923 commented Apr 28, 2021

https://portal.azure-devex-tools.com/amekpis/linting/detail?errorId=FAAD063F-F2D0-4D71-901E-EC259C627EB8
https://portal.azure-devex-tools.com/amekpis/linting/detail?errorId=4394BD41-F5A8-45DC-B526-4F915203EF9D

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@Jingshu923 Jingshu923 requested a review from zhangyd2015 as a code owner April 28, 2021 07:40
@openapi-workflow-bot
Copy link

Hi, @Jingshu923 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 28, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 28, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️⌛[Staging] SDK Breaking Change Tracking pending [Detail]
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f61fbd3. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datafactory/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.DataFactory [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f61fbd3. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-datafactory [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model IntegrationRuntimeSsisProperties has a new parameter managed_credential
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter always_encrypted_settings
      info	[Changelog]   - Model ExcelDataset has a new parameter sheet_index
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter always_encrypted_settings
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter always_encrypted_settings
      info	[Changelog]   - Added operation group PrivateEndpointConnectionOperations
      info	[Changelog]   - Added operation group PrivateEndPointConnectionsOperations
      info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Parameter type of model MappingDataFlow is now required
      info	[Changelog]   - Parameter type of model DataFlow is now required
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f61fbd3. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-05-24 02:52:29 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-datafactory;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-05-24 02:52:29 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-05-24 02:52:29 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.28 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/datafactory/azure-resourcemanager-datafactory --java.namespace=com.azure.resourcemanager.datafactory   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/datafactory/resource-manager/readme.md
      cmderr	[generate.py] ERROR (FluentGen): Failed to successfully run fluentgen plugin java.lang.IllegalArgumentException: discriminator not found in type ManagedVirtualNetwork and its parents
      cmderr	[generate.py] java.lang.IllegalArgumentException: discriminator not found in type ManagedVirtualNetwork and its parents
      cmderr	[generate.py] 	at com.azure.autorest.util.SchemaUtil.getDiscriminatorSerializedName(SchemaUtil.java:101)
      cmderr	[generate.py] 	at com.azure.autorest.mapper.ModelMapper.map(ModelMapper.java:165)
      cmderr	[generate.py] 	at com.azure.autorest.mapper.ClientMapper.lambda$map$5(ClientMapper.java:100)
      cmderr	[generate.py] 	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
      cmderr	[generate.py] 	at java.base/java.util.stream.DistinctOps$1$2.accept(DistinctOps.java:175)
      cmderr	[generate.py] 	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1655)
      cmderr	[generate.py] 	at java.base/java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:734)
      cmderr	[generate.py] 	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
      cmderr	[generate.py] 	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
      cmderr	[generate.py] 	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
      cmderr	[generate.py] 	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
      cmderr	[generate.py] 	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
      cmderr	[generate.py] 	at com.azure.autorest.mapper.ClientMapper.map(ClientMapper.java:103)
      cmderr	[generate.py] 	at com.azure.autorest.fluent.FluentGen.handleMap(FluentGen.java:145)
      cmderr	[generate.py] 	at com.azure.autorest.fluent.FluentGen.processInternal(FluentGen.java:86)
      cmderr	[generate.py] 	at com.azure.autorest.extension.base.plugin.NewPlugin.process(NewPlugin.java:202)
      cmderr	[generate.py] 	at com.azure.autorest.fluent.Main.lambda$main$1(Main.java:18)
      cmderr	[generate.py] 	at com.azure.autorest.extension.base.jsonrpc.Connection.lambda$dispatch$2(Connection.java:151)
      cmderr	[generate.py] 	at com.azure.autorest.extension.base.jsonrpc.Connection.lambda$process$3(Connection.java:270)
      cmderr	[generate.py] 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
      cmderr	[generate.py] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
      cmderr	[generate.py] 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
      cmderr	[generate.py] 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
      cmderr	[generate.py] 	at java.base/java.lang.Thread.run(Thread.java:829)
      cmderr	[generate.py] FATAL (FluentGen): Unhandled error: discriminator not found in type ManagedVirtualNetwork and its parents
      cmderr	[generate.py] java.lang.IllegalArgumentException: discriminator not found in type ManagedVirtualNetwork and its parents
      cmderr	[generate.py] 	at com.azure.autorest.util.SchemaUtil.getDiscriminatorSerializedName(SchemaUtil.java:101)
      cmderr	[generate.py] 	at com.azure.autorest.mapper.ModelMapper.map(ModelMapper.java:165)
      cmderr	[generate.py] 	at com.azure.autorest.mapper.ClientMapper.lambda$map$5(ClientMapper.java:100)
      cmderr	[generate.py] 	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
      cmderr	[generate.py] 	at java.base/java.util.stream.DistinctOps$1$2.accept(DistinctOps.java:175)
      cmderr	[generate.py] 	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1655)
      cmderr	[generate.py] 	at java.base/java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:734)
      cmderr	[generate.py] 	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
      cmderr	[generate.py] 	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
      cmderr	[generate.py] 	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
      cmderr	[generate.py] 	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
      cmderr	[generate.py] 	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
      cmderr	[generate.py] 	at com.azure.autorest.mapper.ClientMapper.map(ClientMapper.java:103)
      cmderr	[generate.py] 	at com.azure.autorest.fluent.FluentGen.handleMap(FluentGen.java:145)
      cmderr	[generate.py] 	at com.azure.autorest.fluent.FluentGen.processInternal(FluentGen.java:86)
      cmderr	[generate.py] 	at com.azure.autorest.extension.base.plugin.NewPlugin.process(NewPlugin.java:202)
      cmderr	[generate.py] 	at com.azure.autorest.fluent.Main.lambda$main$1(Main.java:18)
      cmderr	[generate.py] 	at com.azure.autorest.extension.base.jsonrpc.Connection.lambda$dispatch$2(Connection.java:151)
      cmderr	[generate.py] 	at com.azure.autorest.extension.base.jsonrpc.Connection.lambda$process$3(Connection.java:270)
      cmderr	[generate.py] 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
      cmderr	[generate.py] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
      cmderr	[generate.py] 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
      cmderr	[generate.py] 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
      cmderr	[generate.py] 	at java.base/java.lang.Thread.run(Thread.java:829)
      cmderr	[generate.py]   Error: Plugin fluentgen reported failure.
      cmderr	[generate.py] 2021-05-24 02:53:58 ERROR [GENERATE] Autorest fail
      cmderr	[generate.py] 2021-05-24 02:55:18 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-datafactory [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-05-24 02:56:44 DEBUG Got artifact_id: azure-resourcemanager-datafactory
      cmderr	[Inst] 2021-05-24 02:56:44 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-05-24 02:56:44 ERROR Unmatch any jar in artifacts
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f61fbd3. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️datafactory/mgmt/2018-06-01/datafactory [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 60 items here, please refer to log for details.
      info	[Changelog] - New const `TypeHTTPSource`
      info	[Changelog] - New const `TypeCouchbase`
      info	[Changelog] - New const `Monday`
      info	[Changelog] - New const `TypeAzureBlobStorageLocation`
      info	[Changelog] - New const `TypeSalesforceSink`
      info	[Changelog] - New const `TypeShopify`
      info	[Changelog] - New const `TypeXMLReadSettings`
      info	[Changelog] - New const `AuthenticationTypeWebLinkedServiceTypeProperties`
      info	[Changelog] - New const `Int`
      info	[Changelog] - New const `TypeSapCloudForCustomerSource`
      info	[Changelog] - New const `POST`
      info	[Changelog] - New const `TypeXeroSource`
      info	[Changelog] - New const `TypeAzureSearchIndexSink`
      info	[Changelog] - New const `TypeAzureBlobFSWriteSettings`
      info	[Changelog] - New const `TypeAzureTableSource`
      info	[Changelog] - New const `TypeAzureBlobFS`
      info	[Changelog] - New const `Percentage`
      info	[Changelog] - New const `TypeMarketo`
      info	[Changelog] - New const `TypeAzureMLUpdateResource`
      info	[Changelog] - New const `TypeAzureMLExecutePipeline`
      info	[Changelog] - New const `TypeOracleSink`
      info	[Changelog] - New const `ComputeOptimized`
      info	[Changelog] - New const `TypeSharePointOnlineList`
      info	[Changelog] - New const `TypeXeroObject`
      info	[Changelog] - New const `TypeMongoDbAtlasSink`
      info	[Changelog] - New const `TypeOracleCloudStorageLocation`
      info	[Changelog] - New const `String`
      info	[Changelog] - New const `TypeMicrosoftAccess`
      info	[Changelog] - New const `OnPremisesWithIfd`
      info	[Changelog] - New const `TypeExecutePipeline`
      info	[Changelog] - New const `TypeInformixSource`
      info	[Changelog] - New const `TypeBinary`
      info	[Changelog] - New const `TypeSQLDWSink`
      info	[Changelog] - New const `TypeSalesforceObject`
      info	[Changelog] - New const `LatestOnly`
      info	[Changelog] - New const `TypeAzureDataExplorerSource`
      info	[Changelog] - New const `TypeMariaDBTable`
      info	[Changelog] - New const `TypeOrcFormat`
      info	[Changelog] - New const `TypeMicrosoftAccessTable`
      info	[Changelog] - New const `AuthKey1`
      info	[Changelog] - New const `TypeDatasetLocation`
      info	[Changelog] - New const `Deflate`
      info	[Changelog] - New const `Gateway`
      info	[Changelog] - New const `TypeDynamicsCrmEntity`
      info	[Changelog] - New const `TypeStoreWriteSettings`
      info	[Changelog] - New const `TypeSapHanaTable`
      info	[Changelog] - New const `TypeSalesforceServiceCloudSource`
      info	[Changelog] - New const `TypeSalesforceMarketingCloudObject`
      info	[Changelog] - New const `MicrosoftStorageBlobCreated`
      info	[Changelog] - New const `TypeUntil`
      info	[Changelog] - New function `PossibleJSONFormatFilePatternValues() []JSONFormatFilePattern`
      info	[Changelog] - New function `PossibleServicePrincipalCredentialTypeValues() []ServicePrincipalCredentialType`
      info	[Changelog] - New function `PossibleDatasetCompressionLevelValues() []DatasetCompressionLevel`
      info	[Changelog] - New function `PossibleHdiNodeTypesValues() []HdiNodeTypes`
      info	[Changelog] - New function `PossibleCompressionCodecValues() []CompressionCodec`
      info	[Changelog] - New field `SheetIndex` in struct `ExcelDatasetTypeProperties`
      info	[Changelog] - New field `ManagedCredential` in struct `IntegrationRuntimeSsisProperties`
      info	[Changelog]
      info	[Changelog] Total 621 breaking change(s), 645 additive change(s).
      info	[Changelog]
    • ️✔️preview/datafactory/mgmt/2017-09-01-preview/datafactory [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f61fbd3. Azure CLI Automation 14.0.0
      Only show 120 items here, please refer to log for details.
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ForEachActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureMLBatchExecutionActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureMLBatchExecutionActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureMLUpdateResourceActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureMLUpdateResourceActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureMLExecutePipelineActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureMLExecutePipelineActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DataLakeAnalyticsUSQLActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DataLakeAnalyticsUSQLActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'WaitActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'WaitActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'UntilActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'UntilActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ValidationActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ValidationActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'FilterActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'FilterActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DatabricksNotebookActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DatabricksNotebookActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DatabricksSparkJarActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DatabricksSparkJarActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DatabricksSparkPythonActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DatabricksSparkPythonActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'SetVariableActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'SetVariableActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AppendVariableActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AppendVariableActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureFunctionActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureFunctionActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'WebHookActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'WebHookActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ExecuteDataFlowActivity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ExecuteDataFlowActivityTypeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MultiplePipelineTrigger' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ScheduleTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'BlobTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'BlobEventsTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CustomEventsTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'TumblingWindowTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'RetryPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'RerunTumblingWindowTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ChainingTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmdout	[Autorest] WARNING (PreCheck/DuplicateSchema): Duplicate Schema named BlobEventTypes -- type: undefined => "string",items: {"$ref":"#/components/schemas/BlobEventTypes"} => <none>,enum: undefined => ["Microsoft.Storage.BlobCreated","Microsoft.Storage.BlobDeleted"],x-ms-enum: undefined => {"name":"BlobEventTypes","modelAsString":true}
      cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
      cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
      cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      cmdout	[Autorest] WARNING:  newAzName:linked-integration-runtime create
      cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
      cmderr	[Autorest] --------------------------------------------------------
      cmderr	[Autorest]   test-scenario:
      cmderr	[Autorest]     - name: /Factories/put/Factories_CreateOrUpdate
      cmderr	[Autorest]     - name: /Factories/get/Factories_Get
      cmderr	[Autorest]     - name: /Factories/get/Factories_List
      cmderr	[Autorest]     - name: /Factories/get/Factories_ListByResourceGroup
      cmderr	[Autorest]     - name: /Factories/patch/Factories_Update
      cmderr	[Autorest]     - name: /Factories/post/Factories_ConfigureFactoryRepo
      cmderr	[Autorest]     - name: /Factories/post/Factories_GetDataPlaneAccess
      cmderr	[Autorest]     - name: /Factories/post/Factories_GetGitHubAccessToken
      cmderr	[Autorest]     - name: /ActivityRuns/post/ActivityRuns_QueryByPipelineRun
      cmderr	[Autorest]     - name: /Datasets/put/Datasets_Create
      cmderr	[Autorest]     - name: /Datasets/put/Datasets_Update
      cmderr	[Autorest]     - name: /Datasets/get/Datasets_Get
      cmderr	[Autorest]     - name: /Datasets/get/Datasets_ListByFactory
      cmderr	[Autorest]     - name: /Datasets/delete/Datasets_Delete
      cmderr	[Autorest]     - name: /IntegrationRuntimes/put/IntegrationRuntimes_Create
      cmderr	[Autorest]     - name: /IntegrationRuntimes/get/IntegrationRuntimes_Get
      cmderr	[Autorest]     - name: /IntegrationRuntimes/get/IntegrationRuntimes_ListByFactory
      cmderr	[Autorest]     - name: /IntegrationRuntimes/patch/IntegrationRuntimes_Update
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_CreateLinkedIntegrationRuntime
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_GetConnectionInfo
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_GetMonitoringData
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_GetStatus
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_ListAuthKeys
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_RegenerateAuthKey
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_Start
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_Stop
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_SyncCredentials
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_Upgrade
      cmderr	[Autorest]     - name: /IntegrationRuntimes/post/IntegrationRuntimes_Upgrade
      cmderr	[Autorest]     - name: /IntegrationRuntimeNodes/get/IntegrationRuntimeNodes_Get
      cmderr	[Autorest]     - name: /IntegrationRuntimeNodes/patch/IntegrationRuntimeNodes_Update
      cmderr	[Autorest]     - name: /IntegrationRuntimeNodes/post/IntegrationRuntimeNodes_GetIpAddress
      cmderr	[Autorest]     - name: /IntegrationRuntimeNodes/delete/IntegrationRuntimesNodes_Delete
      cmderr	[Autorest]     - name: /IntegrationRuntimes/delete/IntegrationRuntimes_Delete
      cmderr	[Autorest]     - name: /LinkedServices/put/LinkedServices_Create
      cmderr	[Autorest]     - name: /LinkedServices/put/LinkedServices_Update
      cmderr	[Autorest]     - name: /LinkedServices/get/LinkedServices_Get
      cmderr	[Autorest]     - name: /LinkedServices/get/LinkedServices_ListByFactory
      cmderr	[Autorest]     - name: /LinkedServices/delete/LinkedServices_Delete
      cmderr	[Autorest]     - name: /PipelineRuns/get/PipelineRuns_Get
      cmderr	[Autorest]     - name: /PipelineRuns/post/PipelineRuns_Cancel
      cmderr	[Autorest]     - name: /PipelineRuns/post/PipelineRuns_QueryByFactory
      cmderr	[Autorest]     - name: /Pipelines/put/Pipelines_Create
      cmderr	[Autorest]     - name: /Pipelines/put/Pipelines_Update
      cmderr	[Autorest]     - name: /Pipelines/get/Pipelines_Get
      cmderr	[Autorest]     - name: /Pipelines/get/Pipelines_ListByFactory
      cmderr	[Autorest]     - name: /Pipelines/post/Pipelines_CreateRun
      cmderr	[Autorest]     - name: /Pipelines/delete/Pipelines_Delete
      cmderr	[Autorest]     - name: /privateEndPointConnections/get/privateEndPointConnections_ListByFactory
      cmderr	[Autorest]     - name: /PrivateEndpointConnection/put/Approves or rejects a private endpoint connection for a factory.
      cmderr	[Autorest]     - name: /PrivateEndpointConnection/get/Get a private endpoint connection for a datafactory.
      cmderr	[Autorest]     - name: /PrivateEndpointConnection/delete/Delete a private endpoint connection for a datafactory.
      cmderr	[Autorest]     - name: /privateLinkResources/get/Get private link resources of a site
      cmderr	[Autorest]     - name: /Triggers/put/Triggers_Create
      cmderr	[Autorest]     - name: /Triggers/put/Triggers_Update
      cmderr	[Autorest]     - name: /Triggers/get/Triggers_Get
      cmderr	[Autorest]     - name: /Triggers/get/Triggers_ListByFactory
      cmderr	[Autorest]     - name: /Triggers/post/Triggers_GetEventSubscriptionStatus
      cmderr	[Autorest]     - name: /Triggers/post/Triggers_QueryByFactory
      cmderr	[Autorest]     - name: /Triggers/post/Triggers_Start
      cmderr	[Autorest]     - name: /Triggers/post/Triggers_Stop
      cmderr	[Autorest]     - name: /Triggers/post/Triggers_SubscribeToEvents
      cmderr	[Autorest]     - name: /Triggers/post/Triggers_UnsubscribeFromEvents
      cmderr	[Autorest]     - name: /TriggerRuns/post/TriggerRuns_QueryByFactory
      cmderr	[Autorest]     - name: /TriggerRuns/post/Triggers_Cancel
      cmderr	[Autorest]     - name: /TriggerRuns/post/Triggers_Rerun
      cmderr	[Autorest]     - name: /Triggers/delete/Triggers_Delete
      cmderr	[Autorest]     - name: /Factories/delete/Factories_Delete
      cmderr	[Autorest] --------------------------------------------------------
    • ️✔️datafactory [View full logs]  [Release Azure CLI Changes]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f61fbd3. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️datafactory [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @Jingshu923, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @Jingshu923
    Copy link
    Contributor Author

    @qianwens Could you please help to see who can review this pr?

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 11, 2021
    @RAY-316
    Copy link
    Contributor

    RAY-316 commented May 24, 2021

    /azp run

    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    …re#14160)
    
    * [DataFactory] Improve enum with object type in LS and DS swagger
    
    * Add 1 change
    
    * Update 2
    
    * Fix errors
    
    * Revert "Fix errors"
    
    This reverts commit b94a5f3.
    
    * Fix one
    
    * Fix comments
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go FixS360
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants