Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove regex requirement for PrivateEndpointConnection name #14177

Merged
merged 1 commit into from
May 5, 2021
Merged

Remove regex requirement for PrivateEndpointConnection name #14177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions specification/iothub/resource-manager/Microsoft.Devices/stable/2020-03-01/iothub.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2578,8 +2578,7 @@
"name": {
"readOnly": true,
"type": "string",
"description": "The resource name.",
"pattern": "^(?![0-9]+$)(?!-)[a-zA-Z0-9-]{2,49}[a-zA-Z0-9]$"
"description": "The resource name."
},
"type": {
"readOnly": true,
Expand Down Expand Up @@ -2638,8 +2637,7 @@
"name": {
"readOnly": true,
"type": "string",
"description": "The resource name.",
"pattern": "^(?![0-9]+$)(?!-)[a-zA-Z0-9-]{2,49}[a-zA-Z0-9]$"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been flagged as a breaking change, but it really isn't.

  1. The validation is flawed, and fails a customer request when it shouldn't. One option is updating the validation, but that leads me to Restructure folder naming scheme and update the readme #2.
  2. The property is read-only. The user can't set it, so no validation is necessary.

We have a blocked customers impacted by this issue, and we'd like to push this through so we can issue an SDK update ASAP.

"description": "The resource name."
},
"type": {
"readOnly": true,
Expand Down