-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2021-04-01 SRP api version #14211
Conversation
… share with leased snapshot; lease share; share ACLs; list both deleted shares and snapshots; allow cross tenant replication; default share permission)
…ions, updated examples
Hi, @HimanshuChhabra Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Original Pull request #14038 |
Hi, @HimanshuChhabra your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @Juliehzl |
Server readiness to support the new API version is available on all clouds. Features will be enabled as and when PMs flag to do so across regions |
/azp run |
* Create 2021-04-01 SRP api version, no features * Adding Blob Inventory GA Swagger changes and examples * Add Container VLW Swagger changes * Add Lease Share (Commit 1204774b: Merged PR 4370500: Swagger: deleted share with leased snapshot; lease share; share ACLs; list both deleted shares and snapshots; allow cross tenant replication; default share permission) * Add custom-words, Add default responses for new apis * Capitalize VNet rule state * Update Descriptions for the Blob Inventory Properties. * Address Description change to make BI schema fields value Name as always required. * Update BI descrption * Add 201, 202 response types to FileshareLease Acquire and Break functions, updated examples * Update pending readme files, correct spellcheck in file.json * Add LeaseShareRequest model as string and x-ms-longrunning * Add long running tag to vlw migrate api, remove 202,201, long running tag from FileLeaseShare * Change VLW migration PUT to POST, Add longrunning tag to location, update blobInventory filter prefixMatch descr and removed required field, date-time format for Lease share * Change LastAccessedTime to LastAccess time schema field
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.