Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #14244

Merged
merged 2 commits into from
May 4, 2021
Merged

Fix broken links #14244

merged 2 commits into from
May 4, 2021

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented May 4, 2021

from : https://github.com/Azure/azure-rest-api-specs/pull/14197/files#

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@ghost ghost added the Compute label May 4, 2021
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 4, 2021

Swagger pipeline restarted successfully, please wait for status update in this comment.

@openapi-workflow-bot
Copy link

Hi, @Sandido Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 4, 2021

    Swagger Generation Artifacts

    ️⌛[Staging] ApiDocPreview pending [Detail]
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6e5f879. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Compute [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6e5f879. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model VirtualMachineScaleSetVM has a new parameter user_data
      info	[Changelog]   - Model VirtualMachineScaleSetUpdateVMProfile has a new parameter user_data
      info	[Changelog]   - Model VirtualMachineScaleSetNetworkProfile has a new parameter network_api_version
      info	[Changelog]   - Model VirtualMachineScaleSetPublicIPAddressConfiguration has a new parameter sku
      info	[Changelog]   - Model VirtualMachineScaleSetPublicIPAddressConfiguration has a new parameter delete_option
      info	[Changelog]   - Model DataDisk has a new parameter delete_option
      info	[Changelog]   - Model NetworkProfile has a new parameter network_api_version
      info	[Changelog]   - Model NetworkProfile has a new parameter network_interface_configurations
      info	[Changelog]   - Model VirtualMachineScaleSetUpdateNetworkConfiguration has a new parameter delete_option
      info	[Changelog]   - Model PatchSettings has a new parameter assessment_mode
      info	[Changelog]   - Model VirtualMachineScaleSetNetworkConfiguration has a new parameter delete_option
      info	[Changelog]   - Model LinuxPatchSettings has a new parameter assessment_mode
      info	[Changelog]   - Model NetworkInterfaceReference has a new parameter delete_option
      info	[Changelog]   - Model VirtualMachine has a new parameter user_data
      info	[Changelog]   - Model VirtualMachine has a new parameter scheduled_events_profile
      info	[Changelog]   - Model VirtualMachineScaleSetUpdateNetworkProfile has a new parameter network_api_version
      info	[Changelog]   - Model VirtualMachineScaleSetVMProfile has a new parameter user_data
      info	[Changelog]   - Model OSDisk has a new parameter delete_option
      info	[Changelog]   - Model VirtualMachineUpdate has a new parameter user_data
      info	[Changelog]   - Model VirtualMachineUpdate has a new parameter scheduled_events_profile
      info	[Changelog]   - Model VirtualMachineScaleSetUpdatePublicIPAddressConfiguration has a new parameter delete_option
      info	[Changelog]   - Added operation group RestorePointCollectionsOperations
      info	[Changelog]   - Added operation group RestorePointsOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation VirtualMachineScaleSetsOperations.get has a new signature
      info	[Changelog]   - Model PurchasePlan no longer has parameter promotion_code
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6e5f879. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️containerservice/mgmt/2017-01-31/containerservice [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️containerservice/mgmt/2016-09-30/containerservice [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️containerservice/mgmt/2016-03-30/containerservice [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2021-03-01/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `DeleteOption` in struct `VirtualMachineScaleSetUpdatePublicIPAddressConfigurationProperties`
      info	[Changelog] - New field `UserData` in struct `VirtualMachineScaleSetVMProperties`
      info	[Changelog] - New field `DeleteOption` in struct `NetworkInterfaceReferenceProperties`
      info	[Changelog]
      info	[Changelog] Total 11 breaking change(s), 343 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2020-12-01/compute [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2020-06-30/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog] - New field `GroupByUserAgent` in struct `ThrottledRequestsInput`
      info	[Changelog] - New field `GroupByClientApplicationID` in struct `ThrottledRequestsInput`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 9 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2020-06-01/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `EnableFpga` in struct `VirtualMachineScaleSetNetworkConfigurationProperties`
      info	[Changelog] - New field `GroupByUserAgent` in struct `RequestRateByIntervalInput`
      info	[Changelog] - New field `GroupByClientApplicationID` in struct `RequestRateByIntervalInput`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 9 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2019-12-01/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2019-07-01/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2019-03-01/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2018-10-01/compute [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2018-06-01/compute [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2018-04-01/compute [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-12-01/compute [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-09-01/skus [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-03-30/compute [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2016-03-30/compute [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2015-06-15/compute [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/containerservice/mgmt/2015-11-01-preview/containerservice [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/compute/mgmt/2020-10-01-preview/compute [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/compute/mgmt/2016-04-30-preview/compute [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6e5f879. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-05-04 20:56:43 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-compute-generated"
      cmderr	[generate.py] 2021-05-04 20:56:43 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-05-04 20:56:43 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.25 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/compute/azure-resourcemanager-compute-generated --java.namespace=com.azure.resourcemanager.compute.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[generate.py] 2021-05-04 20:58:30 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-05-04 20:58:30 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-05-04 20:58:30 INFO [POM][Skip] pom already has module azure-resourcemanager-compute-generated
      cmderr	[generate.py] 2021-05-04 20:58:30 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-05-04 20:58:30 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-05-04 20:58:30 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-compute-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-05-04 21:03:48 DEBUG Got artifact_id: azure-resourcemanager-compute-generated
      cmderr	[Inst] 2021-05-04 21:03:48 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-05-04 21:03:48 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-05-04 21:03:48 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-05-04 21:03:48 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-05-04 21:03:48 DEBUG Match jar package: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-05-04 21:03:48 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14244/azure-sdk-for-java/azure-resourcemanager-compute-generated/azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-compute-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-compute-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6e5f879. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/compute/resource-manager/readme.md
    • ️✔️@azure/arm-compute [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/computeManagementClient.js → ./dist/arm-compute.js...
      cmderr	[npmPack] created ./dist/arm-compute.js in 1.7s
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6e5f879. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @Sandido Sandido merged commit 6e5f879 into compute-2021-03-release May 4, 2021
    This was referenced May 4, 2021
    ArcturusZhang added a commit that referenced this pull request May 12, 2021
    * initial copy of files
    
    * API version updates
    
    * Deep deletion feature (#14232)
    
    * Deep deletion feature
    
    * Deep deletion cleanup
    
    * Deep deletion cleanup 2
    
    * Scheduled Events feature (#14233)
    
    * Scheduled Events feature
    
    * Scheduled Events feature example
    
    * PatchSetting Assessment Mode Windows + Linux (#14234)
    
    * PatchSetting assessment feature
    
    * PatchSetting assessment feature cleanup
    
    * Patchsetting example
    
    * Patchsetting example 2
    
    * Patchsetting example 3
    
    * Patchsetting example 4
    
    * Patchsetting example 5
    
    * Add network interface config schema to VM Network profile (#14235)
    
    * NIC feature
    
    * NIC example
    
    * Restore point and User Data features (#14243)
    
    * Restore point and User Data features
    
    * Restore Point cleanup
    
    * Restore point ex 1
    
    * restore point ex2
    
    * restore point ex 3
    
    * REstore point ex 4
    
    * restore point ex 5
    
    * restore point ex 6
    
    * restore point ex 7
    
    * restore point ex 8
    
    * restore point ex 9
    
    * restore point ex 10
    
    * restore point ex 11
    
    * restore point readme
    
    * user data feature cloudservice
    
    * user data ex 1
    
    * user data ex 2
    
    * user data ex 3
    
    * user data ex 4
    
    * user data ex 5
    
    * Fix broken links (#14244)
    
    * Remove unnecessary examples
    
    * fix conflict
    
    Co-authored-by: arcturusZhang <ufo54153@gmail.com>
    @Sandido Sandido deleted the adsandor/fixbrokenlinks branch June 7, 2021 20:16
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * initial copy of files
    
    * API version updates
    
    * Deep deletion feature (Azure#14232)
    
    * Deep deletion feature
    
    * Deep deletion cleanup
    
    * Deep deletion cleanup 2
    
    * Scheduled Events feature (Azure#14233)
    
    * Scheduled Events feature
    
    * Scheduled Events feature example
    
    * PatchSetting Assessment Mode Windows + Linux (Azure#14234)
    
    * PatchSetting assessment feature
    
    * PatchSetting assessment feature cleanup
    
    * Patchsetting example
    
    * Patchsetting example 2
    
    * Patchsetting example 3
    
    * Patchsetting example 4
    
    * Patchsetting example 5
    
    * Add network interface config schema to VM Network profile (Azure#14235)
    
    * NIC feature
    
    * NIC example
    
    * Restore point and User Data features (Azure#14243)
    
    * Restore point and User Data features
    
    * Restore Point cleanup
    
    * Restore point ex 1
    
    * restore point ex2
    
    * restore point ex 3
    
    * REstore point ex 4
    
    * restore point ex 5
    
    * restore point ex 6
    
    * restore point ex 7
    
    * restore point ex 8
    
    * restore point ex 9
    
    * restore point ex 10
    
    * restore point ex 11
    
    * restore point readme
    
    * user data feature cloudservice
    
    * user data ex 1
    
    * user data ex 2
    
    * user data ex 3
    
    * user data ex 4
    
    * user data ex 5
    
    * Fix broken links (Azure#14244)
    
    * Remove unnecessary examples
    
    * fix conflict
    
    Co-authored-by: arcturusZhang <ufo54153@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants