Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TDE api from v5 tag #14251

Merged
merged 3 commits into from
May 7, 2021
Merged

Remove TDE api from v5 tag #14251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01446e4
Remove TDE api from v5 tag
viparek May 5, 2021
59f12d9
Added back TDE apis
viparek May 5, 2021
1ada54e
Fix prettier related issue
viparek May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
149 changes: 149 additions & 0 deletions specification/sql/resource-manager/Microsoft.Sql/stable/2014-04-01/sql.core_legacy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,111 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/transparentDataEncryption/{transparentDataEncryptionName}": {
"put": {
"tags": [
"TransparentDataEncryption"
],
"operationId": "TransparentDataEncryptions_CreateOrUpdate",
"description": "Creates or updates a database's transparent data encryption configuration.",
"x-ms-examples": {
"Create or update a database's transparent data encryption configuration": {
"$ref": "./examples/DatabaseTransparentDataEncryptionCreateOrUpdate.json"
}
},
"parameters": [
{
"$ref": "../../../common/v1/types.json#/parameters/ApiVersionParameter"
},
{
"$ref": "../../../common/v1/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../common/v1/types.json#/parameters/ResourceGroupParameter"
},
{
"$ref": "#/parameters/ServerNameParameter"
},
{
"name": "databaseName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the database for which setting the transparent data encryption applies."
},
{
"$ref": "#/parameters/TransparentDataEncryptionNameParameter"
},
{
"name": "parameters",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/TransparentDataEncryption"
},
"description": "The required parameters for creating or updating transparent data encryption."
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/TransparentDataEncryption"
}
},
"201": {
"description": "Created",
"schema": {
"$ref": "#/definitions/TransparentDataEncryption"
}
}
}
},
"get": {
"tags": [
"TransparentDataEncryption"
],
"operationId": "TransparentDataEncryptions_Get",
"description": "Gets a database's transparent data encryption configuration.",
"x-ms-examples": {
"Get a database's transparent data encryption configuration": {
"$ref": "./examples/DatabaseTransparentDataEncryptionGet.json"
}
},
"parameters": [
{
"$ref": "../../../common/v1/types.json#/parameters/ApiVersionParameter"
},
{
"$ref": "../../../common/v1/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../common/v1/types.json#/parameters/ResourceGroupParameter"
},
{
"$ref": "#/parameters/ServerNameParameter"
},
{
"name": "databaseName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the database for which the transparent data encryption applies."
},
{
"$ref": "#/parameters/TransparentDataEncryptionNameParameter"
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/TransparentDataEncryption"
}
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/transparentDataEncryption/{transparentDataEncryptionName}/operationResults": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why put these API into sql.core.legacy.json. is there any other file something like transparentDataEncryption_legacy.json? and adding part is extract from where?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config for TransparentDataEncryption api was in the sql.core_legacy.json in the v4 tag, and in the v5 tag we were releasing a new version of this api so it's config was deleted from here. But since a few existing tests for this api are failing in .net sdk, we have decided to not release the new version. Hence adding this config back to revert to using an older and stable version of this api.

"get": {
"tags": [
Expand Down Expand Up @@ -442,6 +547,42 @@
],
"description": "Represents the response to a list elastic pool database activity request."
},
"TransparentDataEncryptionProperties": {
"properties": {
"status": {
"type": "string",
"description": "The status of the database transparent data encryption.",
"enum": [
"Enabled",
"Disabled"
],
"x-ms-enum": {
"name": "TransparentDataEncryptionStatus"
}
}
},
"description": "Represents the properties of a database transparent data encryption."
},
"TransparentDataEncryption": {
"properties": {
"location": {
"type": "string",
"readOnly": true,
"description": "Resource location."
},
"properties": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/TransparentDataEncryptionProperties",
"description": "Represents the properties of the resource."
}
},
"allOf": [
{
"$ref": "../../../common/v1/types.json#/definitions/ProxyResource"
}
],
"description": "Represents a database transparent data encryption configuration."
},
"SloUsageMetric": {
"properties": {
"serviceLevelObjective": {
Expand Down Expand Up @@ -633,6 +774,14 @@
"description": "The name of the server.",
"x-ms-parameter-location": "method"
},
"DatabaseExpandParameter": {
"name": "$expand",
"in": "query",
"required": false,
"type": "string",
"description": "A comma separated list of child objects to expand in the response. Possible properties: serviceTierAdvisors, transparentDataEncryption.",
"x-ms-parameter-location": "method"
},
"TransparentDataEncryptionNameParameter": {
"name": "transparentDataEncryptionName",
"in": "path",
Expand Down
1 change: 0 additions & 1 deletion specification/sql/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ input-file:
- ./Microsoft.Sql/preview/2020-11-01-preview/SyncMembers.json
- ./Microsoft.Sql/preview/2020-11-01-preview/TdeCertificates.json
- ./Microsoft.Sql/preview/2020-11-01-preview/TimeZones.json
- ./Microsoft.Sql/preview/2020-11-01-preview/TransparentDataEncryptions.json
- ./Microsoft.Sql/preview/2020-11-01-preview/VirtualClusters.json
- ./Microsoft.Sql/preview/2020-11-01-preview/VirtualNetworkRules.json
- ./Microsoft.Sql/preview/2020-11-01-preview/WorkloadClassifiers.json
Expand Down