Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureStack] [Admin API] ACR Admin swagger spec changes #14290

Merged
merged 28 commits into from
Jun 29, 2021
Merged

[AzureStack] [Admin API] ACR Admin swagger spec changes #14290

merged 28 commits into from
Jun 29, 2021

Conversation

larisaborodina
Copy link
Contributor

@larisaborodina larisaborodina commented May 6, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

rjaini and others added 4 commits April 13, 2021 12:18
* Add swagger spec for acr setup.

* Add swagger spec for acr setup - fixed jsons.

* Add swagger spec for acr setup - address feedback to convert get status to post.

* Add swagger spec for acr setup - fixed typo.

* Add swagger spec for acr setup - added setup specs to readme.

* Add swagger spec for acr setup - fixed checkSetup definitions.

* Add swagger spec for acr setup - addressed comments.

* Add swagger spec for acr setup - addressed ARM feedback.

* Add swagger spec for acr setup - added proper input-files n readme.

* Add swagger spec for acr setup - fixed inavalid scheme.

* Add swagger spec for acr setup - fixed inavalid method Post instaed of Get.

Co-authored-by: Larysa Borodina <larisab@microsoft.com>
* Update API changes

* Add delete call implementation

* update examples
@openapi-workflow-bot
Copy link

Hi, @larisaborodina Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 6, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 24 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'ContainerRegistryConfiguration_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.ContainerRegistry.Admin/preview/2019-11-01-preview/configuration.json#L30
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ContainerRegistryCapacity_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ContainerRegistry.Admin/preview/2019-11-01-preview/capacity.json#L62
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ContainerRegistryConfiguration_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ContainerRegistry.Admin/preview/2019-11-01-preview/configuration.json#L145
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ContainerRegistry.Admin/preview/2019-11-01-preview/operations.json#L20
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Quotas_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ContainerRegistry.Admin/preview/2019-11-01-preview/quotas.json#L145
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ContainerRegistryCapacityModel'. Consider using the plural form of 'ContainerRegistryCapacity' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.ContainerRegistry.Admin/preview/2019-11-01-preview/capacity.json#L30
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ContainerRegistryCapacityModel'. Consider using the plural form of 'ContainerRegistryCapacity' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.ContainerRegistry.Admin/preview/2019-11-01-preview/capacity.json#L72
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ContainerRegistryConfigurationModel'. Consider using the plural form of 'ContainerRegistryConfiguration' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.ContainerRegistry.Admin/preview/2019-11-01-preview/configuration.json#L30
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ContainerRegistryConfigurationModel'. Consider using the plural form of 'ContainerRegistryConfiguration' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.ContainerRegistry.Admin/preview/2019-11-01-preview/configuration.json#L73
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ContainerRegistryConfigurationModel'. Consider using the plural form of 'ContainerRegistryConfiguration' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.ContainerRegistry.Admin/preview/2019-11-01-preview/configuration.json#L113
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"azsadmin/resource-manager/containerregistry/readme.md",
    "tag":"package-2019-11-01-preview",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azsadmin/resource-manager/containerregistry/readme.md",
    "tag":"package-2019-11-01-preview",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azsadmin/resource-manager/containerregistry/readme.md",
    "tag":"package-2019-11-01-preview",
    "details":"> Installing AutoRest extension '@autorest/modelerfour' (4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azsadmin/resource-manager/containerregistry/readme.md",
    "tag":"package-2019-11-01-preview",
    "details":"> Installed AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 6, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-workflow-bot
    Copy link

    Hi @larisaborodina, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @akning-ms akning-ms assigned leni-msft and unassigned akning-ms May 7, 2021
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 10, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @larisaborodina your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @leni-msft

    @leni-msft leni-msft assigned jianyexi and unassigned leni-msft May 10, 2021
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    @larisaborodina larisaborodina requested review from markcowl and rjaini June 8, 2021 18:57
    @bganapa bganapa assigned markcowl and unassigned larisaborodina Jun 16, 2021
    @bganapa
    Copy link
    Member

    bganapa commented Jun 16, 2021

    @markcowl Could you please review this again? @larisaborodina has addressed the comments

    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    
    * Fix swagger specs, address comments and naming bug - 32th
    
    * Fix swagger specs, address comments and naming bug - 33th
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    
    * Fix swagger specs, address comments and naming bug - 32th
    
    * Fix swagger specs, address comments and naming bug - 33th
    
    * Fix swagger specs - 34th
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    
    * Fix swagger specs, address comments and naming bug - 32th
    
    * Fix swagger specs, address comments and naming bug - 33th
    
    * Fix swagger specs - 34th
    
    * Test cmdlet name creation with recommended operation id for quota
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    
    * Fix swagger specs, address comments and naming bug - 32th
    
    * Fix swagger specs, address comments and naming bug - 33th
    
    * Fix swagger specs - 34th
    
    * Test cmdlet name creation with recommended operation id for quota
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Use v2 common resource types.
    Copy link
    Member

    @markcowl markcowl left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    One minor issue - looks like one of your fies has no definitions or paths sections, and so can just be omitted. otherwise, looks good.

    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    
    * Fix swagger specs, address comments and naming bug - 32th
    
    * Fix swagger specs, address comments and naming bug - 33th
    
    * Fix swagger specs - 34th
    
    * Test cmdlet name creation with recommended operation id for quota
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Use v2 common resource types.
    
    * Use v2 common resource types for parameters also.
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    
    * Fix swagger specs, address comments and naming bug - 32th
    
    * Fix swagger specs, address comments and naming bug - 33th
    
    * Fix swagger specs - 34th
    
    * Test cmdlet name creation with recommended operation id for quota
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Use v2 common resource types.
    
    * Use v2 common resource types for parameters also.
    
    * Use v2 common resource types for parameters also. - fixed the readme to remove unneeded file
    @larisaborodina larisaborodina requested a review from markcowl June 28, 2021 02:18
    @markcowl markcowl merged commit 76f34ff into Azure:master Jun 29, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * ACR Admin swagger spec changes
    
    * Release/larisab (Azure#1)
    
    * Add swagger spec for acr setup.
    
    * Add swagger spec for acr setup - fixed jsons.
    
    * Add swagger spec for acr setup - address feedback to convert get status to post.
    
    * Add swagger spec for acr setup - fixed typo.
    
    * Add swagger spec for acr setup - added setup specs to readme.
    
    * Add swagger spec for acr setup - fixed checkSetup definitions.
    
    * Add swagger spec for acr setup - addressed comments.
    
    * Add swagger spec for acr setup - addressed ARM feedback.
    
    * Add swagger spec for acr setup - added proper input-files n readme.
    
    * Add swagger spec for acr setup - fixed inavalid scheme.
    
    * Add swagger spec for acr setup - fixed inavalid method Post instaed of Get.
    
    Co-authored-by: Larysa Borodina <larisab@microsoft.com>
    
    * Update API changes (Azure#2)
    
    * Update API changes
    
    * Add delete call implementation
    
    * update examples
    
    * Fix swagger validation errors. (Azure#3)
    
    * Fix swagger validation errors - 2-nd. (Azure#4)
    
    * Fix model validation fix
    
    * Fix swagger validation errors - 3d. (Azure#5)
    
    * Fix swagger validation errors - 4th. (Azure#6)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Release/acrchanges (Azure#8)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Release/acrchanges (Azure#9)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Release/larisab (Azure#11)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 12th.
    
    * Release/acrchanges (Azure#12)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Release/acrchanges (Azure#13)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Release/acrchanges (Azure#14)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Release/acrchanges (Azure#15)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Release/acrchanges (Azure#16)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Release/acrchanges (Azure#17)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Release/acrchanges (Azure#18)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Release/acrchanges (Azure#19)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Release/acrchanges (Azure#20)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Release/acrchanges (Azure#21)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    
    * Release/acrchanges (Azure#22)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    
    * Fix swagger specs, address comments and naming bug - 32th
    
    * Fix swagger specs, address comments and naming bug - 33th
    
    * Release/acrchanges (Azure#23)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    
    * Fix swagger specs, address comments and naming bug - 32th
    
    * Fix swagger specs, address comments and naming bug - 33th
    
    * Fix swagger specs - 34th
    
    * Release/acrchanges (Azure#24)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    
    * Fix swagger specs, address comments and naming bug - 32th
    
    * Fix swagger specs, address comments and naming bug - 33th
    
    * Fix swagger specs - 34th
    
    * Test cmdlet name creation with recommended operation id for quota
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Release/acrchanges (Azure#25)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    
    * Fix swagger specs, address comments and naming bug - 32th
    
    * Fix swagger specs, address comments and naming bug - 33th
    
    * Fix swagger specs - 34th
    
    * Test cmdlet name creation with recommended operation id for quota
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Use v2 common resource types.
    
    * Release/acrchanges (Azure#26)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    
    * Fix swagger specs, address comments and naming bug - 32th
    
    * Fix swagger specs, address comments and naming bug - 33th
    
    * Fix swagger specs - 34th
    
    * Test cmdlet name creation with recommended operation id for quota
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Use v2 common resource types.
    
    * Use v2 common resource types for parameters also.
    
    * Release/acrchanges (Azure#27)
    
    * Fix swagger validation errors - 4th.
    
    * Fix swagger validation errors - 5th.
    
    * Fix swagger validation errors - 6th.
    
    * Fix swagger validation errors - 7th.
    
    * Fix swagger validation errors - 13th.
    
    * Fix swagger validation errors - 14th.
    
    * Fix swagger validation errors - 15th.
    
    * Fix swagger validation errors - 16th.
    
    * Fix swagger validation errors - 17th.
    
    * Fix swagger validation errors - 18th.
    
    * Fix swagger validation errors - 19th.
    
    * Fix swagger validation errors - 20th.
    
    * Fix swagger validation errors - 21th.
    
    * Fix swagger validation errors - 21st.
    
    * Fix swagger validation errors - 22st.
    
    * Fix swagger validation errors - 23st.
    
    * Fix swagger validation errors - 24st.
    
    * Fix swagger validation errors - 25th.
    
    * Fix swagger validation errors - 26th
    
    * Fix swagger validation errors - 27th
    
    * Fix swagger validation errors - 28th
    
    * Fix swagger validation errors - 29th
    
    * Fix swagger validation errors - 30th
    
    * Fix swagger validation errors - 31th
    
    * Fix swagger specs, address comments and naming bug - 32th
    
    * Fix swagger specs, address comments and naming bug - 33th
    
    * Fix swagger specs - 34th
    
    * Test cmdlet name creation with recommended operation id for quota
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Test cmdlet name creation with recommended operation id
    
    * Use v2 common resource types.
    
    * Use v2 common resource types for parameters also.
    
    * Use v2 common resource types for parameters also. - fixed the readme to remove unneeded file
    
    Co-authored-by: Rohit Jaini <rjaini@microsoft.com>
    Co-authored-by: larysaborodina <larysaborodina@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    8 participants