-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Microsoft.IoTCentral/iotApps] Removal of legacy S1 SKU, S360 Fixes, newer RP API version 2021-06-01 #14311
[Microsoft.IoTCentral/iotApps] Removal of legacy S1 SKU, S360 Fixes, newer RP API version 2021-06-01 #14311
Conversation
Hi, @poanchen Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R4037 - MissingTypeObject |
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L603 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L644 |
OperationId should contain the verb: 'apptemplates' in:'Apps_ListTemplates'. Consider updating the operationId Location: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L419 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌
Cross-Version Breaking Changes: 11 Errors, 2 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-06-01/iotcentral.json compared with base:stable/2018-09-01/iotcentral.json
- current:stable/2021-06-01/iotcentral.json compared with base:preview/2017-07-01-privatepreview/iotcentral.json
Rule | Message |
---|---|
1019 - RemovedEnumValue |
The new version is removing enum value(s) 'F1, S1' from the old version. New: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L540:9 Old: Microsoft.IoTCentral/stable/2018-09-01/iotcentral.json#L523:9 |
The following breaking changes are detected by comparison with latest preview version:
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"iotcentral/resource-manager/readme.md",
"tag":"package-2021-06",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"iotcentral/resource-manager/readme.md",
"tag":"package-2021-06",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"iotcentral/resource-manager/readme.md",
"tag":"package-2021-06",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi @poanchen, Your PR has some issues. Please fix the CI sequentially by following the order of
|
696e1b3
to
41ce775
Compare
@erich-wang please let us know if you have any feedback to this PR. Our code changes + arm manifest is already in prod. We have also tested the newly generated SDK against both canary + prod. So we should be good to merge this swagger changes to add a new RP api version 2021-06-01. As we will have other changes coming later on, we will not trigger an update to SDK until down the road. Thanks. |
@akning-ms please let us know how we can move forward and close this PR thanks |
Hi @poanchen, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi @poanchen, Your PR is not ready for merge on below point:
❌ 1019 - RemovedEnumValue | The new version is removing enum value(s) 'F1, S1' from the old version. |
Let us know if this PR still needs some feedback, it's been open for quite some time |
@jorgecotillo We are in the process of getting our breaking changes approved by the ARM team. Will reach out once that is approved and we should be able to merge this. |
Breaking changes already got approved. Please merge this PR whenever you guys see this. Thanks tons! |
ping again here let me us know what else we need to do thanks! |
Hi @poanchen, you may need ping ARM on call person to review if urgent as below guideline: And can we know whether this version for your service end will be deployed on PROD |
We don't have urgency to merge this PR but we do want to get this PR moving forward. Please take a look when you guys have time. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from ARM side.
Now that we also got the ARM team approval. Can we move this forward? and merge this PR thanks! |
…cy S1 SKU, S360 Fixes, newer RP API version 2021-06-01 (#1899) Create to sync Azure/azure-rest-api-specs#14311 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/iotcentral?expand=1)
…newer RP API version 2021-06-01 (Azure#14311) * Adds base for updating Microsoft.IoTCentral from version stable/2018-09-01 to version 2021-06-01 * Updates readme * Updates API version in new specs and examples * remove legacy sku S1 * update template in example to use M3 template name * add suppress for R4009 and R3018 * add state * update * should be read only * update example * Update iotcentral.json temporary changing this for further testing in canary. * removal of f1 and deleted state
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.