Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PostgreSQL flexible server restart API #14368

Closed
wants to merge 1 commit into from
Closed

Update PostgreSQL flexible server restart API #14368

wants to merge 1 commit into from

Conversation

yannickzj
Copy link

@yannickzj yannickzj commented May 11, 2021 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @yannickzj Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 11, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ 1043 - AddingOptionalParameter The optional parameter 'restartParameter' was added in the new version.
    New: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L350:11
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: restartWithFailover
    Location: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L1763


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R1003 - ListInOperationName Since operation 'LocationBasedCapabilities_Execute' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L857
    ⚠️ R1003 - ListInOperationName Since operation 'VirtualNetworkSubnetUsage_Execute' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L899
    ⚠️ R1005 - GetInOperationName 'GET' operation 'LocationBasedCapabilities_Execute' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L857
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L943
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checknameavailability' in:'CheckNameAvailability_Execute'. Consider updating the operationId
    Location: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L812
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checkvirtualnetworksubnetusage' in:'VirtualNetworkSubnetUsage_Execute'. Consider updating the operationId
    Location: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L899
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getprivatednszonesuffix' in:'GetPrivateDnsZoneSuffix_Execute'. Consider updating the operationId
    Location: Microsoft.DBforPostgreSQL/preview/2021-03-31-privatepreview/PrivateDnsZone.json#L42
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'firewallRules' with immediate parent 'Server', must have a list by immediate parent operation.
    Location: Microsoft.DBforPostgreSQL/preview/2021-03-31-privatepreview/PrivateDnsZone.json#L90
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'configurations' with immediate parent 'Server', must have a list by immediate parent operation.
    Location: Microsoft.DBforPostgreSQL/preview/2021-03-31-privatepreview/PrivateDnsZone.json#L90
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'databases' with immediate parent 'Server', must have a list by immediate parent operation.
    Location: Microsoft.DBforPostgreSQL/preview/2021-03-31-privatepreview/PrivateDnsZone.json#L90
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/postgresql/resource-manager/readme.md
    tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2021-03-31-privatepreview",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2021-03-31-privatepreview",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2021-03-31-privatepreview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2020-11-05-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2020-11-05-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2020-02-14-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2020-02-14-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 11, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from b6bdee9e8ae874b2f5aacbfea1791f41387af6f1. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-05-12 00:00:23 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-postgresql;1.0.0;1.1.0-beta.1"
cmderr	[generate.py] 2021-05-12 00:00:23 WARNING [VERSION][Not Implement] set to current version "1.1.0-beta.1" by default
cmderr	[generate.py] 2021-05-12 00:00:23 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.27 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/postgresql/azure-resourcemanager-postgresql --java.namespace=com.azure.resourcemanager.postgresql   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
cmderr	[generate.py] 2021-05-12 00:01:04 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-postgresql
cmderr	[generate.py] 2021-05-12 00:01:04 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-05-12 00:01:04 INFO [POM][Skip] pom already has module azure-resourcemanager-postgresql
cmderr	[generate.py] 2021-05-12 00:01:04 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-05-12 00:01:04 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-05-12 00:01:04 INFO [POM][Skip] pom already has module sdk/postgresql
cmderr	[generate.py] 2021-05-12 00:01:04 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2021-05-12 00:03:25 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-postgresql [View full logs]  [Preview SDK Changes] 
      cmderr	[Inst] 2021-05-12 00:04:42 DEBUG Got artifact_id: azure-resourcemanager-postgresql
cmderr	[Inst] 2021-05-12 00:04:42 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-05-12 00:04:42 DEBUG Got artifact: azure-resourcemanager-postgresql-1.1.0-beta.1-sources.jar
cmderr	[Inst] 2021-05-12 00:04:42 DEBUG Got artifact: azure-resourcemanager-postgresql-1.1.0-beta.1.jar
cmderr	[Inst] 2021-05-12 00:04:42 DEBUG Match jar package: azure-resourcemanager-postgresql-1.1.0-beta.1.jar
cmderr	[Inst] 2021-05-12 00:04:42 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14368/azure-sdk-for-java/azure-resourcemanager-postgresql/azure-resourcemanager-postgresql-1.1.0-beta.1.jar\" -o azure-resourcemanager-postgresql-1.1.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-postgresql -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-postgresql-1.1.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from b6bdee9e8ae874b2f5aacbfea1791f41387af6f1. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️postgresql [View full logs]  [Preview Schema Changes]
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from b6bdee9e8ae874b2f5aacbfea1791f41387af6f1. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.PostgreSQL [View full logs]  [Preview SDK Changes]
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs] Generate from b6bdee9e8ae874b2f5aacbfea1791f41387af6f1. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from b6bdee9e8ae874b2f5aacbfea1791f41387af6f1. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-rdbms [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation ServersOperations.begin_restart has a new signature
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from b6bdee9e8ae874b2f5aacbfea1791f41387af6f1. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️postgresql/mgmt/2020-01-01/postgresql [View full logs]  [Preview SDK Changes]
      Only show 24 items here, please refer to log for details.
      info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultIterator.NextWithContext(context.Context) error`
info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultPage(ServerSecurityAlertPolicyListResult, func(context.Context, ServerSecurityAlertPolicyListResult) (ServerSecurityAlertPolicyListResult, error)) ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New function `NewRecoverableServersClientWithBaseURI(string, string) RecoverableServersClient`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListResponder(*http.Response) (PerformanceTierListResult, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerResponder(*http.Response) (ServerSecurityAlertPolicyListResult, error)`
info	[Changelog] - New function `NewServerParametersClientWithBaseURI(string, string) ServerParametersClient`
info	[Changelog] - New struct `RecoverableServerProperties`
info	[Changelog] - New struct `RecoverableServerResource`
info	[Changelog] - New struct `RecoverableServersClient`
info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
info	[Changelog] - New struct `ServerParametersClient`
info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 58 additive change(s).
info	[Changelog]
    • ️✔️postgresql/mgmt/2017-12-01/postgresql [View full logs]  [Preview SDK Changes]
      Only show 24 items here, please refer to log for details.
      info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultPage.Next() error`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Values() []ServerSecurityAlertPolicy`
info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsResponder(*http.Response) (ConfigurationListResult, error)`
info	[Changelog] - New function `*ServerParametersListUpdateConfigurationsFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultPage(ServerSecurityAlertPolicyListResult, func(context.Context, ServerSecurityAlertPolicyListResult) (ServerSecurityAlertPolicyListResult, error)) ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New function `RecoverableServersClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New struct `RecoverableServerProperties`
info	[Changelog] - New struct `RecoverableServerResource`
info	[Changelog] - New struct `RecoverableServersClient`
info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
info	[Changelog] - New struct `ServerParametersClient`
info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 58 additive change(s).
info	[Changelog]
    • ️✔️preview/postgresql/mgmt/2020-11-05-preview/postgresqlflexibleservers [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ServersClient.Restart` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string, string, *RestartParameter)`
info	[Changelog] - Function `ServersClient.RestartPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string, string, *RestartParameter)`
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `RestartParameter`
info	[Changelog] - New struct `ServerPropertiesPrivateDNSZoneArguments`
info	[Changelog] - New field `SourceSubscriptionID` in struct `ServerProperties`
info	[Changelog] - New field `SourceResourceGroupName` in struct `ServerProperties`
info	[Changelog] - New field `PrivateDNSZoneArguments` in struct `ServerProperties`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 5 additive change(s).
info	[Changelog]
    • ️✔️preview/postgresql/mgmt/2020-02-14-preview/postgresqlflexibleservers [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ServersClient.RestartPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string, string, *RestartParameter)`
info	[Changelog] - Function `ServersClient.Restart` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string, string, *RestartParameter)`
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `RestartParameter`
info	[Changelog] - New struct `ServerPropertiesPrivateDNSZoneArguments`
info	[Changelog] - New field `PrivateDNSZoneArguments` in struct `ServerProperties`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 5 additive change(s).
info	[Changelog]
    • ️✔️preview/postgresql/mgmt/2017-12-01-preview/postgresql [View full logs]  [Preview SDK Changes]
      Only show 24 items here, please refer to log for details.
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Values() []ServerSecurityAlertPolicy`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.NotDone() bool`
info	[Changelog] - New function `NewServerBasedPerformanceTierClient(string) ServerBasedPerformanceTierClient`
info	[Changelog] - New function `RecoverableServerResource.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New struct `RecoverableServerProperties`
info	[Changelog] - New struct `RecoverableServerResource`
info	[Changelog] - New struct `RecoverableServersClient`
info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
info	[Changelog] - New struct `ServerParametersClient`
info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 58 additive change(s).
info	[Changelog]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    This was referenced May 11, 2021
    Draft
    Draft
    This was referenced May 12, 2021
    Draft
    Draft
    @yannickzj yannickzj closed this May 12, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees

    @leni-msft leni-msft

    Labels
    CI-BreakingChange-Go
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @yannickzj @leni-msft