-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding APIs for the new resource - Network Security Perimeter (NSP) #14433
Merged
Merged
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f6fe18b
Merge pull request #3 from Azure/master
harics24 67c4abd
Merge branch 'Azure:master' into master
harics24 686d9b3
Merge branch 'Azure:master' into nsp-resource
harics24 a590fa9
Defining the new resource NSP and the APIs
ec15482
Adding the tag in get to be consistent with the list
5b41ea8
Removing etags everywhere as per internal discussion
3671e6e
Merge pull request #5 from Azure/master
harics24 0ea3b9a
Creating a new folder for a new preview version
0613c0f
Changing version in all the files
34b9d6e
Update readme.md
1902a23
Removing the changes in the old version
c2392eb
Removing the network manager files
cc2985f
Update readme.md
c5f2885
Update readme.md
f5bd226
Fixing cross version breaking change
d91ae28
Removing the required fields in the correct version
20f7dce
Attempting to fix the lint errors
4284708
Merge branch 'Azure:master' into nsp-resource
harics24 dcea38d
Adding the type as object to fix lint errors
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
13 changes: 13 additions & 0 deletions
13
...Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterDelete.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "title": "Delete Network Security Perimeter", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "testNSP1" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "204": {} | ||
| } | ||
| } |
23 changes: 23 additions & 0 deletions
23
...er/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterGet.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "title": "Get Network Security Perimeter", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "name": "nsp1", | ||
| "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters", | ||
| "properties": { | ||
| "displayName": "nsp1", | ||
| "description": "Test Network Security Periemter", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
39 changes: 39 additions & 0 deletions
39
...r/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterList.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| "title": "List Network Security Perimeter", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "name": "testNSP1", | ||
| "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/testNSP1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters", | ||
| "etag": "sadf-asdf-asdf-asdf", | ||
| "properties": { | ||
| "displayName": "TestNetworkSecurityPerimeter1", | ||
| "description": "Description for TestNetworkSecurityPerimeter1", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| }, | ||
| { | ||
| "name": "testNSP2", | ||
| "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/testNSP2", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters", | ||
| "etag": "sadf-asdf-asdf-addf", | ||
| "properties": { | ||
| "displayName": "TestNetworkSecurityPerimeter2", | ||
| "description": "Description for TestNetworkSecurityPerimeter2", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": "{baseurl}/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters?api-version=2021-02-01-preview&$skipToken=10" | ||
| } | ||
| } | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
...icrosoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterListAll.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "title": "List all the Network Security Perimeters in a Subscription", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "name": "testNSP1", | ||
| "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/testNSP1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters", | ||
| "etag": "sadf-asdf-asdf-asdf", | ||
| "properties": { | ||
| "displayName": "TestNetworkSecurityPerimeter1", | ||
| "description": "Description for TestNetworkSecurityPerimeter1", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| }, | ||
| { | ||
| "name": "testNSP2", | ||
| "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/testNSP2", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters", | ||
| "etag": "sadf-asdf-asdf-asdf", | ||
| "properties": { | ||
| "displayName": "TestNetworkSecurityPerimeter2", | ||
| "description": "Description for TestNetworkSecurityPerimeter2", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": "{baseurl}/subscriptions/subId/providers/Microsoft.Network/networkSecurityPerimeters?api-version=2021-02-01-preview&$skipToken=10" | ||
| } | ||
| } | ||
| } | ||
| } |
43 changes: 43 additions & 0 deletions
43
...er/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| { | ||
| "title": "Create/Update Network Security Perimeter", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "parameters": { | ||
| "properties": { | ||
| "displayName": "TestNetworkSecurityPerimeter", | ||
| "description": "Description of TestNetworkSecurityPerimeter" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "name": "TestNetworkSecurityPerimeter", | ||
| "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/TestNetworkSecurityPerimeter", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters", | ||
| "etag": "sadf-badf-sasf-basf", | ||
| "properties": { | ||
| "displayName": "TestNetworkSecurityPerimeter", | ||
| "description": "Description of TestNetworkSecurityPerimeter", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "name": "TestNetworkSecurityPerimeter", | ||
| "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/TestNetworkSecurityPerimeter", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters", | ||
| "etag": "sadf-badf-sasf-basf", | ||
| "properties": { | ||
| "displayName": "TestNetworkSecurityPerimeter", | ||
| "description": "Description of TestNetworkSecurityPerimeter", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your get call also returns an "etag" property right? might be a good idea to include it here as well to prevent confusions (mainly because your other examples do include an etag property)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed everywhere after discussing internally.