-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing updatable properties in ConfigurationStorePropertiesUpdateParameters #14452
Added missing updatable properties in ConfigurationStorePropertiesUpdateParameters #14452
Conversation
Hi, @jimmyca15 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
NewApiVersionRequired reason: |
Java is OK as SDK in preview. |
For python, the breaking change is expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as the JS SDK is not released yet, no impact to the current user
@ruowan looks you got assigned, can you do the merge for us? |
Hi, @jimmyca15. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
@ruowan can you please merge this? |
/azp run |
…ateParameters (Azure#14452) Co-authored-by: jimmypc92 <jimmypc92>
…ateParameters (Azure#14452) Co-authored-by: jimmypc92 <jimmypc92>
Changelog
Please ensure to add changelog with this PR by answering the following questions.
When we added this swagger we missed the property being added in this PR. This causes a problem because we cannot generate the correct SDK.
This property exists here in our latest stable version. It was missed when we added this new 2021-03-01-preview API version.
This API version was made available last week.
This swagger is checked in but it has this bug.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.