Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.AzureStack to add version preview/2020-06-01-preview #14472

Merged
merged 3 commits into from
Jun 10, 2021
Merged

[Hub Generated] Review request for Microsoft.AzureStack to add version preview/2020-06-01-preview #14472

merged 3 commits into from
Jun 10, 2021

Conversation

bbridges
Copy link
Member

@bbridges bbridges commented May 19, 2021 •
edited by xiaoxuqi-ms
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
      • Adding missing spec for list by subscription to preview and stable API versions
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
    Service already supports these endpoints
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @bbridges Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 19, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.AzureStack/preview/2020-06-01-preview/Registration.json#L60:5
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.AzureStack/stable/2016-01-01/Registration.json#L60:5
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.AzureStack/stable/2017-06-01/Registration.json#L60:5
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'CloudManifestFile_List' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AzureStack/preview/2020-06-01-preview/AzureStack.json#L55
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'CloudManifestFile_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AzureStack/preview/2020-06-01-preview/AzureStack.json#L88
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.AzureStack/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.AzureStack/preview/2020-06-01-preview/AzureStack.json#L18
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.AzureStack/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.AzureStack/stable/2017-06-01/AzureStack.json#L18
    ❌ R4019 - GetCollectionResponseSchema The response in the GET collection operation 'CloudManifestFile_List' does not match the response definition in the individual GET operation 'CloudManifestFile_Get' .
    Location: Microsoft.AzureStack/preview/2020-06-01-preview/AzureStack.json#L54
    ❌ R4019 - GetCollectionResponseSchema The response in the GET collection operation 'CloudManifestFile_List' does not match the response definition in the individual GET operation 'CloudManifestFile_Get' .
    Location: Microsoft.AzureStack/stable/2017-06-01/AzureStack.json#L54
    ❌ R4037 - MissingTypeObject The schema 'Operation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AzureStack/preview/2020-06-01-preview/AzureStack.json#L234
    ❌ R4037 - MissingTypeObject The schema 'Display' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AzureStack/preview/2020-06-01-preview/AzureStack.json#L251
    ❌ R4037 - MissingTypeObject The schema 'OperationList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AzureStack/preview/2020-06-01-preview/AzureStack.json#L272
    ❌ R4037 - MissingTypeObject The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AzureStack/preview/2020-06-01-preview/AzureStack.json#L350
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"azurestack/resource-manager/readme.md",
    "tag":"package-2016-01",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azurestack/resource-manager/readme.md",
    "tag":"package-2016-01",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"azurestack/resource-manager/readme.md",
    "tag":"package-2016-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azurestack/resource-manager/readme.md",
    "tag":"package-2017-06-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azurestack/resource-manager/readme.md",
    "tag":"package-2017-06-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azurestack/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azurestack/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 19, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-azurestack - 1.0.0
    ❌azure-sdk-for-go - azurestack/mgmt/2017-06-01/azurestack - v55.1.0
    +	Function `ProductsClient.GetProductsPreparer` parameter(s) have been changed from `(context.Context, string, string, *DeviceConfiguration)` to `(context.Context, string, string, string, *DeviceConfiguration)`
+	Function `ProductsClient.GetProducts` parameter(s) have been changed from `(context.Context, string, string, *DeviceConfiguration)` to `(context.Context, string, string, string, *DeviceConfiguration)`
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from fc4309c. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-azurestack [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model TrackedResource has a new parameter kind
info	[Changelog]   - Model TrackedResource has a new parameter system_data
info	[Changelog]   - Model Product has a new parameter system_data
info	[Changelog]   - Model Registration has a new parameter kind
info	[Changelog]   - Model Registration has a new parameter system_data
info	[Changelog]   - Model CustomerSubscription has a new parameter system_data
info	[Changelog]   - Added operation RegistrationsOperations.enable_remote_management
info	[Changelog]   - Added operation RegistrationsOperations.list_by_subscription
info	[Changelog]   - Added operation group LinkedSubscriptionsOperations
info	[Changelog]   - Added operation group CloudManifestFileOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation CustomerSubscriptionsOperations.create has a new signature
info	[Changelog]   - Parameter location of model RegistrationParameter is now required
info	[Changelog]   - Operation ProductsOperations.get_products has a new signature
info	[Changelog]   - Operation RegistrationsOperations.update has a new signature
info	[Changelog]   - Operation RegistrationsOperations.create_or_update has a new signature
info	[Changelog]   - Operation CustomerSubscriptionsOperations.create has a new signature
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from fc4309c. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-azurestack [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation RegistrationsOperations.list_by_subscription
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from fc4309c. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-06-10 03:48:50 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-azurestack;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-06-10 03:48:50 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-06-10 03:48:50 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.29 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/azurestack/azure-resourcemanager-azurestack --java.namespace=com.azure.resourcemanager.azurestack   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/azurestack/resource-manager/readme.md
cmderr	[generate.py] 2021-06-10 03:49:32 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-azurestack
cmderr	[generate.py] 2021-06-10 03:49:32 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-06-10 03:49:32 INFO [POM][Skip] pom already has module azure-resourcemanager-azurestack
cmderr	[generate.py] 2021-06-10 03:49:32 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-06-10 03:49:32 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-06-10 03:49:32 INFO [POM][Skip] pom already has module sdk/azurestack
cmderr	[generate.py] 2021-06-10 03:49:32 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-azurestack [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-06-10 03:52:55 DEBUG Got artifact_id: azure-resourcemanager-azurestack
cmderr	[Inst] 2021-06-10 03:52:55 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-06-10 03:52:55 DEBUG Got artifact: azure-resourcemanager-azurestack-1.0.0-beta.2-sources.jar
cmderr	[Inst] 2021-06-10 03:52:55 DEBUG Got artifact: azure-resourcemanager-azurestack-1.0.0-beta.2-javadoc.jar
cmderr	[Inst] 2021-06-10 03:52:55 DEBUG Got artifact: azure-resourcemanager-azurestack-1.0.0-beta.2.jar
cmderr	[Inst] 2021-06-10 03:52:55 DEBUG Match jar package: azure-resourcemanager-azurestack-1.0.0-beta.2.jar
cmderr	[Inst] 2021-06-10 03:52:55 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14472/azure-sdk-for-java/azure-resourcemanager-azurestack/azure-resourcemanager-azurestack-1.0.0-beta.2.jar\" -o azure-resourcemanager-azurestack-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-azurestack -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-azurestack-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from fc4309c. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️azurestack/mgmt/2017-06-01/azurestack [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ProductsClient.GetProductsPreparer` parameter(s) have been changed from `(context.Context, string, string, *DeviceConfiguration)` to `(context.Context, string, string, string, *DeviceConfiguration)`
info	[Changelog] - Function `ProductsClient.GetProducts` parameter(s) have been changed from `(context.Context, string, string, *DeviceConfiguration)` to `(context.Context, string, string, string, *DeviceConfiguration)`
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `RegistrationsClient.EnableRemoteManagement(context.Context, string, string) (autorest.Response, error)`
info	[Changelog] - New function `RegistrationsClient.EnableRemoteManagementSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `RegistrationsClient.ListBySubscriptionSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `RegistrationsClient.ListBySubscriptionComplete(context.Context) (RegistrationListIterator, error)`
info	[Changelog] - New function `RegistrationsClient.ListBySubscriptionPreparer(context.Context) (*http.Request, error)`
info	[Changelog] - New function `RegistrationsClient.EnableRemoteManagementResponder(*http.Response) (autorest.Response, error)`
info	[Changelog] - New function `RegistrationsClient.ListBySubscription(context.Context) (RegistrationListPage, error)`
info	[Changelog] - New function `RegistrationsClient.ListBySubscriptionResponder(*http.Response) (RegistrationList, error)`
info	[Changelog] - New function `RegistrationsClient.EnableRemoteManagementPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 9 additive change(s).
info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from fc4309c. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.6.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/azurestack/resource-manager/readme.md
    • ️✔️@azure/arm-azurestack [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/azureStackManagementClient.js → ./dist/arm-azurestack.js...
cmderr	[npmPack] created ./dist/arm-azurestack.js in 365ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from fc4309c. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️azurestack [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    This was referenced May 19, 2021
    Closed
    Closed
    This was referenced May 19, 2021
    Closed
    Closed
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request May 19, 2021
    Closed
    @bbridges bbridges marked this pull request as ready for review May 19, 2021 18:57
    @bbridges
    Copy link
    Member Author

    These ListBySubscription paths have been available in services in all API versions but were never added in the specs and so isn't an actual change in the service, they were marked as an S360 swagger validation issue because we were missing these paths here.

    @openapi-workflow-bot
    Copy link

    Hi @bbridges, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @xiaoxuqi-ms xiaoxuqi-ms added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 20, 2021
    @xiaoxuqi-ms
    Copy link
    Member

    Hi @bbridges , the window of fixing S360 is closed and you have to approval from Breaking change review board as pointed out by https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/405/Window-to-Fix-Broken.

    @msyyc
    Copy link
    Member

    msyyc commented May 20, 2021

    For python, the breaking change is expected.

    @ArcturusZhang
    Copy link
    Member

    The breaking changes are expected in go SDK

    @openapi-workflow-bot
    Copy link

    Hi, @bbridges your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @xiaoxuqi-ms

    @xiaoxuqi-ms
    Copy link
    Member

    @bbridges , as the "newApiversionRequired" label indicates, you can raise up a new api version for the new api. The breaking changes will be allowed in a new api version and do not need to get approval from breaking change review board.

    @xiaoxuqi-ms xiaoxuqi-ms removed their assignment Jun 2, 2021
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 7, 2021
    j5lim
    j5lim approved these changes Jun 8, 2021
    View reviewed changes
    Copy link
    Contributor

    @j5lim j5lim left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Approved from ARM side.

    @j5lim j5lim added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 8, 2021
    @jianyexi jianyexi merged commit fc4309c into Azure:master Jun 10, 2021
    This was referenced Jun 10, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @heaths heaths mentioned this pull request Jun 16, 2021
    Merged
    asager pushed a commit to asager/azure-rest-api-specs that referenced this pull request Jun 24, 2021
    @bbridges
    [Hub Generated] Review request for Microsoft.AzureStack to add versio…
    2369221 
    …n preview/2020-06-01-preview (Azure#14472)

* Add ListBySubscription to Registration resource

* Add ListBySubscription to Registration resources in stable versions

This has been supported but it was not listed in the spec

* Make example names unique
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @bbridges @mkarmark
    [Hub Generated] Review request for Microsoft.AzureStack to add versio…
    6aad10e 
    …n preview/2020-06-01-preview (Azure#14472)

* Add ListBySubscription to Registration resource

* Add ListBySubscription to Registration resources in stable versions

This has been supported but it was not listed in the spec

* Make example names unique
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @j5lim j5lim j5lim approved these changes

    @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

    Assignees

    @jianyexi jianyexi

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Python FixS360
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @bbridges @xiaoxuqi-ms @msyyc @ArcturusZhang @JeffreyRichter @j5lim @jianyexi