-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New SIP routing API version preview/2021-05-01-preview #14500
New SIP routing API version preview/2021-05-01-preview #14500
Conversation
Hi, @jannovak-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
88a50f8
to
915f2c4
Compare
b9b8039
to
e440de8
Compare
f36001c
to
9d503fa
Compare
63c948f
to
a045db3
Compare
...cation/data-plane/SipRouting/preview/2021-05-01-preview/communicationservicessiprouting.json
Outdated
Show resolved
Hide resolved
...cation/data-plane/SipRouting/preview/2021-05-01-preview/communicationservicessiprouting.json
Outdated
Show resolved
Hide resolved
61f87ae
to
0156341
Compare
* sip routing API * return 422 instead of 400 * change missing trunk error message * add 'error' prefix in error examples * describe patch behaviour * use the standard Azure error * remove unnecessary descriptions * fix descriptions * change fqdn max length * remove locale from example params and change endpoint * use the standard Azure error in examples * unify tags * use CommunicationServicesCommon/CommunicationErrorResponse * refactor sip configuration patch into separate class * fix CommunicationErrorResponse file path * add x-ms-error-response flag * add http errors schemas
* sip routing API * return 422 instead of 400 * change missing trunk error message * add 'error' prefix in error examples * describe patch behaviour * use the standard Azure error * remove unnecessary descriptions * fix descriptions * change fqdn max length * remove locale from example params and change endpoint * use the standard Azure error in examples * unify tags * use CommunicationServicesCommon/CommunicationErrorResponse * refactor sip configuration patch into separate class * fix CommunicationErrorResponse file path * add x-ms-error-response flag * add http errors schemas
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.