Sanjaiga/removetemplatedeploymentoptions #14522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @sanjaiganesh Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'ProvisioningState' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L2141 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L2315 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L2579 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L3483 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L3569 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L3860 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L4312 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L4548 |
|
| A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Operations_CreateOrUpdate' Request Model: 'OperationsPutContent' Response Model: 'OperationsContent' Location: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L769 |
|
| A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Skus_CreateOrUpdate' Request Model: 'ResourceTypeSku' Response Model: 'SkuResource' Location: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L1326 |
|
| A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Skus_CreateOrUpdateNestedResourceTypeFirst' Request Model: 'ResourceTypeSku' Response Model: 'SkuResource' Location: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L1478 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 5 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-05-01-preview", "details":"The schema 'ResourceProviderManagement-resourceAccessRolesItem' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#/components/schemas/ResourceProviderManagement-resourceAccessRolesItem" |
|
| "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-05-01-preview", "details":"The schema 'ResourceProviderManifestProperties-metadata' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#/components/schemas/ResourceProviderManifestProperties-metadata" |
|
| "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-05-01-preview", "details":"The schema 'ResourceType-metadata' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#/components/schemas/ResourceType-metadata" |
|
| "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-05-01-preview", "details":"The schema 'ResourceProviderManifest-metadata' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#/components/schemas/ResourceProviderManifest-metadata" |
|
| "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-05-01-preview", "details":"The schema 'OperationsDefinition-properties' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#/components/schemas/OperationsDefinition-properties" |
|
| 💬 AutorestCore/Exception | "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-05-01-preview", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-05-01-preview", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
"readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-05-01-preview", "details":"Error: Plugin pre-namer reported failure." |
| 💬 AutorestCore/Exception | "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-05-01-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️❌[Staging] Lint(RPaaS): 2 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
[RPaaS] The resource NotificationRegistration is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3467 |
|
[RPaaS] The resource SkuResource is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L4532 |
Swagger Generation Artifacts
|
|
Hi @sanjaiganesh, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
NewApiVersionRequired reason: |
|
@weidongxu-microsoft We just added this api-version to swagger repo couple days back. These properties were never supported. So there is no breaking change here. |
This was referenced May 21, 2021
|
Please show me the PR that you added it, and confirm no SDK released. Ideally it still need approval from Jeffrey. Also please fix the LintDiff and PrettierCheck. |
|
@weidongxu-microsoft I confirm that SDK is not released. btw the linter is failing for existing stable api version. i am fine to add provisioningState, since it is actually supported. let me know what you suggest. [RPaaS] The resource NotificationRegistration is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. |
weidongxu-microsoft
approved these changes
May 26, 2021
|
Then it should be fine.
Let me know when you need it merged. |
weidongxu-microsoft
added
Approved-BreakingChange
|
Suppress breaking changes, as api-version is newly added, and no SDK released. |
|
@weidongxu-microsoft Thank you. please merge the PR. |
This was referenced May 26, 2021
25 tasks
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* remove property * prettier check fixes and removing SubscriptionLifecycleNotificationSpecifications * adding provisioning state * reverting updates to stable version * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.