Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update available SKUs for CognitiveServices->Text Analytics #14180 #14561

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

suhas92
Copy link
Member

@suhas92 suhas92 commented May 27, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@suhas92 suhas92 requested a review from yangyuan as a code owner May 27, 2021 00:45
@openapi-workflow-bot
Copy link

Hi, @suhas92 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 27, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 27, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-cognitiveservices - 11.0.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d3a5ab5. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/cognitiveservices/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.CognitiveServices [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d3a5ab5. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-cognitiveservices [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model PrivateEndpointConnectionProperties has a new parameter provisioning_state
      info	[Changelog]   - Model PrivateEndpointConnection has a new parameter system_data
      info	[Changelog]   - Model PrivateEndpointConnection has a new parameter location
      info	[Changelog]   - Model PrivateEndpointConnection has a new parameter etag
      info	[Changelog]   - Model KeyVaultProperties has a new parameter identity_client_id
      info	[Changelog]   - Model UserOwnedStorage has a new parameter identity_client_id
      info	[Changelog]   - Model PrivateLinkServiceConnectionState has a new parameter actions_required
      info	[Changelog]   - Added operation AccountsOperations.get
      info	[Changelog]   - Added operation AccountsOperations.list_usages
      info	[Changelog]   - Added operation group DeletedAccountsOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation PrivateEndpointConnectionsOperations.create_or_update has a new signature
      info	[Changelog]   - Model PrivateLinkServiceConnectionState no longer has parameter action_required
      info	[Changelog]   - Removed operation AccountsOperations.get_usages
      info	[Changelog]   - Removed operation AccountsOperations.get_properties
      info	[Changelog]   - Model Sku has a new signature
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d3a5ab5. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-cognitiveservices [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model PrivateEndpointConnectionProperties has a new parameter provisioning_state
      info	[Changelog]   - Model KeyVaultProperties has a new parameter identity_client_id
      info	[Changelog]   - Model Sku has a new parameter family
      info	[Changelog]   - Model Sku has a new parameter capacity
      info	[Changelog]   - Model Sku has a new parameter size
      info	[Changelog]   - Model UserOwnedStorage has a new parameter identity_client_id
      info	[Changelog]   - Model PrivateEndpointConnection has a new parameter etag
      info	[Changelog]   - Model PrivateEndpointConnection has a new parameter system_data
      info	[Changelog]   - Model PrivateEndpointConnection has a new parameter location
      info	[Changelog]   - Model PrivateLinkServiceConnectionState has a new parameter actions_required
      info	[Changelog]   - Added operation AccountsOperations.begin_delete
      info	[Changelog]   - Added operation AccountsOperations.get
      info	[Changelog]   - Added operation AccountsOperations.begin_create
      info	[Changelog]   - Added operation AccountsOperations.list_usages
      info	[Changelog]   - Added operation AccountsOperations.begin_update
      info	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.begin_delete
      info	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.begin_create_or_update
      info	[Changelog]   - Added operation group DeletedAccountsOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model PrivateLinkServiceConnectionState no longer has parameter action_required
      info	[Changelog]   - Removed operation AccountsOperations.delete
      info	[Changelog]   - Removed operation AccountsOperations.create
      info	[Changelog]   - Removed operation AccountsOperations.get_usages
      info	[Changelog]   - Removed operation AccountsOperations.get_properties
      info	[Changelog]   - Removed operation AccountsOperations.update
      info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.create_or_update
      info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.delete
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d3a5ab5. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-06-03 00:52:26 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-cognitiveservices;1.0.0-beta.2;1.0.0-beta.3"
      cmderr	[generate.py] 2021-06-03 00:52:26 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
      cmderr	[generate.py] 2021-06-03 00:52:26 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.29 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/cognitiveservices/azure-resourcemanager-cognitiveservices --java.namespace=com.azure.resourcemanager.cognitiveservices   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/cognitiveservices/resource-manager/readme.md
      cmderr	[generate.py] 2021-06-03 00:53:07 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-cognitiveservices
      cmderr	[generate.py] 2021-06-03 00:53:07 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-06-03 00:53:07 INFO [POM][Skip] pom already has module azure-resourcemanager-cognitiveservices
      cmderr	[generate.py] 2021-06-03 00:53:07 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-06-03 00:53:07 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-06-03 00:53:07 INFO [POM][Skip] pom already has module sdk/cognitiveservices
      cmderr	[generate.py] 2021-06-03 00:53:07 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-cognitiveservices [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-06-03 00:56:03 DEBUG Got artifact_id: azure-resourcemanager-cognitiveservices
      cmderr	[Inst] 2021-06-03 00:56:03 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-06-03 00:56:03 DEBUG Got artifact: azure-resourcemanager-cognitiveservices-1.0.0-beta.3-sources.jar
      cmderr	[Inst] 2021-06-03 00:56:03 DEBUG Got artifact: azure-resourcemanager-cognitiveservices-1.0.0-beta.3-javadoc.jar
      cmderr	[Inst] 2021-06-03 00:56:03 DEBUG Got artifact: azure-resourcemanager-cognitiveservices-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-06-03 00:56:03 DEBUG Match jar package: azure-resourcemanager-cognitiveservices-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-06-03 00:56:03 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14561/azure-sdk-for-java/azure-resourcemanager-cognitiveservices/azure-resourcemanager-cognitiveservices-1.0.0-beta.3.jar\" -o azure-resourcemanager-cognitiveservices-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-cognitiveservices -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-cognitiveservices-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️❌ azure-sdk-for-go failed [Detail]
    • Failed [Logs]Release - Generate from d3a5ab5. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: sh ./initScript.sh
      warn	File azure-sdk-for-go_tmp/initOutput.json not found to read
      command	go run ./tools/generator/main.go automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: go run ./tools/generator/main.go automation
      warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d3a5ab5. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/cognitiveservices/resource-manager/readme.md
    • ️✔️@azure/arm-cognitiveservices [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/cognitiveServicesManagementClient.js → ./dist/arm-cognitiveservices.js...
      cmderr	[npmPack] created ./dist/arm-cognitiveservices.js in 419ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d3a5ab5. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️cognitiveservices [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @suhas92 suhas92 changed the title Update CheckSkuAvailability.json Update available SKUs for CognitiveServices->Text Analytics #14180 May 27, 2021
    @suhas92
    Copy link
    Member Author

    suhas92 commented May 27, 2021

    #14180

    @suhas92
    Copy link
    Member Author

    suhas92 commented Jun 1, 2021

    @raych1 Can you merge this PR?

    @JackTn JackTn deleted the sumeh/update-sku-ta branch June 16, 2022 00:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants