Fix readme and add track 2 configurations for go SDK #14582

ArcturusZhang · 2021-05-28T00:48:00Z

Apparently we should only have one default tag in one RP (or multiple but enables by flags), therefore I am removing the extra default tags defined here in order to let the autorest properly execute.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-05-28T00:48:02Z

Hi, @ArcturusZhang Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-05-28T00:48:03Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-05-28T00:48:04Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-05-28T00:48:04Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go - privatedns/mgmt/2018-09-01/privatedns - v54.3.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-privatedns - 1.0.0

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5f9965c. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/privatedns/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.PrivateDns [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.PrivateDns.1.0.0.nupkg
- Microsoft.Azure.Management.PrivateDns.1.0.0.snupkg

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 5f9965c. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-privatedns [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model PrivateZone has a new parameter internal_id
info	[Changelog]   - Added operation VirtualNetworkLinksOperations.delete
info	[Changelog]   - Added operation VirtualNetworkLinksOperations.update
info	[Changelog]   - Added operation VirtualNetworkLinksOperations.create_or_update
info	[Changelog]   - Added operation PrivateZonesOperations.delete
info	[Changelog]   - Added operation PrivateZonesOperations.update
info	[Changelog]   - Added operation PrivateZonesOperations.create_or_update
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation VirtualNetworkLinksOperations.list has a new signature
info	[Changelog]   - Operation VirtualNetworkLinksOperations.get has a new signature
info	[Changelog]   - Operation RecordSetsOperations.update has a new signature
info	[Changelog]   - Operation RecordSetsOperations.list_by_type has a new signature
info	[Changelog]   - Operation RecordSetsOperations.list has a new signature
info	[Changelog]   - Operation RecordSetsOperations.get has a new signature
info	[Changelog]   - Operation RecordSetsOperations.delete has a new signature
info	[Changelog]   - Operation RecordSetsOperations.create_or_update has a new signature
info	[Changelog]   - Operation PrivateZonesOperations.list_by_resource_group has a new signature
info	[Changelog]   - Operation PrivateZonesOperations.list has a new signature
info	[Changelog]   - Operation PrivateZonesOperations.get has a new signature
info	[Changelog]   - Removed operation VirtualNetworkLinksOperations.begin_update
info	[Changelog]   - Removed operation VirtualNetworkLinksOperations.begin_create_or_update
info	[Changelog]   - Removed operation VirtualNetworkLinksOperations.begin_delete
info	[Changelog]   - Removed operation PrivateZonesOperations.begin_update
info	[Changelog]   - Removed operation PrivateZonesOperations.begin_create_or_update
info	[Changelog]   - Removed operation PrivateZonesOperations.begin_delete

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 5f9965c. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-privatedns [View full logs] [Release SDK Changes]
- azure-mgmt-privatedns-1.0.0.zip
- azure_mgmt_privatedns-1.0.0-py2.py3-none-any.whl
```
info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model PrivateZone has a new parameter internal_id
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 5f9965c. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-05-31 03:28:00 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-privatedns-generated"
cmderr	[generate.py] 2021-05-31 03:28:00 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-05-31 03:28:00 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.29 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/privatedns/azure-resourcemanager-privatedns-generated --java.namespace=com.azure.resourcemanager.privatedns.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/privatedns/resource-manager/readme.md
cmderr	[generate.py] 2021-05-31 03:28:35 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-05-31 03:28:35 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-05-31 03:28:35 INFO [POM][Skip] pom already has module azure-resourcemanager-privatedns-generated
cmderr	[generate.py] 2021-05-31 03:28:35 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-05-31 03:28:35 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-05-31 03:28:35 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-privatedns-generated [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-05-31 03:32:14 DEBUG Got artifact_id: azure-resourcemanager-privatedns-generated
cmderr	[Inst] 2021-05-31 03:32:14 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-05-31 03:32:14 DEBUG Got artifact: azure-resourcemanager-privatedns-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-05-31 03:32:14 DEBUG Match jar package: azure-resourcemanager-privatedns-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-05-31 03:32:14 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14582/azure-sdk-for-java/azure-resourcemanager-privatedns-generated/azure-resourcemanager-privatedns-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-privatedns-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-privatedns-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-privatedns-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5f9965c. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️privatedns/mgmt/2018-09-01/privatedns [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5f9965c. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/privatedns/resource-manager/readme.md

️✔️@azure/arm-privatedns [View full logs] [Release SDK Changes]

azure-arm-privatedns-2.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/privateDnsManagementClient.js → ./dist/arm-privatedns.js...
cmderr	[npmPack] created ./dist/arm-privatedns.js in 248ms

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 5f9965c. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages

_{Posted by Swagger Pipeline | How to fix these errors?}

raych1 · 2021-05-28T08:19:56Z

/azp run

azure-pipelines · 2021-05-28T08:20:08Z

Azure Pipelines successfully started running 1 pipeline(s).

fix readme and add track 2 configurations

4efa5b5

openapi-assignment-bot bot assigned raych1 May 28, 2021

msyyc approved these changes May 28, 2021

View reviewed changes

raych1 approved these changes May 28, 2021

View reviewed changes

openapi-pipeline-app bot added the CI-BreakingChange-Python label May 28, 2021

ArcturusZhang merged commit 5f9965c into Azure:master May 31, 2021

ArcturusZhang deleted the introduce-go-track2-to-privatedns-and-fix-readme branch May 31, 2021 03:22

heaths mentioned this pull request Jun 16, 2021

Initial 2021-05-01-preview version #14855

Merged

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

fix readme and add track 2 configurations (Azure#14582)

dc170b3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix readme and add track 2 configurations for go SDK #14582

Fix readme and add track 2 configurations for go SDK #14582

ArcturusZhang commented May 28, 2021

openapi-workflow-bot bot commented May 28, 2021

openapi-workflow-bot bot commented May 28, 2021

openapi-pipeline-app bot commented May 28, 2021 •

edited

Loading

openapi-pipeline-app bot commented May 28, 2021 •

edited

Loading

Breaking Changes Tracking

raych1 commented May 28, 2021

azure-pipelines bot commented May 28, 2021

Fix readme and add track 2 configurations for go SDK #14582

Fix readme and add track 2 configurations for go SDK #14582

Conversation

ArcturusZhang commented May 28, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented May 28, 2021

openapi-workflow-bot bot commented May 28, 2021

openapi-pipeline-app bot commented May 28, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 28, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

raych1 commented May 28, 2021

azure-pipelines bot commented May 28, 2021

openapi-pipeline-app bot commented May 28, 2021 •

edited

Loading

openapi-pipeline-app bot commented May 28, 2021 •

edited

Loading