[Hub Generated] Review request for Microsoft.Support to add version preview/2021-06-01-preview #14586

mudit794 · 2021-05-28T03:44:48Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Latest improvements:

### Contribution checklist: - [ ] I have reviewed the [documentation](https://github.com/Azure/azure-rest-api-specs#basics) for the workflow. - [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR. - [ ] The [OpenAPI Hub](https://aka.ms/openapiportal) was used for checking validation status and next steps. ### ARM API Review Checklist - [ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories. - adding/removing APIs. - adding/removing properties. - adding/removing API-version. - adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…01 to version 2021-06-01-preview

…ew/2021-06-01-preview/examples directory

openapi-workflow-bot · 2021-05-28T03:44:50Z

Hi, @mudit794 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-05-28T03:44:51Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-05-28T03:44:54Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- support/resource-manager/readme.md tag:package-preview-2021-06
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- support/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'lookupresourceid' in:'LookUpResourceId_Post'. Consider updating the operationId Location: Microsoft.Support/preview/2021-06-01-preview/supportResourceIdDetails.json#L79

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Support/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Support/preview/2021-06-01-preview/supportResourceIdDetails.json#L37

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

support/resource-manager/readme.md#package-preview-2021-06

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"support/resource-manager/readme.md",
"tag":"package-preview-2021-06",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"support/resource-manager/readme.md",
"tag":"package-preview-2021-06",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"support/resource-manager/readme.md",
"tag":"package-preview-2021-06",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-05-28T03:44:54Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go - support/mgmt/2020-04-01/support - v55.1.0
️✔️azure-sdk-for-go - preview/support/mgmt/2019-05-01-preview/support - v55.1.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-support - 6.0.0

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 04adf29. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-support [View full logs] [Release SDK Changes]
- azure-mgmt-support-1.0.0.zip
- azure_mgmt_support-1.0.0-py2.py3-none-any.whl
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 04adf29. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-support [View full logs] [Release SDK Changes]
- azure-mgmt-support-2.0.0.zip
- azure_mgmt_support-2.0.0-py2.py3-none-any.whl
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 04adf29. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-06-08 01:24:48 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-support;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-06-08 01:24:48 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-06-08 01:24:48 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.29 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/support/azure-resourcemanager-support --java.namespace=com.azure.resourcemanager.support   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/support/resource-manager/readme.md
cmderr	[generate.py] 2021-06-08 01:25:21 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-support
cmderr	[generate.py] 2021-06-08 01:25:21 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-06-08 01:25:21 INFO [POM][Skip] pom already has module azure-resourcemanager-support
cmderr	[generate.py] 2021-06-08 01:25:21 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-06-08 01:25:21 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-06-08 01:25:21 INFO [POM][Skip] pom already has module sdk/support
cmderr	[generate.py] 2021-06-08 01:25:21 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-support [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-06-08 01:28:17 DEBUG Got artifact_id: azure-resourcemanager-support
cmderr	[Inst] 2021-06-08 01:28:17 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-06-08 01:28:17 DEBUG Got artifact: azure-resourcemanager-support-1.0.0-beta.2-javadoc.jar
cmderr	[Inst] 2021-06-08 01:28:17 DEBUG Got artifact: azure-resourcemanager-support-1.0.0-beta.2.jar
cmderr	[Inst] 2021-06-08 01:28:17 DEBUG Match jar package: azure-resourcemanager-support-1.0.0-beta.2.jar
cmderr	[Inst] 2021-06-08 01:28:17 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14586/azure-sdk-for-java/azure-resourcemanager-support/azure-resourcemanager-support-1.0.0-beta.2.jar\" -o azure-resourcemanager-support-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-support -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-support-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 04adf29. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.6.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/support/resource-manager/readme.md

️✔️@azure/arm-support [View full logs] [Release SDK Changes]

azure-arm-support-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/microsoftSupport.js → ./dist/arm-support.js...
cmderr	[npmPack] created ./dist/arm-support.js in 241ms

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 04adf29. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️support/mgmt/2020-04-01/support [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/support/mgmt/2019-05-01-preview/support [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 04adf29. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/support/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Support [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Support.1.0.1.nupkg
- Microsoft.Azure.Management.Support.1.0.1.snupkg

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 04adf29. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️support [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

mudit794 · 2021-05-28T18:24:49Z

@ArcturusZhang Do we need to have all resource types and paths in new api version even though they have no change? This is regarding Cross-Version Breaking changes failure.

ArcturusZhang · 2021-05-31T03:31:53Z

@mudit794 if you are adding new features (operations) in a new api-version and do not want to copy those operations defined in an older api-version, please use a different swagger filename. Otherwise you will have to first copy the swagger file in old api-version with the same name, then add your new operations.

…s.json

majastrz · 2021-06-02T17:19:25Z

.../resource-manager/Microsoft.Support/preview/2021-06-01-preview/supportResourceIdDetails.json

+        "details": {
+          "type": "array",
+          "items": {
+            "$ref": "#/definitions/ServiceErrorDetail"


ServiceErrorDetail

The ARM error definition is completely recursive, so this could be a reference to ServiceError. In general, you should avoid declaring your own definitions for common contracts and reference them out of common types v2 area of the repo. (This comment doesn't block the PR, though.)

Removed error code from manifest and example

majastrz

The API looks good overall, but you need to fix the status codes. I put a comment explaining what to do there.

mudit794 · 2021-06-02T21:29:45Z

The API looks good overall, but you need to fix the status codes. I put a comment explaining what to do there.

@majastrz Fixed the status code

majastrz

Signed off from ARM side.

mudit794 · 2021-06-04T02:24:21Z

@ArcturusZhang can you please review PR and merge it? I am not sure why go sdk started failing.

ArcturusZhang · 2021-06-08T00:35:58Z

/azp run

azure-pipelines · 2021-06-08T00:36:09Z

Azure Pipelines successfully started running 1 pipeline(s).

…review/2021-06-01-preview (Azure#14586) * Adds base for updating Microsoft.Support from version stable/2020-04-01 to version 2021-06-01-preview * Updates readme * Updates API version in new specs and examples * Add GetSupportTicketResourceId * Delete CheckNameAvailabilityForSupportTicketCommunication.json * Delete specification/support/resource-manager/Microsoft.Support/preview/2021-06-01-preview/examples directory * add example * list operations * Update LookUpSupportTicketResourceId.json * Update readme.md * Update support.json * Update support.json * Rename support.json to supportLookUpResourceId.json * Rename supportLookUpResourceId.json to supportTicketsResourceIdDetails.json * Update readme.md * Update ListOperations.json * Update LookUpSupportTicketResourceId.json * make swagger generic for resource id look up * Update LookUpSupportTicketResourceId.json * Update LookUpSupportTicketResourceId.json * Rename LookUpSupportTicketResourceId.json to LookUpResourceId.json * Update readme.md * Update LookUpResourceId.json * Update LookUpResourceId.json * Update supportResourceIdDetails.json * Update LookUpResourceId.json * Update supportResourceIdDetails.json * Update supportResourceIdDetails.json * Update LookUpResourceId.json * Update supportResourceIdDetails.json * Update LookUpResourceId.json * Update LookUpResourceId.json * Update supportResourceIdDetails.json * remove error code * Update supportResourceIdDetails.json * Update LookUpResourceId.json * Update supportResourceIdDetails.json

mudit794 and others added 7 commits May 27, 2021 18:50

Adds base for updating Microsoft.Support from version stable/2020-04-…

4155238

…01 to version 2021-06-01-preview

Updates readme

4ea49a8

Updates API version in new specs and examples

9aa927b

Add GetSupportTicketResourceId

53fa22e

Delete CheckNameAvailabilityForSupportTicketCommunication.json

d4b2820

Delete specification/support/resource-manager/Microsoft.Support/previ…

b04603e

…ew/2021-06-01-preview/examples directory

add example

29ea76b

list operations

91c4036

openapi-sdkautomation bot mentioned this pull request May 28, 2021

[AutoPR support/resource-manager] [Hub Generated] Review request for Microsoft.Support to add version preview/2021-06-01-preview AzureSDKAutomation/azure-resource-manager-schemas#3256

Draft

Update LookUpSupportTicketResourceId.json

acaf92c

openapi-sdkautomation bot mentioned this pull request May 28, 2021

[AutoPR azure-resourcemanager-support] [Hub Generated] Review request for Microsoft.Support to add version preview/2021-06-01-preview AzureSDKAutomation/azure-sdk-for-java#8678

Closed

Update readme.md

bc15d34

Update support.json

fdc47a7

Update support.json

0702487

mudit794 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 28, 2021

mudit794 marked this pull request as ready for review May 28, 2021 04:59

openapi-assignment-bot bot assigned ArcturusZhang May 28, 2021

mudit794 added 2 commits May 30, 2021 21:59

Rename support.json to supportLookUpResourceId.json

458683a

Rename supportLookUpResourceId.json to supportTicketsResourceIdDetail…

8b3c1d7

…s.json

majastrz reviewed Jun 2, 2021

View reviewed changes

majastrz added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 2, 2021

majastrz requested changes Jun 2, 2021

View reviewed changes

mudit794 added 4 commits June 2, 2021 10:22

remove error code

8a4e325

Update supportResourceIdDetails.json

e9aaee5

Update LookUpResourceId.json

10fa48f

Update supportResourceIdDetails.json

1929a6a

mudit794 requested a review from majastrz June 2, 2021 18:59

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jun 2, 2021

majastrz approved these changes Jun 2, 2021

View reviewed changes

mudit794 requested a review from ArcturusZhang June 7, 2021 19:13

ArcturusZhang merged commit 04adf29 into Azure:master Jun 8, 2021

heaths mentioned this pull request Jun 16, 2021

Initial 2021-05-01-preview version #14855

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Support to add version preview/2021-06-01-preview #14586

[Hub Generated] Review request for Microsoft.Support to add version preview/2021-06-01-preview #14586

mudit794 commented May 28, 2021

openapi-workflow-bot bot commented May 28, 2021

openapi-workflow-bot bot commented May 28, 2021

openapi-pipeline-app bot commented May 28, 2021 •

edited

Loading

openapi-pipeline-app bot commented May 28, 2021 •

edited

Loading

Breaking Changes Tracking

mudit794 commented May 28, 2021

ArcturusZhang commented May 31, 2021

majastrz Jun 2, 2021

mudit794 Jun 2, 2021

majastrz left a comment

mudit794 commented Jun 2, 2021

majastrz left a comment

mudit794 commented Jun 4, 2021

ArcturusZhang commented Jun 8, 2021

azure-pipelines bot commented Jun 8, 2021

[Hub Generated] Review request for Microsoft.Support to add version preview/2021-06-01-preview #14586

[Hub Generated] Review request for Microsoft.Support to add version preview/2021-06-01-preview #14586

Conversation

mudit794 commented May 28, 2021

Latest improvements:

openapi-workflow-bot bot commented May 28, 2021

openapi-workflow-bot bot commented May 28, 2021

openapi-pipeline-app bot commented May 28, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 28, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

mudit794 commented May 28, 2021

ArcturusZhang commented May 31, 2021

majastrz Jun 2, 2021

Choose a reason for hiding this comment

mudit794 Jun 2, 2021

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

mudit794 commented Jun 2, 2021

majastrz left a comment

Choose a reason for hiding this comment

mudit794 commented Jun 4, 2021

ArcturusZhang commented Jun 8, 2021

azure-pipelines bot commented Jun 8, 2021

openapi-pipeline-app bot commented May 28, 2021 •

edited

Loading

openapi-pipeline-app bot commented May 28, 2021 •

edited

Loading