[EventGrid] Change "FarmBeats" prefix #14680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDK team would prefer not using `FarmBeats` as a prefix for type names. Instead, use this more general term of `AgriFoodFarming` which aligns with the namespaces we are using for the FarmBeats SDK.
|
Hi, @ellismg Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"Error: Semantic validation failed. There was some errors" |
| 💬 AutorestCore/Exception | "readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️❌[Staging] SpellCheck: 4 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Unknown word (Agri), please fix the error or add words to ./custom-words.txt path: Microsoft.AgFoodPlatform/stable/2018-01-01/AzureFarmBeats.json#L10:6 |
|
Unknown word (Agri), please fix the error or add words to ./custom-words.txt path: Microsoft.AgFoodPlatform/stable/2018-01-01/AzureFarmBeats.json#L19:18 |
|
Unknown word (Agri), please fix the error or add words to ./custom-words.txt path: Microsoft.AgFoodPlatform/stable/2018-01-01/AzureFarmBeats.json#L23:6 |
|
Unknown word (Agri), please fix the error or add words to ./custom-words.txt path: Microsoft.AgFoodPlatform/stable/2018-01-01/AzureFarmBeats.json#L85:6 |
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
lmazuel
approved these changes
Jun 4, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
The SDK team would prefer not using `FarmBeats` as a prefix for type names. Instead, use this more general term of `AgriFoodFarming` which aligns with the namespaces we are using for the FarmBeats SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK team would prefer not using
FarmBeatsas a prefix for typenames. Instead, use this more general term of
AgriFoodFarmingwhichaligns with the namespaces we are using for the FarmBeats SDK.