[Maps] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/2.0 #14694

propheel · 2021-06-07T06:59:09Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

This reverts commit 85370d9b6b3ad0ae615d1931aa7a5eec39957b30.

This reverts commit be16d4423be319cc4b7a957abe977aced26e0fa5.

This reverts commit 0458cbc9489ba8cc05a575517b35001fa4c4a7e8.

…ance.

…ey from examples.

tjprescott · 2021-06-09T20:28:09Z

@propheel how is this different from #14625?

propheel · 2021-06-09T22:01:14Z

@propheel how is this different from #14625?

@tjprescott this PR is a modification of current Swagger for all 17 Maps services so that the code is actually generated and AutoRest does not complain about the model anymore. The #14625 just adds a new 2.1 version of the Render service.

chgennar · 2021-06-10T16:24:26Z

specification/maps/data-plane/Microsoft.Maps/Render/preview/2.0/render.json

-    "MapTileResultv2": {
-      "description": "The tile returned from a successful API call.",
-      "type": "string",
-      "format": "binary",
-      "readOnly": true
-    }


This definition is still being referenced above. Should it be kept?

You mean MapTileResultv2? It's not referenced anymore since 200 response definition was changed to describe a file as a response.

I see. I thought the response still referenced this as a schema. My mistake.

…eturn 200 directly (202 instead) the TS codegen takes 200 definition for the response type, so it is needed to deserialize.

…ue to invalid deserialization of base class properties only

propheel · 2021-07-02T09:35:04Z

The direction of the changes moved to #14871

v-ddaian added 30 commits June 4, 2021 15:15

Make maps data-plane swagger files compile when taken from api to sdk.

66d97e9

Update correctly the search api

ca6a59c

Update common.js and add swagger codegen to maps dataplane.

0fea01d

Fix path issue

76df28a

fix prettifier error.

34edbe8

Replace mistyped extension.

e5dab0e

Fix common type version.

5304ca1

Fix errors for alias.json

b98bde7

run prettier

99b0269

fix security def and parameters.

9c019ef

Revert "fix security def and parameters."

bfb0b46

This reverts commit 85370d9b6b3ad0ae615d1931aa7a5eec39957b30.

Revert "run prettier"

e28b1d3

This reverts commit be16d4423be319cc4b7a957abe977aced26e0fa5.

Revert "Fix errors for alias.json"

d11c92c

This reverts commit 0458cbc9489ba8cc05a575517b35001fa4c4a7e8.

fix extension issue

3d68ee2

comment out all other errors.

0413303

revert changes to package.json files

894ac3b

update files. remove common response as it isn't supported.

0d32451

update readonly problem

15038e1

Update error correctly to not be a breaking change

b4f68d9

Remove unused definition.

0ba6c6f

Fix GeoJSONGeometryCollection

14302a2

Fix naming scheme

d89fcce

fix coord abb

9910e1a

fix geometryCollection error by using a more generic type for inherit…

1ea0928

…ance.

update anon def

53f04ac

try without schema

d54c74c

fix naming issue.

e6df6da

add schema

62865ec

try again

5d7871c

update common file

aa36273

v-ddaian added 11 commits June 9, 2021 11:57

Change api version from common to each service.

3a3822c

Add default error.

3238c6b

Update version and route and search with batch. Remove subscription k…

806de82

…ey from examples.

fixes.

9aca553

Re-add 408.

9a7e25b

fixes to errors.

a1e2ce0

update types.

b1d0b14

Update description for batch.

eac0b3e

remove unused errors from examples.

1886c53

fix ci after changes.

3f8c094

fix again errors in examples.

6038041

v-ddaian added 4 commits June 10, 2021 10:47

remove package-preview-1.0 from go.

96167d2

Remove go codegen as track1 isn't supported for data-plane.

778c0bc

Leave go readme. Remove js from ci for now.

33fd792

remove 200 from dataset.

a5d68c5

chgennar reviewed Jun 10, 2021

View reviewed changes

propheel and others added 4 commits June 11, 2021 11:00

Put 200 response back to the Maps LROs. Although those paths do not r…

a8c89c5

…eturn 200 directly (202 instead) the TS codegen takes 200 definition for the response type, so it is needed to deserialize.

Try to use .NET Track 2

f204f29

Workaround TS autogen limitation - loses inherited class properties d…

7809b3c

…ue to invalid deserialization of base class properties only

Fix 200 to be 400 error(fix duplicate)

a9ba08c

propheel closed this Jul 2, 2021

markweitzel added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Jul 9, 2021

markweitzel removed the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Jul 30, 2021

markweitzel removed the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Sep 23, 2021

markweitzel changed the title ~~[Hub Generated] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/2.0~~ [Maps] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/2.0 Oct 12, 2021

czubair added the APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. label Oct 12, 2021

czubair mentioned this pull request Oct 12, 2021

[Maps] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/2.0 #16373

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/2.0 #14694

[Maps] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/2.0 #14694

propheel commented Jun 7, 2021 •

edited

Loading

tjprescott commented Jun 9, 2021 •

edited

Loading

propheel commented Jun 9, 2021

chgennar Jun 10, 2021

propheel Jun 11, 2021

chgennar Jun 11, 2021

propheel commented Jul 2, 2021

[Maps] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/2.0 #14694

[Maps] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/2.0 #14694

Conversation

propheel commented Jun 7, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

tjprescott commented Jun 9, 2021 • edited Loading

propheel commented Jun 9, 2021

chgennar Jun 10, 2021

Choose a reason for hiding this comment

propheel Jun 11, 2021

Choose a reason for hiding this comment

chgennar Jun 11, 2021

Choose a reason for hiding this comment

propheel commented Jul 2, 2021

propheel commented Jun 7, 2021 •

edited

Loading

tjprescott commented Jun 9, 2021 •

edited

Loading