Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add swagger for version 2021-06-15 #14720

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Add swagger for version 2021-06-15 #14720

merged 4 commits into from
Jun 8, 2021

Conversation

navali-msft
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @navali-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2021 •
    edited
    Loading

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    1 similar comment
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2021 •
    edited
    Loading

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @navali-msft navali-msft requested a review from zihzhan-msft June 8, 2021 18:57
    zihzhan-msft
    zihzhan-msft approved these changes Jun 8, 2021
    View reviewed changes
    .../data-plane/CallingServer/preview/2021-06-15-preview/communicationservicescallingserver.json
    "description": "Azure Communication CallingServer Service"
    "version": "2021-06-15-preview",
    "title": "Azure Communication Calling Server Service",
    "description": "Azure Communication Calling Server Service"
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I think we should use CallingServer here for title and description.

    @navali-msft navali-msft merged commit 37acfb4 into zihzhan/communication-callingserver-preview1 Jun 8, 2021
    anuchandy pushed a commit that referenced this pull request Jun 16, 2021
    @zihzhan-msft @Paresh-Arvind-Patil @navali-msft
    Adding Communication CallingServer API preview 0. (#14543)
    556720d 
    * Adding Communication CallingServer API preview1.

* Updated the Swagger to add PlayAudio api for out-call scenario (#14578)

* Updated the servercalling swagger with playAudio api for out-call
* Fixed a typo

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Add preview0 swagger for .net sdk.

* Update SDK Swagger preview0

* Update swagger api version.

* Update swagger api version.

* Removed Model and Internal postfix, added events in swagger (#14639)

* Removed Model and Internal postfix, added events in swagger

* update the title

* Add swagger for version 2021-06-15 (#14720)

* Updated swagger with version 2021-06-15

* Fix the Communication.Common definitions path

* Removed old swagger

* Added unhold to list of custom-word

* Update readme file accourding to new swagger.

* update responses model suffix to result

* Removed error responses and consumes/produces values from all the apis. Changed invite participant to add participant. Other model name related changes.

* Added examples for all the apis.

* Removed error responses from example

* Added back error response type, added response body for add participant operation

* Fix join call example

* Update the examples

Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>
Co-authored-by: navali-msft <66667092+navali-msft@users.noreply.github.com>
Co-authored-by: Naveed Ali <navali@microsoft.com>
    asager pushed a commit to asager/azure-rest-api-specs that referenced this pull request Jun 24, 2021
    @zihzhan-msft @Paresh-Arvind-Patil @navali-msft
    Adding Communication CallingServer API preview 0. (Azure#14543)
    3309be9 
    * Adding Communication CallingServer API preview1.

* Updated the Swagger to add PlayAudio api for out-call scenario (Azure#14578)

* Updated the servercalling swagger with playAudio api for out-call
* Fixed a typo

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Add preview0 swagger for .net sdk.

* Update SDK Swagger preview0

* Update swagger api version.

* Update swagger api version.

* Removed Model and Internal postfix, added events in swagger (Azure#14639)

* Removed Model and Internal postfix, added events in swagger

* update the title

* Add swagger for version 2021-06-15 (Azure#14720)

* Updated swagger with version 2021-06-15

* Fix the Communication.Common definitions path

* Removed old swagger

* Added unhold to list of custom-word

* Update readme file accourding to new swagger.

* update responses model suffix to result

* Removed error responses and consumes/produces values from all the apis. Changed invite participant to add participant. Other model name related changes.

* Added examples for all the apis.

* Removed error responses from example

* Added back error response type, added response body for add participant operation

* Fix join call example

* Update the examples

Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>
Co-authored-by: navali-msft <66667092+navali-msft@users.noreply.github.com>
Co-authored-by: Naveed Ali <navali@microsoft.com>
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @zihzhan-msft @Paresh-Arvind-Patil
    @navali-msft @mkarmark
    Adding Communication CallingServer API preview 0. (Azure#14543)
    58583d9 
    * Adding Communication CallingServer API preview1.

* Updated the Swagger to add PlayAudio api for out-call scenario (Azure#14578)

* Updated the servercalling swagger with playAudio api for out-call
* Fixed a typo

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Add preview0 swagger for .net sdk.

* Update SDK Swagger preview0

* Update swagger api version.

* Update swagger api version.

* Removed Model and Internal postfix, added events in swagger (Azure#14639)

* Removed Model and Internal postfix, added events in swagger

* update the title

* Add swagger for version 2021-06-15 (Azure#14720)

* Updated swagger with version 2021-06-15

* Fix the Communication.Common definitions path

* Removed old swagger

* Added unhold to list of custom-word

* Update readme file accourding to new swagger.

* update responses model suffix to result

* Removed error responses and consumes/produces values from all the apis. Changed invite participant to add participant. Other model name related changes.

* Added examples for all the apis.

* Removed error responses from example

* Added back error response type, added response body for add participant operation

* Fix join call example

* Update the examples

Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>
Co-authored-by: navali-msft <66667092+navali-msft@users.noreply.github.com>
Co-authored-by: Naveed Ali <navali@microsoft.com>
    @JackTn JackTn deleted the navali/acs-callingserver-2021-06-15-preview branch June 16, 2022 00:50
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @zihzhan-msft zihzhan-msft zihzhan-msft approved these changes

    Assignees

    @navali-msft navali-msft

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @navali-msft @zihzhan-msft @jhendrixMSFT