[Hub Generated] Public private branch 'databricks-privatelink' #14756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/3866 |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The child tracked resource, 'privateLinkResources' with immediate parent 'Workspace', must have a list by immediate parent operation. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L1348 |
|
| The child tracked resource, 'privateEndpointConnections' with immediate parent 'Workspace', must have a list by immediate parent operation. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L1424 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.Databricks/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L328 |
|
The schema 'Workspace' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L658 |
|
The schema 'WorkspaceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L686 |
|
The schema 'TrackedResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L790 |
|
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L823 |
|
The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L844 |
|
The schema 'ManagedIdentityConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L897 |
|
The schema 'WorkspaceCustomBooleanParameter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L933 |
|
The schema 'WorkspaceCustomObjectParameter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L949 |
|
The schema 'WorkspaceCustomStringParameter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L965 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/databricks/resource-manager/readme.md tag: specification/databricks/resource-manager/readme.md#tag-package-2021-04-01-preview |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 3 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"databricks/resource-manager/readme.md", "tag":"package-2021-04-01-preview", "details":"Schema 'GroupIdInformation' has a property 'id' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from GroupIdInformation" |
|
| "readme":"databricks/resource-manager/readme.md", "tag":"package-2021-04-01-preview", "details":"Schema 'GroupIdInformation' has a property 'name' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from GroupIdInformation" |
|
| "readme":"databricks/resource-manager/readme.md", "tag":"package-2021-04-01-preview", "details":"Schema 'GroupIdInformation' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from GroupIdInformation" |
|
| 💬 AutorestCore/Exception | "readme":"databricks/resource-manager/readme.md", "tag":"package-2018-04-01", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"databricks/resource-manager/readme.md", "tag":"package-2018-04-01", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"databricks/resource-manager/readme.md",
"tag":"package-2018-04-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"databricks/resource-manager/readme.md",
"tag":"package-2021-04-01-preview",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"databricks/resource-manager/readme.md",
"tag":"package-2021-04-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
NewApiVersionRequired reason: |
|
Hi, @msaranga Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
This was referenced Jun 10, 2021
|
Hi @msaranga, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
JeffreyRichter
added
the
Approved-BreakingChange
JeffreyRichter
approved these changes
Jun 10, 2021
.../databricks/resource-manager/Microsoft.Databricks/preview/2021-04-01-preview/databricks.json
Outdated
Show resolved
Hide resolved
ArcturusZhang
added
WaitForARMFeedback
ArcturusZhang
deleted the
published/Azure/azure-rest-api-specs-pr/databricks-privatelink
branch
This was referenced Jun 11, 2021
Closed
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
…#14756) * adding databricks privatelink endpoint in new apiversion * Merge mised properties in new version * Resolve lint issues * Resolving lint issues * fix prettycheck * updated readme txt file * fix avacodo error * resolving swagger go md file error * added new enum value as per terraform team * suppressed lint issue * Resolving Merge conflicts with master * updated exmple get workspace with private link parameters * Removing unreferenced Examples * Resolving missing property * Resolve Lint Issue * Resolving build errors * Rephrased description * Rephrased on requiredNSGRules Description
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…#14756) * adding databricks privatelink endpoint in new apiversion * Merge mised properties in new version * Resolve lint issues * Resolving lint issues * fix prettycheck * updated readme txt file * fix avacodo error * resolving swagger go md file error * added new enum value as per terraform team * suppressed lint issue * Resolving Merge conflicts with master * updated exmple get workspace with private link parameters * Removing unreferenced Examples * Resolving missing property * Resolve Lint Issue * Resolving build errors * Rephrased description * Rephrased on requiredNSGRules Description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.