Create "2021-06-01-preview" api-version for Azure Attestation service (private endpoint required changes) #14766

gkostal · 2021-06-10T21:17:50Z

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
- 6/14/2021
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
- as soon as possible
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-06-10T21:17:52Z

Hi, @gkostal Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-06-10T21:17:53Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-06-10T21:17:53Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 3 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- attestation/resource-manager/readme.md tag:package-2021-06-01
Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- attestation/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Attestation/preview/2021-06-01-preview/attestation.json#L818
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'PrivateLinkResources_ListByProvider' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Attestation/preview/2021-06-01-preview/attestation.json#L456
⚠️ R4014 - AllResourcesMustHaveGetOperation	The resource 'PrivateLinkResource' does not have get operation, please add it. Location: common-types/resource-management/v1/privatelinks.json#L103

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Attestation/preview/2021-06-01-preview/attestation.json#L316
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PrivateEndpointConnections_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Attestation/preview/2021-06-01-preview/attestation.json#L359
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Attestation/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Attestation/preview/2021-06-01-preview/attestation.json#L30
`❌` R4036 - ImplementPrivateEndpointAPIs	The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Attestation/attestationProvider/{providerName}/privateEndpointConnections/{privateEndpointConnectionName} is missing. Location: Microsoft.Attestation/preview/2021-06-01-preview/attestation.json#L29
`❌` R4036 - ImplementPrivateEndpointAPIs	The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Attestation/attestationProvider/{providerName}/privateLinkResources is missing. Location: Microsoft.Attestation/preview/2021-06-01-preview/attestation.json#L29
`❌` R4036 - ImplementPrivateEndpointAPIs	The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Attestation/attestationProviders/{providerName}/privateEndpointConnections is missing. Location: Microsoft.Attestation/preview/2021-06-01-preview/attestation.json#L29
`❌` R4037 - MissingTypeObject	The schema 'OperationList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Attestation/preview/2021-06-01-preview/attestation.json#L654
`❌` R4037 - MissingTypeObject	The schema 'AttestationProvider' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Attestation/preview/2021-06-01-preview/attestation.json#L707
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Attestation/preview/2021-06-01-preview/attestation.json#L767
`❌` R4037 - MissingTypeObject	The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Attestation/preview/2021-06-01-preview/attestation.json#L776

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.11)
- current:preview/2021-06-01-preview/attestation.json compared with base:stable/2020-10-01/attestation.json

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

attestation/resource-manager/readme.md#package-2021-06-01

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"attestation/resource-manager/readme.md",
"tag":"package-2021-06-01",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"attestation/resource-manager/readme.md",
"tag":"package-2021-06-01",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"attestation/resource-manager/readme.md",
"tag":"package-2021-06-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-06-10T21:17:54Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go - attestation/mgmt/2020-10-01/attestation - v55.2.0
️✔️azure-sdk-for-go - attestation/mgmt/2018-09-01/attestation - v55.2.0
❌azure-sdk-for-python-track2 - track2_azure-mgmt-attestation - 1.0.0

+	Model AttestationServiceCreationSpecificParams no longer has parameter attestation_policy

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9f25bad. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/attestation/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Attestation [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Attestation.0.12.0-preview.nupkg
- Microsoft.Azure.Management.Attestation.0.12.0-preview.snupkg

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 9f25bad. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-attestation [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model PrivateEndpointConnection has a new parameter private_endpoint
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation PrivateEndpointConnectionsOperations.create has a new signature
info	[Changelog]   - Model PrivateEndpointConnection has a new required parameter private_link_service_connection_state

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 9f25bad. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-attestation [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model AttestationProviderListResult has a new parameter system_data
info	[Changelog]   - Model OperationList has a new parameter system_data
info	[Changelog]   - Model AttestationProvider has a new parameter private_endpoint_connections
info	[Changelog]   - Model AttestationProvider has a new parameter system_data
info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model AttestationServiceCreationSpecificParams no longer has parameter attestation_policy

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9f25bad. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️attestation/mgmt/2020-10-01/attestation [View full logs] [Release SDK Changes]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Creating`
info	[Changelog] - New const `Rejected`
info	[Changelog] - New const `Approved`
info	[Changelog] - New const `Failed`
info	[Changelog] - New const `Deleting`
info	[Changelog] - New const `Succeeded`
info	[Changelog] - New const `Pending`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.CreateResponder(*http.Response) (PrivateEndpointConnection, error)`
info	[Changelog] - New function `StatusResult.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.ListResponder(*http.Response) (PrivateEndpointConnectionListResult, error)`
info	[Changelog] - New function `PrivateEndpoint.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.DeleteResponder(*http.Response) (autorest.Response, error)`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.List(context.Context, string, string) (PrivateEndpointConnectionListResult, error)`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.Create(context.Context, string, string, string, PrivateEndpointConnection) (PrivateEndpointConnection, error)`
info	[Changelog] - New function `PossiblePrivateEndpointConnectionProvisioningStateValues() []PrivateEndpointConnectionProvisioningState`
info	[Changelog] - New function `NewPrivateEndpointConnectionsClientWithBaseURI(string, string) PrivateEndpointConnectionsClient`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.CreatePreparer(context.Context, string, string, string, PrivateEndpointConnection) (*http.Request, error)`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.DeletePreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.Delete(context.Context, string, string, string) (autorest.Response, error)`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.CreateSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `*PrivateEndpointConnection.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.DeleteSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.Get(context.Context, string, string, string) (PrivateEndpointConnection, error)`
info	[Changelog] - New function `PrivateEndpointConnection.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `NewPrivateEndpointConnectionsClient(string) PrivateEndpointConnectionsClient`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.ListPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `PossiblePrivateEndpointServiceConnectionStatusValues() []PrivateEndpointServiceConnectionStatus`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.ListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `PrivateEndpointConnectionsClient.GetResponder(*http.Response) (PrivateEndpointConnection, error)`
info	[Changelog] - New struct `PrivateEndpoint`
info	[Changelog] - New struct `PrivateEndpointConnection`
info	[Changelog] - New struct `PrivateEndpointConnectionListResult`
info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
info	[Changelog] - New struct `PrivateEndpointConnectionsClient`
info	[Changelog] - New struct `PrivateLinkServiceConnectionState`
info	[Changelog] - New field `PrivateEndpointConnections` in struct `StatusResult`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 44 additive change(s).
info	[Changelog]

️✔️attestation/mgmt/2018-09-01/attestation [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9f25bad. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/attestation/resource-manager/readme.md

️✔️@azure/arm-attestation [View full logs] [Release SDK Changes]

azure-arm-attestation-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/attestationManagementClient.js → ./dist/arm-attestation.js...
cmderr	[npmPack] created ./dist/arm-attestation.js in 224ms

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 9f25bad. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-06-17 02:28:32 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-attestation;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-06-17 02:28:32 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-06-17 02:28:32 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.30 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/attestation/azure-resourcemanager-attestation --java.namespace=com.azure.resourcemanager.attestation   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/attestation/resource-manager/readme.md
cmderr	[generate.py] 2021-06-17 02:29:03 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-attestation
cmderr	[generate.py] 2021-06-17 02:29:03 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-06-17 02:29:03 INFO [POM][Skip] pom already has module azure-resourcemanager-attestation
cmderr	[generate.py] 2021-06-17 02:29:03 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-06-17 02:29:03 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-06-17 02:29:03 INFO [POM][Skip] pom already has module sdk/attestation
cmderr	[generate.py] 2021-06-17 02:29:03 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-attestation [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-06-17 02:31:22 DEBUG Got artifact_id: azure-resourcemanager-attestation
cmderr	[Inst] 2021-06-17 02:31:22 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-06-17 02:31:22 DEBUG Got artifact: azure-resourcemanager-attestation-1.0.0-beta.2-javadoc.jar
cmderr	[Inst] 2021-06-17 02:31:22 DEBUG Got artifact: azure-resourcemanager-attestation-1.0.0-beta.2.jar
cmderr	[Inst] 2021-06-17 02:31:22 DEBUG Match jar package: azure-resourcemanager-attestation-1.0.0-beta.2.jar
cmderr	[Inst] 2021-06-17 02:31:22 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14766/azure-sdk-for-java/azure-resourcemanager-attestation/azure-resourcemanager-attestation-1.0.0-beta.2.jar\" -o azure-resourcemanager-attestation-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-attestation -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-attestation-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9f25bad. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️attestation [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-06-10T21:17:54Z

Hi, @gkostal your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @

openapi-workflow-bot · 2021-06-10T21:18:52Z

Hi, @gkostal your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @leni-msft

gkostal · 2021-06-10T22:11:36Z

@LarryOsterman - please let me know if you have any feedback, specifically on the remaining validation errors. Thanks!

chiragg4u · 2021-06-14T17:04:35Z

Changes looks good from ARM perspective; Approving it from ARM side.

openapi-workflow-bot · 2021-06-15T00:31:46Z

Hi @gkostal, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

leni-msft · 2021-06-15T00:33:54Z

@msyyc please help check the SDK breaking changes tracking.

gkostal · 2021-06-15T17:23:28Z

re: cross api-version breaking changes. I will push an update to this PR to fix the flagged issue by no longer making the publicNetworkAccess field a required parameter on creation of the attestation provider.

…rovider

… (private endpoint required changes) (Azure#14766) * Copy 2020-10-01 to 2021-06-01-preview * Make changes that define 2021-06-01-preview api-version * Updated readme.md * Address spell checker and lint issues * Switched publicNetworkAccess to optional on creation of attestation provider

gkostal added 2 commits June 10, 2021 14:02

Copy 2020-10-01 to 2021-06-01-preview

0245ee9

Make changes that define 2021-06-01-preview api-version

95403ae

openapi-assignment-bot bot assigned leni-msft Jun 10, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 10, 2021

gkostal changed the title ~~Attestation 2021 06 01 preview~~ Create "2021-06-01-preview" api-version for Azure Attestation service (private endpoint required changes) Jun 10, 2021

openapi-pipeline-app bot added CI-BreakingChange-Python CI-BreakingChange-Python-Track2 labels Jun 10, 2021

Updated readme.md

982690e

Address spell checker and lint issues

c599f33

chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 14, 2021

leni-msft added the BreakingChangeReviewRequired label Jun 15, 2021

Merge branch 'Azure:master' into attestation-2021-06-01-preview

4221a37

Switched publicNetworkAccess to optional on creation of attestation p…

dc0bd7a

…rovider

LarryOsterman approved these changes Jun 15, 2021

View reviewed changes

leni-msft removed the BreakingChangeReviewRequired label Jun 17, 2021

leni-msft merged commit 9f25bad into Azure:master Jun 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create "2021-06-01-preview" api-version for Azure Attestation service (private endpoint required changes) #14766

Create "2021-06-01-preview" api-version for Azure Attestation service (private endpoint required changes) #14766

gkostal commented Jun 10, 2021

openapi-workflow-bot bot commented Jun 10, 2021

openapi-workflow-bot bot commented Jun 10, 2021

openapi-pipeline-app bot commented Jun 10, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 10, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 10, 2021

openapi-workflow-bot bot commented Jun 10, 2021

gkostal commented Jun 10, 2021

chiragg4u commented Jun 14, 2021

openapi-workflow-bot bot commented Jun 15, 2021

leni-msft commented Jun 15, 2021

gkostal commented Jun 15, 2021

Create "2021-06-01-preview" api-version for Azure Attestation service (private endpoint required changes) #14766

Create "2021-06-01-preview" api-version for Azure Attestation service (private endpoint required changes) #14766

Conversation

gkostal commented Jun 10, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jun 10, 2021

openapi-workflow-bot bot commented Jun 10, 2021

openapi-pipeline-app bot commented Jun 10, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 10, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 10, 2021

openapi-workflow-bot bot commented Jun 10, 2021

gkostal commented Jun 10, 2021

chiragg4u commented Jun 14, 2021

openapi-workflow-bot bot commented Jun 15, 2021

leni-msft commented Jun 15, 2021

gkostal commented Jun 15, 2021

openapi-pipeline-app bot commented Jun 10, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 10, 2021 •

edited

Loading