Adding VMSizeProperties for VmSizecustomization #14785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @raktdas Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2021-07-01 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️❌[Staging] SDK Track2 Validation: 1 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-07-01", "details":"Duplicate Schema named PurchasePlan -- properties.promotionCode: undefined => "$ref":"#/components/schemas/schemas:1506", "description":"The Offer Promotion Code." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-07-01", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-07-01", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-07-01", "details":"Error: Plugin prechecker reported failure." |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-07-01", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-07-01-only", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-07-01-only", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
ghost
added
the
customer-reported
Swagger Generation Artifacts
|
|
Thank you for your contribution raktdas! We will review the pull request and get back to you soon. |
…/azure-rest-api-specs into feature/cplat-2021-07-01
…/azure-rest-api-specs into feature/cplat-2021-07-01
…/azure-rest-api-specs into feature/cplat-2021-07-01
…/azure-rest-api-specs into feature/cplat-2021-07-01
…/azure-rest-api-specs into feature/cplat-2021-07-01
This was referenced Jun 14, 2021
…/azure-rest-api-specs into feature/cplat-2021-07-01
…/azure-rest-api-specs into feature/cplat-2021-07-01
…/azure-rest-api-specs into feature/cplat-2021-07-01
…/azure-rest-api-specs into feature/cplat-2021-07-01
This was referenced Jun 19, 2021
|
Hi, @raktdas your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Feel free to merge since this is not targeting the main branch |
…/azure-rest-api-specs into feature/cplat-2021-07-01
…/azure-rest-api-specs into feature/cplat-2021-07-01
specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01/compute.json
Outdated
Show resolved
Hide resolved
...ager/Microsoft.Compute/stable/2021-07-01/examples/CreateOrUpdateAVmWithVMSizeProperties.json
Outdated
Show resolved
Hide resolved
pilor
added
ARMSignedOff
11 tasks
smotwani
reviewed
Jul 7, 2021
specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01/compute.json
Outdated
Show resolved
Hide resolved
smotwani
reviewed
Jul 7, 2021
specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01/compute.json
Outdated
Show resolved
Hide resolved
smotwani
reviewed
Jul 7, 2021
specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01/compute.json
Outdated
Show resolved
Hide resolved
smotwani
reviewed
Jul 7, 2021
...rosoft.Compute/stable/2021-07-01/examples/compute/CreateOrUpdateAVmWithVMSizeProperties.json
Show resolved
Hide resolved
smotwani
reviewed
Jul 7, 2021
specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01/compute.json
Show resolved
Hide resolved
grizzlytheodore
added
the
DoNotMerge
…/azure-rest-api-specs into feature/cplat-2021-07-01
…/azure-rest-api-specs into feature/cplat-2021-07-01
smotwani
approved these changes
Jul 14, 2021
avinashakka
approved these changes
Jul 14, 2021
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.