Azure Health Bot MSI support #14787
Merged
Azure Health Bot MSI support #14787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Azure Health Bot MSI support in API 2021-06-10. 2. Examples fixes. 3. Azure Health Bot naming (not Microsoft Healthcare Bot).
|
Hi, @guy-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
26 tasks
|
Hi, @guy-microsoft your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
This was referenced Jun 13, 2021
chiragg4u
reviewed
Jun 15, 2021
| } | ||
| }, | ||
| "definitions": { | ||
| "Identity": { |
There was a problem hiding this comment.
Where is this definition referred? I would recommend to move such definition which is applicable across RP's to https://github.com/Azure/azure-rest-api-specs/blob/bf44a3b7e5817ffc57b205a6d63c283af96d222b/specification/common-types/resource-management/v2/types.json
There was a problem hiding this comment.
@chiragg4u I referenced it from here to overcome an issue with one of the validations (related to avoiding anonymous types).
Should I create a new PR for updating the "common-types" file, or should I do it in this PR?
chiragg4u
added
ARMSignedOff
|
Changes looks good, please follow the process given @ https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/212/Swagger-PR-Review to continue |
|
@PhoenixHe-msft could you help take a look at the PS generation failure #14787 (comment)? |
|
@dolauli Would you please help on the PS failure? |
|
@dolauli Can you please help with the PS failure? We would like to merge this PR by the end of the month. Thanks. |
|
ping @dolauli |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 14, 2021
Closed
|
Now all validations are good, and ARM signed off. the PR LGTM. |
|
@zhenglaizhang Yes, please merge it if you can. Thanks. |
zhenglaizhang
approved these changes
Jul 14, 2021
This was referenced Jul 14, 2021
Closed
Closed
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Azure Health Bot - copy the existing version into new directory structure. * Azure Health Bot - Updates for new API, including: 1. Azure Health Bot MSI support in API 2021-06-10. 2. Examples fixes. 3. Azure Health Bot naming (not Microsoft Healthcare Bot).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.