Adding stable swaggers #14804
Merged
Adding stable swaggers #14804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @marjanmr Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.HybridNetwork/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.HybridNetwork/stable/2021-05-01/operation.json#L37 |
|
The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L38 |
|
The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L82 |
|
The schema 'NetworkInterface' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L94 |
|
The schema 'NetworkInterfaceIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L128 |
|
The schema 'OsProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L203 |
|
The schema 'LinuxConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L225 |
|
The schema 'SshConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L234 |
|
The schema 'SshPublicKey' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L246 |
|
The schema 'NetworkFunction' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.HybridNetwork/stable/2021-05-01/networkFunction.json#L333 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-05-01/common.json compared with base:preview/2020-01-01-preview/common.json
- current:stable/2021-05-01/device.json compared with base:preview/2020-01-01-preview/device.json
- current:stable/2021-05-01/networkFunction.json compared with base:preview/2020-01-01-preview/networkFunction.json
- current:stable/2021-05-01/networkFunctionVendor.json compared with base:preview/2020-01-01-preview/networkFunctionVendor.json
- current:stable/2021-05-01/operation.json compared with base:preview/2020-01-01-preview/operation.json
- current:stable/2021-05-01/vendor.json compared with base:preview/2020-01-01-preview/vendor.json
- current:stable/2021-05-01/vendorNetworkFunction.json compared with base:preview/2020-01-01-preview/vendorNetworkFunction.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"hybridnetwork/resource-manager/readme.md",
"tag":"package-2021-05-01",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"hybridnetwork/resource-manager/readme.md",
"tag":"package-2021-05-01",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"hybridnetwork/resource-manager/readme.md",
"tag":"package-2021-05-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=224215&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]
Breaking Changes Tracking
️✔️azure-sdk-for-go - preview/hybridnetwork/mgmt/2020-01-01-preview/hybridnetwork - v55.2.0️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-hybridnetwork - 1.0.0b1️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-hybridnetwork [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Model Device has a new parameter system_data info [Changelog] - Model VendorSku has a new parameter system_data info [Changelog] - Model VendorSku has a new parameter network_function_type info [Changelog] - Model RoleInstance has a new parameter system_data info [Changelog] - Model RoleInstance has a new parameter provisioning_state info [Changelog] - Model PreviewSubscription has a new parameter system_data info [Changelog] - Model PreviewSubscription has a new parameter provisioning_state info [Changelog] - Model Vendor has a new parameter system_data info [Changelog] - Model NetworkFunction has a new parameter system_data info [Changelog] - Model NetworkFunction has a new parameter network_function_container_configurations info [Changelog] - Model VendorNetworkFunction has a new parameter system_data
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-06-15 08:14:50 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-hybridnetwork" cmderr [generate.py] 2021-06-15 08:14:50 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-06-15 08:14:50 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.30 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/hybridnetwork/azure-resourcemanager-hybridnetwork --java.namespace=com.azure.resourcemanager.hybridnetwork --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/hybridnetwork/resource-manager/readme.md cmderr [generate.py] 2021-06-15 08:15:23 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-06-15 08:15:23 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-06-15 08:15:23 INFO [POM][Skip] pom already has module azure-resourcemanager-hybridnetwork cmderr [generate.py] 2021-06-15 08:15:23 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-06-15 08:15:23 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-06-15 08:15:23 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-hybridnetwork [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-hybridnetwork-1.0.0-beta.1-javadoc.jar
- azure-resourcemanager-hybridnetwork-1.0.0-beta.1-sources.jar
- azure-resourcemanager-hybridnetwork-1.0.0-beta.1.jar
cmderr [Inst] 2021-06-15 08:18:07 DEBUG Got artifact_id: azure-resourcemanager-hybridnetwork cmderr [Inst] 2021-06-15 08:18:07 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-06-15 08:18:07 DEBUG Got artifact: azure-resourcemanager-hybridnetwork-1.0.0-beta.1-javadoc.jar cmderr [Inst] 2021-06-15 08:18:07 DEBUG Got artifact: azure-resourcemanager-hybridnetwork-1.0.0-beta.1-sources.jar cmderr [Inst] 2021-06-15 08:18:07 DEBUG Got artifact: azure-resourcemanager-hybridnetwork-1.0.0-beta.1.jar cmderr [Inst] 2021-06-15 08:18:07 DEBUG Match jar package: azure-resourcemanager-hybridnetwork-1.0.0-beta.1.jar cmderr [Inst] 2021-06-15 08:18:07 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14804/azure-sdk-for-java/azure-resourcemanager-hybridnetwork/azure-resourcemanager-hybridnetwork-1.0.0-beta.1.jar\" -o azure-resourcemanager-hybridnetwork-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-hybridnetwork -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-hybridnetwork-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️preview/hybridnetwork/mgmt/2020-01-01-preview/hybridnetwork [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️⚠️ azure-sdk-for-js warning [Detail]
warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/hybridnetwork/resource-manager/readme.md warn No file changes detected after generation warn No package detected after generation
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️hybridnetwork [View full logs] [Release Schema Changes]
lirenhe
added
the
WaitForARMFeedback
|
@marjanmr, was this PR already reviewed in RpaasMaster branch or is this a new PR? |
|
Swagger already approved in private repo, https://github.com/Azure/azure-rest-api-specs-pr/pull/4002. |
lirenhe
removed
the
WaitForARMFeedback
lirenhe
approved these changes
Jun 15, 2021
This was referenced Jun 15, 2021
akning-ms
added a commit
that referenced
this pull request
Jun 17, 2021
This reverts commit c8d85bc.
akning-ms
added a commit
that referenced
this pull request
Jun 17, 2021
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
* Adding stable swaggers * change api version
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
This reverts commit c8d85bc.
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Adding stable swaggers * change api version
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
This reverts commit c8d85bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
[ x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
[ x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
[ x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.